Reports - App does not return to initial Reports view after deleting all the expenses

[vincdargento]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.1.16-0
Reproducible in staging?: Yes
Reproducible in production?: Unable to check
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Mac 15.3 / Chrome
App Component: Search

Action Performed:

Precondition:

• Log in with Expensifail account.
• Account has no expenses.

1. Go to staging.new.expensify.com
2. Go to workspace chat.
3. Submit an expense.
4. Go to Reports.
5. Go to Expense Reports.
6. Click on the expense in Step 3.
7. Click on the report header.
8. Click Delete.
9. Delete the expense.

Expected Result:

App will return to the initial Reports view because the expense report is now empty.

Actual Result:

App does not return to initial Reports view after deleting all the expenses.
Report view is blank.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

bug.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @Kicu

[melvin-bot]

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @tylerkaraszewski (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[vincdargento]

@lschurr FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[luacmartins]

This view is behind a beta. NAB. cc @Kicu

[melvin-bot]

@Kicu Whoops! This issue is 2 days overdue. Let's get this updated quick!

[Kicu]

@luacmartins @mountiny you guys sure the described behaviour is bad and the expectation is to return to previous search results?
There is another design doc done atm (as you know :D) for "Report creation flow" and it's all about allowing the report to be empty and adding expenses to it.

So to me it's unclear exactly when - if ever - we should automatically return from this view back to Search.
CC @SzymczakJ

[luacmartins]

I'd expect the view to just change to the empty report view in this case.

[mountiny]

If we only delete the expense and the report remains, then open the empty report. If the report is deleted too, which I believe should be the case when its the last expense, then we should go to the Expense reports list

[Kicu]

which I believe should be the case when its the last expense,

Ok but seems like this is not yet implemented (I'm told by @jnowakow) so someone implementing this might do the redirect. (issue: #57466)

Also what about this scenario:

1. you create new empty report from FAB -> Create Report
2. you see empty report view
3. you add 1 expense
4. you remove said expense -> which in turn removes report
5. feels a bit surprising, doesn't it?

Since we allowed to have report empty after creating it, when its created manually maybe we should also allow it to stay empty after removing transaction?

[trjExpensify]

From the simplified report actions doc, this is the extract:

you remove said expense -> which in turn removes report

"Remove" kinda' covers multiple scenarios, I think we're explicitly talking about Delete here, right?

I can see where it might feel unexpected to delete the expense in this one expense report table view, and the report be deleted as well:

versus this "one expense report" view where it's fauxed as an expense basically:

So perhaps that's the distinction on behaviour?

[Kicu]

Yes what you wrote makes sense @trjExpensify
So the open question then remains - are we sure that on the new view:

in this one expense report table view

do we also want to automatically remove report when the final expense is deleted?

[mountiny]

I would say lets keep it same on all views - remove report - with the confirmation modal (that removes some of the confusion imho) and only if we see some feedback from the users we can update this behaviour.

[trjExpensify]

If that was a view long term, then I think the expectation would be:

1. If you delete the report, the report is deleted and the expense is unreported.
2. If you delete the expense, the report remains and is empty.

But that said, isn't what we're seeing here only temporary until the implementation is complete?

A one expense report view wouldn't look like that, it's that combined hybrid view of the expense/report in the main pane?

CC: @shawnborton

[shawnborton]

Correct, I would expect a single expense report to not have this new table view. At least, that's what we had slated in the design doc.

[luacmartins]

Agree that's a temporary view and a single expense report would have a different UI.

[melvin-bot]

@Kicu @luacmartins @lschurr @mountiny @DylanDylann this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

@Kicu Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@Kicu Still overdue 6 days?! Let's take care of this!

[Kicu]

actually @luacmartins @shawnborton it is a bit unclear to me what are the next steps for this task.
There is a separate task to correctly handle the single expense view in new report View. I'm assuming once we do this, then delete would behave correctly.

Is this enough to have this task done or do we need something more here?

[shawnborton]

Hmm yeah, perhaps let's check this again once the task for the single view is finished?

[mountiny]

Yeah lets keep this one until we clear out the other tasks for single expense view and we can see if there is anything actionable left

[Kicu]

ok here's the PR #59735

[melvin-bot]

@Kicu Huh... This is 4 days overdue. Who can take care of this?

[mountiny]

Asked for a retest

[izarutskaya]

Issue is not reproducible

20250414_214227.mp4

[mountiny]

Great, thank you then we can close this as regression testing and payment will be handled per project