-
Notifications
You must be signed in to change notification settings - Fork 3.2k
[SIDEPANE] Build "Stage 3)" of "Add live-navigating help side pane" #58732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Please assign me here as C+ since we are working on stages 1 and 2. Thanks. 🚀 |
FYI I'm going to be on vacation for about a week starting tomorrow, so we might want to assign to another internal engineer if you have PRs to review. |
Triggered auto assignment to @kadiealexander ( |
|
Triggered auto assignment to Design team member for new feature review - @dubielzyk-expensify ( |
Doing more testing over the weekend, ETA on Monday. |
Stage 3 is on Staging! |
Is this ready for a design review? |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.18-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2025-04-02. 🎊 For reference, here are some details about the assignees on this issue:
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.26-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2025-04-18. 🎊 For reference, here are some details about the assignees on this issue:
|
BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
🟢 No regression test needed yet as the feature is behind beta flag, assuming regression tests will be added upon project completion. @kadiealexander This is for the second PR production deploy I reviewed as C+ here, for which payment is due on 2025-04-16. |
As discussed on NewDot chat with Matt and Francois, and based on my Help Panel contributions, I’d like to propose the following:
Important: One of the issues from the bug list has already been paid by @JmillsExpensify here, so we should deduct $250 from the total. Total: $1,750 These PRs are related to stages 1, 2, and 3 of the Help Panel implementation. The regression period for the last PR in this group ends on April 14th. |
Moving on to stage 4, we have already implemented two PRs:
I believe we should create an issue to track the next PRs in this stage. |
Summary of upcoming paydays:
|
Thanks @brunovjk, looks great to me, thanks for the breakdown. @francoisl , since you're more-closely related, can you provide a comment with a 👍 to confirm then I'll get paid? Thx |
👍 looks correct to me |
https://www.upwork.com/jobs/~021912146737656100430 |
@mallenexpensify Offer accepted ;) |
Contributor+: @brunovjk paid $1,750 via Upwork. Thanks! Leaving open for other payments listed above for Bruno and Kevin. |
@mallenexpensify should I swap with you for this one since you've taken care of it so far? Otherwise happy to help handle the following 2 payments. |
@kadiealexander , please handle the upcoming payments, thx |
@kadiealexander can we proceed with payment here. Later I believe we can close this issue. Thank you. |
We can create a new issue for it if it makes the payment process easier. |
Nah, shouldn't be needed. Just post once the last PR's been on production for a week, then we can pay, thx |
Payment summary here. Have sent offer for the last payment. |
Thank you @kadiealexander. Offer accepted |
@brunovjk paid ya the final $250 and checked the box above. |
Greta!! Exactly, we can close it :D Thanks @mallenexpensify |
Uh oh!
There was an error while loading. Please reload this page.
The design doc for Add live-navigating help side pane.
Specific help content for different types of reports
This update adds contextual help for special reports like #admins rooms and expense reports by replacing generic report IDs with meaningful labels (e.g., /r/:reportID → /r/admins). The report type will be determined using Onyx data.
cc @brunovjk @francoisl
Issue Owner
Current Issue Owner: @kadiealexanderThe text was updated successfully, but these errors were encountered: