Skip to content

[SIDEPANE] Build "Stage 3)" of "Add live-navigating help side pane" #58732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
blazejkustra opened this issue Mar 19, 2025 · 45 comments
Closed

[SIDEPANE] Build "Stage 3)" of "Add live-navigating help side pane" #58732

blazejkustra opened this issue Mar 19, 2025 · 45 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item. Reviewing Has a PR in review Weekly KSv2

Comments

@blazejkustra
Copy link
Contributor

blazejkustra commented Mar 19, 2025

The design doc for Add live-navigating help side pane.

Specific help content for different types of reports

This update adds contextual help for special reports like #admins rooms and expense reports by replacing generic report IDs with meaningful labels (e.g., /r/:reportID → /r/admins). The report type will be determined using Onyx data.

cc @brunovjk @francoisl

Issue OwnerCurrent Issue Owner: @kadiealexander
@brunovjk
Copy link
Contributor

Please assign me here as C+ since we are working on stages 1 and 2. Thanks. 🚀

@francoisl
Copy link
Contributor

FYI I'm going to be on vacation for about a week starting tomorrow, so we might want to assign to another internal engineer if you have PRs to review.

@francoisl francoisl added Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item. labels Mar 19, 2025
Copy link

melvin-bot bot commented Mar 19, 2025

Triggered auto assignment to @kadiealexander (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added the Weekly KSv2 label Mar 19, 2025
Copy link

melvin-bot bot commented Mar 19, 2025

⚠️ It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time ⚠️

Copy link

melvin-bot bot commented Mar 19, 2025

Triggered auto assignment to Design team member for new feature review - @dubielzyk-expensify (NewFeature)

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Weekly KSv2 labels Mar 20, 2025
@quinthar quinthar self-assigned this Mar 21, 2025
@quinthar quinthar added Daily KSv2 and removed Weekly KSv2 labels Mar 21, 2025
@quinthar
Copy link
Contributor

Doing more testing over the weekend, ETA on Monday.

@quinthar
Copy link
Contributor

Stage 3 is on Staging!

@dubielzyk-expensify
Copy link
Contributor

Is this ready for a design review?

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Daily KSv2 labels Mar 26, 2025
@melvin-bot melvin-bot bot changed the title [SIDEPANE] Build "Stage 3)" of "Add live-navigating help side pane" [Due for payment 2025-04-02] [SIDEPANE] Build "Stage 3)" of "Add live-navigating help side pane" Mar 26, 2025
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Mar 26, 2025
Copy link

melvin-bot bot commented Mar 26, 2025

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Mar 26, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.18-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-04-02. 🎊

For reference, here are some details about the assignees on this issue:

@melvin-bot melvin-bot bot changed the title [Due for payment 2025-04-16] [Due for payment 2025-04-02] [SIDEPANE] Build "Stage 3)" of "Add live-navigating help side pane" [Due for payment 2025-04-18] [Due for payment 2025-04-16] [Due for payment 2025-04-02] [SIDEPANE] Build "Stage 3)" of "Add live-navigating help side pane" Apr 11, 2025
Copy link

melvin-bot bot commented Apr 11, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.26-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-04-18. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Apr 11, 2025

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@brunovjk] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@kadiealexander] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@ikevin127
Copy link
Contributor

*[x] [@ikevin127 ] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.

🟢 No regression test needed yet as the feature is behind beta flag, assuming regression tests will be added upon project completion. @kadiealexander This is for the second PR production deploy I reviewed as C+ here, for which payment is due on 2025-04-16.

@brunovjk
Copy link
Contributor

brunovjk commented Apr 14, 2025

As discussed on NewDot chat with Matt and Francois, and based on my Help Panel contributions, I’d like to propose the following:

Total: $2,000

Important: One of the issues from the bug list has already been paid by @JmillsExpensify here, so we should deduct $250 from the total.

Total: $1,750

These PRs are related to stages 1, 2, and 3 of the Help Panel implementation. The regression period for the last PR in this group ends on April 14th.

cc: @mallenexpensify @francoisl

@brunovjk
Copy link
Contributor

Moving on to stage 4, we have already implemented two PRs:

  • #59740 — reviewed by @ikevin127, regression period ends on April 16th
  • #59844 — reviewed by me, regression period ends on April 18th

I believe we should create an issue to track the next PRs in this stage.

@brunovjk
Copy link
Contributor

Summary of upcoming paydays:

  • April 14th – $1,750 to @brunovjk (as detailed above)
  • April 16th – $250 to @ikevin127 (please confirm the amount)
  • April 18th – $250 to @brunovjk (please confirm the amount)

@mallenexpensify
Copy link
Contributor

Thanks @brunovjk, looks great to me, thanks for the breakdown. @francoisl , since you're more-closely related, can you provide a comment with a 👍 to confirm then I'll get paid? Thx

@francoisl
Copy link
Contributor

👍 looks correct to me

@mallenexpensify mallenexpensify changed the title [Due for payment 2025-04-18] [Due for payment 2025-04-16] [Due for payment 2025-04-02] [SIDEPANE] Build "Stage 3)" of "Add live-navigating help side pane" [SIDEPANE] Build "Stage 3)" of "Add live-navigating help side pane" Apr 15, 2025
@mallenexpensify
Copy link
Contributor

https://www.upwork.com/jobs/~021912146737656100430
@brunovjk can you please accept the job and reply here once you have?

@brunovjk
Copy link
Contributor

@mallenexpensify Offer accepted ;)

@mallenexpensify
Copy link
Contributor

Contributor+: @brunovjk paid $1,750 via Upwork.

Thanks!

Leaving open for other payments listed above for Bruno and Kevin.

@kadiealexander
Copy link
Contributor

@mallenexpensify should I swap with you for this one since you've taken care of it so far? Otherwise happy to help handle the following 2 payments.

@kadiealexander
Copy link
Contributor

kadiealexander commented Apr 16, 2025

Payment summary, all paid through Upwork:

@mallenexpensify
Copy link
Contributor

@kadiealexander , please handle the upcoming payments, thx

@brunovjk
Copy link
Contributor

@kadiealexander can we proceed with payment here. Later I believe we can close this issue. Thank you.

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Weekly KSv2 labels Apr 23, 2025
@blazejkustra
Copy link
Contributor Author

There is one last follow up, PR is ready for review @brunovjk

@blazejkustra
Copy link
Contributor Author

We can create a new issue for it if it makes the payment process easier.

@mallenexpensify
Copy link
Contributor

We can create a new issue for it if it makes the payment process easier.

Nah, shouldn't be needed. Just post once the last PR's been on production for a week, then we can pay, thx

@brunovjk
Copy link
Contributor

brunovjk commented May 7, 2025

Payment Summary:

Note: I don't believe we need regression tests here, if I'm wrong, please tell me so I can create them right away :D

@kadiealexander
Copy link
Contributor

Payment summary here. Have sent offer for the last payment.

@brunovjk
Copy link
Contributor

brunovjk commented May 8, 2025

Thank you @kadiealexander. Offer accepted

@mallenexpensify
Copy link
Contributor

@brunovjk paid ya the final $250 and checked the box above.
We good to close this?

@brunovjk
Copy link
Contributor

brunovjk commented May 9, 2025

Greta!! Exactly, we can close it :D Thanks @mallenexpensify

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item. Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Development

No branches or pull requests

8 participants