[Due for payment 2025-04-25] iOS - QBO - Offline indicator is not at the page bottom

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.1.13-0
Reproducible in staging?: Yes
Reproducible in production?: Unable to check
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp #57641
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: iPhone 15 Pro Max / iOS 18.3
App Component: Workspace Settings

Action Performed:

Precondition:

• Workspace is connected to QBO.

1. Launch ND or hybrid app.
2. Go to workspace settings > Accounting.
3. Go to Advanced.
4. Tap Auto-sync.
5. Go offline.

Expected Result:

Offline indicator is at the page bottom.

Actual Result:

Offline indicator is not at the page bottom.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6770245_1741920726473.ScreenRecording_03-14-2025_10-49-42_1.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @laurenreidexpensify

[melvin-bot]

Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @techievivek (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[daledah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Offline indicator is not at the page bottom.

What is the root cause of that problem?

Comes from #57641

In QuickbooksAutoSyncPage we don't set the style for offline indicator

App/src/pages/workspace/accounting/qbo/advanced/QuickbooksAutoSyncPage.tsx

Lines 37 to 41 in 04b9304

	<ScreenWrapper
	includeSafeAreaPaddingBottom={false}
	style={[styles.defaultModalContainer]}
	testID={QuickbooksAutoSyncPage.displayName}
	>

What changes do you think we should make in order to solve the problem?

Add styles.mtAuto to offline indicator style

App/src/pages/workspace/accounting/qbo/advanced/QuickbooksAutoSyncPage.tsx

Lines 37 to 41 in 04b9304

	<ScreenWrapper
	includeSafeAreaPaddingBottom={false}
	style={[styles.defaultModalContainer]}
	testID={QuickbooksAutoSyncPage.displayName}
	>

            <ScreenWrapper
                includeSafeAreaPaddingBottom={false}
                style={[styles.defaultModalContainer]}
                testID={QuickbooksAutoSyncPage.displayName}
                offlineIndicatorStyle={styles.mtAuto}
            >

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[daledah]

@techievivek I can help raise a quick PR if needed.

[techievivek]

It is coming from this PR https://github.com/Expensify/App/pull/57641/files, so I will let the author handle this.
CC @twilight2294 can you please take a look into it.

[techievivek]

Also, I don't think this needs to be a blocker.

[mountiny]

Might also be in correlation with changes from @chrispader

[techievivek]

Yeah, it looked like that to me as well after I saw that PR.

[chrispader]

The proposal from @daledah above is correct for now. Here's the PR: #58514

I fixed issues with the OfflineIndicator more holistically in #58507. @mountiny can we try getting this merged soon?

We can then migrate this screen as part of the Workspace screens migration PR in #57281

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.29-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• New Feature: "When to export" selector for auto-sync for Quickbooks Online #58980

If no regressions arise, payment will be issued on 2025-04-25. 🎊

For reference, here are some details about the assignees on this issue:

• @hungvu193 requires payment through NewDot Manual Requests
• @chrispader does not require payment (Contractor)

[melvin-bot]

@hungvu193 @laurenreidexpensify @hungvu193 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[laurenreidexpensify]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other:

Where bug was reported:

• 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
• 2b. Reported on staging (eg. found during regression or PR testing)
• 2d. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment:

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion:

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

Regression Test Proposal Template

• [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

  Link to issue:

Regression Test Proposal

Precondition:

Test:

Do we agree 👍 or 👎

[laurenreidexpensify]

@hungvu193 can you pls fill out checklist thanks

[hungvu193]

This issue was fixed here: #58980,

And we decided to close the linked PR #58514 (comment)

I think we can close this issue @laurenreidexpensify

[mountiny]

That sounds good