[$250][Back nav] LHN - On tapping device back button to close troubleshoot box from LHN, navigated out of site

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: V9.1.12-5
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N
Email or phone of affected tester (no customers): N
Issue reported by: Applause Internal Team
Device used: Redminote 10s android 13
App Component: User Settings

Action Performed:

1. Open a new tab and go to https://staging.new.expensify.com/home
2. Login with an account
3. Perform a 4 finger gesture
4. Tap device back button

Expected Result:

On tapping device back button to close troubleshoot box from LHN, troubleshoot box must be closed.

Actual Result:

On tapping device back button to close troubleshoot box from LHN, user navigated out of the site.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6769744_1741875111681.Screenrecorder-2025-03-13-19-33-05-338.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021900248434420942939
• Upwork Job ID: 1900248434420942939
• Last Price Increase: 2025-03-13
• Automatic offers:
• nyomanjyotisa | Contributor | 106559557

Issue Owner

Current Issue Owner: @hungvu193

[melvin-bot]

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[Themoonalsofall]

🚨 Edited by proposal-police: This proposal was edited at 2025-03-13 16:05:59 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

LHN - On tapping device back button to close troubleshoot box from LHN, navigated out of site

What is the root cause of that problem?

We don't pass props shouldHandleNavigationBack in this Modal

App/src/components/TestToolsModal.tsx

Lines 50 to 54 in c3aa5d6

	<Modal
	isVisible={!!isTestToolsModalOpen}
	type={CONST.MODAL.MODAL_TYPE.CENTERED_SMALL}
	onClose={toggleTestToolsModal}
	>

What changes do you think we should make in order to solve the problem?

We should add props shouldHandleNavigationBack={isMobileChrome()}

Similar we do

App/src/components/EmojiPicker/EmojiPicker.tsx

Line 197 in c3aa5d6

shouldHandleNavigationBack={Browser.isMobileChrome()}

App/src/components/Search/SearchRouter/SearchRouterModal.tsx

Line 39 in c3aa5d6

shouldHandleNavigationBack={isMobileChrome()}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

Navigation bug, no need to tests

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[nyomanjyotisa]

Please re-state the problem that we are trying to solve in this issue.

LHN - On tapping device back button to close troubleshoot box from LHN, navigated out of site

What is the root cause of that problem?

We don't pass the shouldHandleNavigationBack prop to this Modal

What changes do you think we should make in order to solve the problem?

Pass shouldHandleNavigationBack here without isMobileChrome() since the issue is on Desktop web as well

And it will cause another issue where the modal will appear again after we close/goback, because we use toggleTestToolsModal to the onClose prop

We should create closeTestToolsModal function and pass it to the onClose instead of using toggle function, like we did in all other places

function closeTestToolsModal() {
    if (isTestToolsModalOpen) {
        Onyx.set(ONYXKEYS.IS_TEST_TOOLS_MODAL_OPEN, false);
    }
}

        <Modal
            isVisible={!!isTestToolsModalOpen}
            type={CONST.MODAL.MODAL_TYPE.CENTERED_SMALL}
            onClose={closeTestToolsModal}
            shouldHandleNavigationBack
        >

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021900248434420942939

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hungvu193 (External)

[hungvu193]

I'll review proposals today

[hungvu193]

Thanks @nyomanjyotisa This issue doesn't happen on the Desktop, I don't think we have a back button on Desktop. Also, we're reusing toggleTestToolsModal to toggle the TestToolModal in other places. I really don't want to remove it [here](

App/src/components/TestToolsModal.tsx

Line 45 in 1743a93

onClose={toggleTestToolsModal}

) in order to fix a bug that we introduce to fix another bug. That's confused 🤕

I'm aligned with @Themoonalsofall 's proposal here, as it has the correct RCA and straightforward solution.
🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @blimpich, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[nyomanjyotisa]

@hungvu193 I mentioned desktop web / MacOS chrome

The issue is on Desktop web/MacOS chrome as well:

New-Tab.mp4

MacOS chrome also checked on OP:

[hungvu193]

@nyomanjyotisa OOps my bad.

The issue is on Desktop web/MacOS chrome as well:

This makes sense and we also need to address this bug as well.

@blimpich Please hold on to the assignment. I need to revise my review

[hungvu193]

Let's go with @nyomanjyotisa 's proposal here.

There's a similar problem with Search Dialog (Command + K shortcut). Please fix it as well. Ty

@blimpich All yours

[melvin-bot]

📣 @nyomanjyotisa 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

@hungvu193 @garrettmknight @hungvu193 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[hungvu193]

Little bump @nyomanjyotisa for the above comment. That's OK if you don't think you can fix those issues, we can open this issue for proposals again.

[nyomanjyotisa]

I will raise the fix PR soon

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.46-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix: On tapping device back button to close troubleshoot box from LHN, navigated out of site #58608

If no regressions arise, payment will be issued on 2025-05-27. 🎊

For reference, here are some details about the assignees on this issue:

• @hungvu193 requires payment through NewDot Manual Requests
• @nyomanjyotisa requires payment automatic offer (Contributor)

[melvin-bot]

@hungvu193 @garrettmknight @hungvu193 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[melvin-bot]

@hungvu193 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[garrettmknight]

@hungvu193 can you complete the checklist and I'll pay out?

[hungvu193]

@hungvu193 can you complete the checklist and I'll pay out?

Oh not yet. The PR was reverted and contributor is working on a fix here