[$125] Unmask Close Account dialog in FullStory

[puneetlath]

Currently the fields in the Close Account dialog are masked when viewed in FullStory. Let's unmask them to make it easier to see why users are closing their accounts when they do.

Slack convo: https://expensify.slack.com/archives/C07NZ8B1VTQ/p1741617150467889

Issue Owner

Current Issue Owner: @

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021901654478018442389
• Upwork Job ID: 1901654478018442389
• Last Price Increase: 2025-03-17

Issue Owner

Current Issue Owner: @abekkala

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @akinwale (External)

[melvin-bot]

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

[mkzie2]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Unmask Close Account dialog in FullStory

What is the root cause of that problem?

Feature request

What changes do you think we should make in order to solve the problem?

Add these:

fsClass={CONST.FULL_STORY.UNMASK}
testID={CONST.FULL_STORY.UNMASK}

To CloseAccountPage here.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

None

[github-actions]

⚠️ Thanks for your proposal. Please update it to follow the proposal template, as proposals are only reviewed if they follow that format (note the mandatory sections).

[akinwale]

@mkzie2 Could you post a video demonstrating your solution?

[nyomanjyotisa]

🚨 Edited by proposal-police: This proposal was edited at 2025-03-11 16:00:49 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Unmask Close Account dialog in FullStory

What is the root cause of that problem?

Update request

What changes do you think we should make in order to solve the problem?

In my opinion we should keep the second input field and its text/label masked since it contains user email/default contact method

So, only unmask the first input field here

App/src/pages/settings/Security/CloseAccountPage.tsx

Lines 93 to 102 in c0ebd07

	<InputWrapper
	InputComponent={TextInput}
	inputID={INPUT_IDS.REASON_FOR_LEAVING}
	autoGrowHeight
	maxAutoGrowHeight={variables.textInputAutoGrowMaxHeight}
	label={translate('closeAccountPage.enterMessageHere')}
	aria-label={translate('closeAccountPage.enterMessageHere')}
	role={CONST.ROLE.PRESENTATION}
	containerStyles={[styles.mt5]}
	/>

<InputWrapper
    ...
    fsClass={CONST.FULL_STORY.UNMASK}
    testID={CONST.FULL_STORY.UNMASK}
/>

and add useLayoutEffect(parseFSAttributes, []); on CloseAccountPage

Also unmask the first input label/text as well if needed here

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

[mkzie2]

@akinwale AFAIK, these FullStory unmask issues are labelled Internal QA as we don't have access to FullStory. Only internal engineers can test it.

[Shahidullah-Muffakir]

🚨 Edited by proposal-police: This proposal was edited at 2025-03-11 16:03:17 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Unmask Close Account dialog in FullStory

What is the root cause of that problem?

The fsClass is not used here:

App/src/pages/settings/Security/CloseAccountPage.tsx

Line 91 in c0ebd07

<View style={[styles.flexGrow1]}>

What changes do you think we should make in order to solve the problem?

We should add

   fsClass={CONST.FULL_STORY.UNMASK}
    testID={CONST.FULL_STORY.UNMASK}

to the wrapper <View> that contains the input fields Here This will unmask all its chilren, no need for separately unmasking. Additionally, we should call useLayoutEffect(parseFSAttributes, []) to make sure FullStory processes these attributes correctly at runtime.
the same way it is done here:

App/src/pages/home/report/ReportActionsList.tsx

Lines 723 to 724 in 1e82fae

	// Parse Fullstory attributes on initial render
	useLayoutEffect(parseFSAttributes, []);

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

For the testing, we will mock the Fullstory library dependency the same way it is done here:

App/tests/ui/components/TabSelectorItem.tsx

Lines 8 to 13 in 1e82fae

	jest.mock('@libs/Fullstory', () => ({
	default: {
	consentAndIdentify: jest.fn(),
	},
	parseFSAttributes: jest.fn(),
	}));

What alternative solutions did you explore? (Optional)

[github-actions]

⚠️ @Shahidullah-Muffakir Thanks for your proposal. Please update it to follow the proposal template, as proposals are only reviewed if they follow that format (note the mandatory sections).

[akinwale]

@Shahidullah-Muffakir's proposal offers a complete solution here.

🎀👀🎀 C+ reviewed.

[melvin-bot]

Current assignee @puneetlath is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

[Shahidullah-Muffakir]

@akinwale PR is ready for your review.

[joekaufmanexpensify]

@akinwale please request payment at your earliest convenience. Closing as this is otherwise all set. Thanks everyone!

[JmillsExpensify]

$125 approved for @akinwale

[arosiclair]

@puneetlath just a heads up, it doesn't look like the PR for this worked: #55512 (comment)

[puneetlath]

@Shahidullah-Muffakir @akinwale would you be able to look into that?

[Shahidullah-Muffakir]

@Shahidullah-Muffakir @akinwale would you be able to look into that?

It's strange, the fs-class="fs-unmask" is correctly attached to the textarea on the Close Account page, but it's still showing as masked in FullStory. I'll check it out and share an update soon.

[joekaufmanexpensify]

@Shahidullah-Muffakir have you had a chance to look into this more?

[Shahidullah-Muffakir]

@Shahidullah-Muffakir have you had a chance to look into this more?

I haven’t found the exact cause yet. since we use the same fsClass="fs-unmask" in other parts of the app, does it work there? that might help us figure this out.

according to the FullStory docs for React Native, we’re correctly using fsClass="fs-unmask". I’m wondering if this might be something specific to how it runs in the web environment.

[joekaufmanexpensify]

I haven’t found the exact cause yet. since we use the same fsClass="fs-unmask" in other parts of the app, does it work there? that might help us figure this out.

Is there somewhere else specific we use it? Happy to try and see if i can determine this.

[Shahidullah-Muffakir]

Is there somewhere else specific we use it? Happy to try and see if i can determine this.

Yes, it's used in a few places, but not on any TextInput components. It's mainly used to unmask text.

for ex, here:

App/src/components/FeatureTrainingModal.tsx

Line 338 in 93657d2

fsClass={CONST.FULL_STORY.UNMASK}

It's used to unmask the educational tooltip. Maybe we can test if it works there.

that said, our current case is a bit different, we're trying to unmask a textarea, so the behavior might not be exactly the same.

also, one thing I’m wondering, could it be that TextInputs are globally masked from the FullStory settings? Is that possible?

[joekaufmanexpensify]

Hmm, I am not super familiar with how FullStory masking works. Maybe @puneetlath knows, I have seen him involved in some prior discussions on it. Otherwise, I can try to loop someone else in to try and figure out the TextInputs thing.

[joekaufmanexpensify]

Started discussion

[joekaufmanexpensify]

Still discussing in slack how to proceed.

[joekaufmanexpensify]

Reached out to fullstory support

[joekaufmanexpensify]

I heard back from FullStory. We seem to have a path forward.

[joekaufmanexpensify]

Working on unmasking text area in FS settings.

[joekaufmanexpensify]

Bumped the slack thread

[joekaufmanexpensify]

Still discussing in slack

[joekaufmanexpensify]

Bumped slack thread

[melvin-bot]

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[joekaufmanexpensify]

As an FYI, I'm going to be OOO from May 21st - May 30th. Assigning another BZ during that time to help push this forward. Here is a summary:

• We tried to unmask the close account dialog in FullStory with this PR.
• It didn't work. So we emailed fullstory who advised we need to do this by setting a privacy rule.
• We tried that and it also didn't work.
• We are investigating further here whether there is a path forward to do this.

Next step is to keep bumping that thread above to move this forward. I will take it back over if it's still open when I get back!