[Due for payment 2025-04-07] Task - Not here page opens when inline image preview is opened in the task report

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.1.11-1
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp #54165
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Mac 15.3 / Chrome
App Component: Other

Action Performed:

1. Go to staging.new.expensify.com
2. Go to chat.
3. Click + > Assign task.
4. Click Title.
5. Enter the following inline image mark down:

test test

6. Save the title and create the task.
7. Click on the image in the task preview.
8. Note that the image does not expand to full screen.
9. Go to task report.
10. Click on the image in the task title.
11. Note that Not here page opens.
12. Go to Reports > Chats.
13. Click on the image in the task preview.
14. Note that the image is rendered in full screen without issue.

Expected Result:

In Step 8, the image should open in full screen when clicked from the task preview.
In Step 11, the image should be rendered in full screen without issue.

Actual Result:

In Step 8, the image does not open in full screen when clicked from the task preview.
In Step 11, Not here page opens when the image is opened in the task report.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6767087_1741680164095.task_bug.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @RachCHopkins

[melvin-bot]

Triggered auto assignment to @RachCHopkins (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @NikkiWines (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[truph01]

Regression from #54165

[Krishna2323]

@NikkiWines , please assign me here, I'll fix this.

[mananjadhav]

@Krishna2323 this one has to be a deploy blocker along with the description not saving. Can you please raise a PR asap so that we can get it fixed?

[Krishna2323]

@mananjadhav I don't think this is a blocker because most probably we will remove image rendering from task titles. I'm opening a PR for description save issue.

[mananjadhav]

because most probably we will remove image rendering from task titles

@Expensify/design Your thoughts?

[dannymcclain]

Fair warning I don't have a ton of context around this, but my gut says we'll likely not want to render markdown images in task titles. I can see how adding an image to the description makes sense, but to the title? That seems strange to me. :my-2-cents:

[shawnborton]

Totally agree with that Danny.

[mananjadhav]

I think we should demote this from Deploy Blocker then @NikkiWines

[NikkiWines]

Sounds good 👍

[RachCHopkins]

I'm also having trouble understanding the use case of someone adding an image to a task title. Should the solution be to not-allow someone to try put an image in a title?

[dubielzyk-expensify]

Totally agree with the designers.

I'm also having trouble understanding the use case of someone adding an image to a task title. Should the solution be to not-allow someone to try put an image in a title?

Agree with this too. In general when we allow markdown we don't really try to pick and mix which of the markdown features we support which is why we kinda allow all.

I could see a world where we wanna put the green plus button (+) image that we recently added in the title, but again, I think it'll just lead to more pain so let's just not allow it.

[Krishna2323]

@Expensify/design, before fixing regressions that are mostly related to rendering all tags, I want to confirm which render styles we want to keep for the title. I believe it should be link, inline code, and strikethrough, correct? Please refer to this comment.

[shawnborton]

And Italic too I believe, but not bold nor bold italic.

[Krishna2323]

@shawnborton thanks for confirming. BTW, what should we do with the images? Should we render the link or just skip rendering anything?

[shawnborton]

Probably makes sense to render the link, so we aren't doing anything confusing by hiding something?

[dannymcclain]

Agree with all the comments above!

[Krishna2323]

This PR will fix the issue. Waiting for @mananjadhav's review.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.20-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: title image rendering in task preview and task view. #58555

If no regressions arise, payment will be issued on 2025-04-07. 🎊

For reference, here are some details about the assignees on this issue:

• @mananjadhav requires payment through NewDot Manual Requests
• @Krishna2323 requires payment (Needs manual offer from BZ)

[melvin-bot]

@mananjadhav @RachCHopkins @mananjadhav The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[mananjadhav]

Linked PR was deployed to production. Payout should be handled in the original issue. #53175

[melvin-bot]

Payment Summary

Upwork Job

• Reviewer: @mananjadhav owed $250 via NewDot
• ROLE: @Krishna2323 paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@RachCHopkins)

• I have verified the correct assignees and roles are listed above and updated the necessary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[RachCHopkins]

No payment due for this issue.