[Due for payment 2025-04-02] [$250] Travel - App crashes when user books travel

[vincdargento]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: v9.1.10-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/cases/view/3940513
Email or phone of affected tester (no customers): new expensifail account
Issue reported by: Applause Internal Team
Device used: Windows 11 / Chrome
App Component: Other

Action Performed:

Precondition:

1. use new expensifail account, signed up via OD.
2. Workspace added to account and script applied:
   var settings = NVP.get('travelSettings') || {};
   settings.testAccount = true;
   NVP.set('travelSettings', settings);
3. Address added to ws: "548 Market St San Francisco, CA 94104, United States"

STR:

1. Login to ND
2. Book a travel (e.g. flight) on https://staging.travel.expensify.com/
3. Switch back to tab where ND is opened

Expected Result:

Page is loaded

Actual Result:

App crashes. User need to refresh page.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

bug.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021899593598146906203
• Upwork Job ID: 1899593598146906203
• Last Price Increase: 2025-03-18

Issue Owner

Current Issue Owner: @johncschuster

[melvin-bot]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

@johncschuster Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021899593598146906203

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jayeshmangwani (External)

[melvin-bot]

@jayeshmangwani Huh... This is 4 days overdue. Who can take care of this?

[jayeshmangwani]

We're awaiting proposals here.

[VickyStash]

Hi, I'm Viktoryia from Callstack - expert contributor group - and I would like to work on this issue.

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[VickyStash]

I can't fully follow test steps of this issue, cause I'm always navigated to prod travel URL (https://travel.expensify.com/).
I believe setting settings.testAccount = true; doesn't work anymore, since this PR was implemented.
It looks like now I need to have an account in an expensifail/applause domain to be able to debug Travel issues.
cc @rlinoz maybe you have an idea how can I book a test travel if I'm not in the expensifail/applause domains?

[rlinoz]

@VickyStash I can add you to a policy that works for staging, just send me an email of a new user

[VickyStash]

@rlinoz Awesome! The user is [email protected]

[rlinoz]

Done, just set the policy 314C5F5ACA7EABBE as your default and it should work!

[VickyStash]

@rlinoz I have the policy 314C5F5ACA7EABBE set as default, but when I try to accept Terms&Conditions for the travel, I get this error:
"401 User tried to provision travel on non-member domain"

err_video.mp4

[rlinoz]

@VickyStash my bad, I forgot to enable travel in that policy, it should work now

[johncschuster]

Bumping for Melvin

[rlinoz]

I didn't notice, thanks, I can be the CME here

[melvin-bot]

@rlinoz @johncschuster @VickyStash @jayeshmangwani this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[VickyStash]

The FE PR has been opened for review!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.18-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix app crash when user books travel #58899

If no regressions arise, payment will be issued on 2025-04-02. 🎊

For reference, here are some details about the assignees on this issue:

• @VickyStash does not require payment (Contractor)
• @jayeshmangwani requires payment through NewDot Manual Requests

[melvin-bot]

@jayeshmangwani @johncschuster @jayeshmangwani The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[johncschuster]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other:

Where bug was reported:

• 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
• 2b. Reported on staging (eg. found during regression or PR testing)
• 2d. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment:

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion:

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

Regression Test Proposal Template

• [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

  Link to issue:

Regression Test Proposal

Precondition:

Test:

Do we agree 👍 or 👎

[johncschuster]

Payment Summary

Contributor: @VickyStash does not require payment (Contractor)
Contributor+: @jayeshmangwani owed $250 via NewDot (to be paid after regression window and BZ Checklist has been completed)

[melvin-bot]

Payment Summary

Upwork Job

• Contributor: @VickyStash is from an agency-contributor and not due payment
• Reviewer: @jayeshmangwani owed $250 via NewDot

BugZero Checklist (@johncschuster)

• I have verified the correct assignees and roles are listed above and updated the necessary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1899593598146906203/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[jayeshmangwani]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other:

Where bug was reported:

• 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
• 2b. Reported on staging (eg. found during regression or PR testing)
• 2d. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment: [VIP-Travel] Create Trip Room Preview #38808

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion: N/A

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

I'm not sure we need a dedicated regression for this case, as it’s not something that will happen after adding a check for tripData.startDate and tripData.endDate.

However, if we still want to create one, I propose the following steps:

Regression Test Proposal

Precondition: User is added to a travel-enabled workspace.

1. Log in with a user who is added to a workspace with Travel Beta enabled.
2. Navigate to FAB -> Book Travel.
3. Book a one-way trip on https://staging.travel.expensify.com/
4. Switch back to the tab where ND is open.
5. Verify that ND works fine and the app does not crash.

Do we agree 👍 or 👎

[johncschuster]

@VickyStash and @jayeshmangwani Thanks for your contributions! @jayeshmangwani, please request payment via ND. Payment Summary can be found here!

[garrettmknight]

$250 approved for @jayeshmangwani