Skip to content

[Due for payment 2025-03-24] iOS - Help panel - Unable to swipe right to close the help page #57855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 of 8 tasks
vincdargento opened this issue Mar 5, 2025 · 20 comments
Closed
2 of 8 tasks
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering

Comments

@vincdargento
Copy link

vincdargento commented Mar 5, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.1.9-2
Reproducible in staging?: Yes
Reproducible in production?: Unable to check
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: iPhone 15 Pro Max / iOS 18.3
App Component: Other

Action Performed:

Precondition:

  • Help panel feature is enabled by switching language to Spanish and back to English.
  1. Launch ND or hybrid app.
  2. Tap help icon.
  3. Swipe to right to close help page.

Expected Result:

Help page can be closed by swiping to right.

Actual Result:

Help page cannot be closed by swiping to right.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

bug.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @bfitzexpensify
@vincdargento vincdargento added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 DeployBlockerCash This issue or pull request should block deployment labels Mar 5, 2025
Copy link

melvin-bot bot commented Mar 5, 2025

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Mar 5, 2025

Triggered auto assignment to @amyevans (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Mar 5, 2025

💬 A slack conversation has been started in #expensify-open-source

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Mar 5, 2025
Copy link
Contributor

github-actions bot commented Mar 5, 2025

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@amyevans
Copy link
Contributor

amyevans commented Mar 5, 2025

Not widely released yet so not a blocker.

cc @francoisl @blazejkustra

@amyevans amyevans added Daily KSv2 Hourly KSv2 and removed Hourly KSv2 DeployBlockerCash This issue or pull request should block deployment Daily KSv2 labels Mar 5, 2025
@blazejkustra
Copy link
Contributor

Hey! I’m Błażej Kustra from Software Mansion, this regression comes from my #56490 so I'd like to work on it 👀

Copy link

melvin-bot bot commented Mar 10, 2025

@amyevans, @bfitzexpensify, @blazejkustra Whoops! This issue is 2 days overdue. Let's get this updated quick!

@amyevans
Copy link
Contributor

How's this coming along @blazejkustra?

@melvin-bot melvin-bot bot removed the Overdue label Mar 10, 2025
@blazejkustra
Copy link
Contributor

This week I'm focusing on side pane bugs with Adam from SWM, will keep you posted!

@blazejkustra
Copy link
Contributor

It is very connected to the other issue for android.

Help pane isn't technically a screen so you can't dismiss it with a back button and swipe gesture. I need to check what we can do with this, will update tomorrow.

@blazejkustra
Copy link
Contributor

Update: I opened a draft PR for this 🚀

@amyevans
Copy link
Contributor

Woo! 👏

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Mar 12, 2025
@blazejkustra
Copy link
Contributor

PR is ready for C+ review, could you assign @brunovjk to this issue? 😄

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Mar 17, 2025
@melvin-bot melvin-bot bot changed the title iOS - Help panel - Unable to swipe right to close the help page [Due for payment 2025-03-24] iOS - Help panel - Unable to swipe right to close the help page Mar 17, 2025
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Mar 17, 2025
Copy link

melvin-bot bot commented Mar 17, 2025

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Mar 17, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.13-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-03-24. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Mar 17, 2025

@brunovjk @bfitzexpensify @brunovjk The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Mar 24, 2025
Copy link

melvin-bot bot commented Mar 24, 2025

Payment Summary

Upwork Job

  • Contributor: @blazejkustra is from an agency-contributor and not due payment
  • ROLE: @brunovjk paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@bfitzexpensify)

  • I have verified the correct assignees and roles are listed above and updated the necessary manual offers
  • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
  • I have paid out the Upwork contracts or cancelled the ones that are incorrect
  • I have verified the payment summary above is correct

@brunovjk
Copy link
Contributor

This issue is part of some regressions during the implementation of Help Panel. I think we can follow the payment on the original issues.

@amyevans
Copy link
Contributor

Sounds good, I believe we're set to close then!

@brunovjk
Copy link
Contributor

brunovjk commented Mar 27, 2025

I can't reproduce this anymore after implementing this PR. Tested on 27 Mar v9.1.20-2 Develop. We can close, payment and BZ checklist will be handled here. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering
Projects
None yet
Development

No branches or pull requests

5 participants