-
Notifications
You must be signed in to change notification settings - Fork 3.2k
[Due for payment 2025-03-24] iOS - Help panel - Unable to swipe right to close the help page #57855
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Triggered auto assignment to @bfitzexpensify ( |
Triggered auto assignment to @amyevans ( |
💬 A slack conversation has been started in #expensify-open-source |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
Not widely released yet so not a blocker. |
Hey! I’m Błażej Kustra from Software Mansion, this regression comes from my #56490 so I'd like to work on it 👀 |
@amyevans, @bfitzexpensify, @blazejkustra Whoops! This issue is 2 days overdue. Let's get this updated quick! |
How's this coming along @blazejkustra? |
This week I'm focusing on side pane bugs with Adam from SWM, will keep you posted! |
It is very connected to the other issue for android. Help pane isn't technically a screen so you can't dismiss it with a back button and swipe gesture. I need to check what we can do with this, will update tomorrow. |
Update: I opened a draft PR for this 🚀 |
Woo! 👏 |
PR is ready for C+ review, could you assign @brunovjk to this issue? 😄 |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.13-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2025-03-24. 🎊 For reference, here are some details about the assignees on this issue:
|
@brunovjk @bfitzexpensify @brunovjk The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button] |
Payment Summary
BugZero Checklist (@bfitzexpensify)
|
This issue is part of some regressions during the implementation of Help Panel. I think we can follow the payment on the original issues. |
Sounds good, I believe we're set to close then! |
I can't reproduce this anymore after implementing this PR. Tested on 27 Mar v9.1.20-2 Develop. We can close, payment and BZ checklist will be handled here. Thanks! |
Uh oh!
There was an error while loading. Please reload this page.
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: 9.1.9-2
Reproducible in staging?: Yes
Reproducible in production?: Unable to check
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: iPhone 15 Pro Max / iOS 18.3
App Component: Other
Action Performed:
Precondition:
Expected Result:
Help page can be closed by swiping to right.
Actual Result:
Help page cannot be closed by swiping to right.
Workaround:
Unknown
Platforms:
Screenshots/Videos
bug.mp4
View all open jobs on GitHub
Issue Owner
Current Issue Owner: @bfitzexpensifyThe text was updated successfully, but these errors were encountered: