[Due for payment 2025-03-24] Android - Help panel - Incorrect navigation with device back button when help panel is opened

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.1.9-1
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Samsung Galaxy Z Fold 4 / Android 14
App Component: Other

Action Performed:

Precondition:

• Help panel feature is enabled by switching language to Spanish and back to English.

Bug 1:

1. Launch ND or hybrid app.
2. Tap help icon on Home page.
3. Use device back button (or Android gesture) to close the panel.
4. Note that instead of closing the panel, app closes.
5. Kill and relaunch the app.
6. Note that app opens help panel instead of LHN.

Bug 2:

1. Launch ND or hybrid app.
2. Go to Settings.
3. Go to Workspaces.
4. Tap help icon.
5. Use device back button (or Android gesture) to close the panel.

Expected Result:

Bug 1:

• In Step 4, the help panel will close when using device back button or Android gesture.
• In Step 6, after relaunching the app, app will open LHN.

Bug 2:

• In Step 5, help panel will close and app opens Workspaces.

Actual Result:

Bug 1:

• In Step 4, app closes when using device back button or Android gesture to close help panel.
• In Step 6, after relaunching the app, app opens help panel instead of LHN.

Bug 2:

• In Step 5, help panel still opens but different help page. When swiping back a few times, app closes and help panel never closes once.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

https://github.com/user-attachments/assets/d0722519-5de0-47ab-b2c8-742f1c150fdb
https://github.com/user-attachments/assets/3cfda779-5a4c-4d8b-902c-026b0297452d

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @lschurr

Issue Owner

Current Issue Owner: @lschurr

[melvin-bot]

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @madmax330 (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[lschurr]

What's the deal with this one @madmax330? Should it be External?

[lschurr]

Maybe @puneetlath since you changed it to Daily.. is this still happening and should it be External?

[puneetlath]

Responded in NewDot.

[izarutskaya]

Both issues are still reproduced.

Screen_Recording_20250311_232606_Expensify.mp4

[blazejkustra]

Hey! I’m Błażej Kustra from Software Mansion, this regression comes from my #56490 so I'd like to work on it 👀

[blazejkustra]

It is very connected to the other issue for iOS.

Help pane isn't technically a screen so you can't dismiss it with a back button and swipe gesture. I need to check what we can do with this, will update tomorrow.

[blazejkustra]

Update: I opened a draft PR for this 🚀

[blazejkustra]

PR is ready for C+ review, could you assign @brunovjk to this issue? 😄

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.13-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix: Unable to swipe right to close the help page, fix device back button on android #58280

If no regressions arise, payment will be issued on 2025-03-24. 🎊

For reference, here are some details about the assignees on this issue:

• @blazejkustra does not require payment (Contractor)

[melvin-bot]

@madmax330 @lschurr @blazejkustra The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[melvin-bot]

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

[brunovjk]

This issue is part of some regressions during the implementation of Help Panel. I think we can follow the payment on the original issues.

[lschurr]

Great, so we're good to close this one @brunovjk @blazejkustra @madmax330?

[brunovjk]

I think so, but I'm not sure if we need to fill out the BZ checklist here. I'll confirm on Slack and get back to you.

[brunovjk]

I can't reproduce this anymore after implementing this PR. Tested on 27 Mar v9.1.20-2 Develop. We can close, payment and BZ checklist will be handled here. Thanks!