[Due for payment 2025-03-28] iOS - Help button - Spacing between help button and search button is bigger in Inbox

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.1.9-1
Reproducible in staging?: Y
Reproducible in production?: No, unable to check in Prod, new feature
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause - Internal Team

Action Performed:

Precondition:

• Help panel feature is enabled by switching language to Spanish and back to English

1. Launch ND or hybrid app
2. Go to Settings
3. Go to Workspaces
4. Switch between Inbox and Settings to see the difference in spacing between help button and search button

Expected Result:

The spacing between help button and search button should be the same in Inbox and Workspaces

Actual Result:

The spacing between help button and search button is not same in Inbox and Workspaces. The spacing is bigger in Inbox

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6761949_1741185678554.ScreenRecording_03-05-2025_22-36-47_1.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @kadiealexander

[melvin-bot]

Triggered auto assignment to @arosiclair (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[arosiclair]

@Expensify/design which spacing is correct between the help button and search button here? The workspaces page looks better to me.

[dannymcclain]

I also think the workspaces spacing looks more correct. Going to ping @dubielzyk-expensify directly as well since he worked on this! (But I'm pretty positive the workspaces example is correct.)

[github-actions]

⚠️ Thanks for your proposal. Please update it to follow the proposal template, as proposals are only reviewed if they follow that format (note the mandatory sections).

[ChavdaSachin]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Help button - Spacing between help button and search button is bigger in Inbox

What is the root cause of that problem?

Minor miss in implementation.
Both HelpButton and SearchButton are designed in a way - both includes necessary margin and padding and hence any extra gap implemented by parent element would cause styling inconsistency.

Such extra gap - styles.gap4 is included here.

App/src/components/Navigation/TopBar.tsx

Line 47 in b824845

style={[styles.flexRow, styles.gap4, styles.mh5, styles.mv5, styles.alignItemsCenter, styles.justifyContentBetween]}

What changes do you think we should make in order to solve the problem?

Simply remove styles.gap4 here.

App/src/components/Navigation/TopBar.tsx

Line 47 in b824845

style={[styles.flexRow, styles.gap4, styles.mh5, styles.mv5, styles.alignItemsCenter, styles.justifyContentBetween]}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

NA

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[ChavdaSachin]

Offending PR #56490

[shawnborton]

Makes sense to me to use the Workspace example, but how are users even seeing this in the product right now? cc @blazejkustra

[jliexpensify]

Going to swap with Kadie, since she has a physical iPhone and can test if needed

[dubielzyk-expensify]

Yeah 100% what Danny and Shawn is saying. The workspaces is the one to go with 👍

But also a bit confused as to why this is showing up in the product like Shawn mentions 🤔

[kadiealexander]

It's only showing in staging from what the OP says (v 9.1.9-1) - is it expected that it's available soon?

[shawnborton]

Let's see what @blazejkustra says. I didn't realize that we even had any help content to be showing in that side pane feature - I thought we were just starting to build out the plumbing for it but it wouldn't be exposed to any users.

[kadiealexander]

@blazejkustra bump on this!

[blazejkustra]

I didn't realize that we even had any help content to be showing in that side pane feature - I thought we were just starting to build out the plumbing for it but it wouldn't be exposed to any users.

Right now, the Help button only shows up by default on staging . In production, users have to manually set a flag in the console to see it 😊

[289Adam289]

Hi I am Adam from SWM and I am helping @blazejkustra with help pane issues. I'd like to work on this.

[289Adam289]

Update:

I've created a pr draft with a fix

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[brunovjk]

I can't reproduce this anymore after implementing this PR. Tested on 27 Mar v9.1.20-2 Develop. We can close, payment and BZ checklist will be handled here. Thanks!

[melvin-bot]

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.