[Due for payment 2025-03-17] [Due for payment 2025-03-13] LHN - FAB does not close when clicking FAB button again when FAB is opened

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.1.9-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to the report page (search page)
3. Click FAB
4. Click FAB again (now X button)

Expected Result:

FAB closes (production behavior)

Actual Result:

Nothing happens after clicking FAB button when FAB is already opened

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6761270_1741128000831.Screen_Recording_2025-03-05_at_05.56.59.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @sonialiap

[melvin-bot]

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @tgolen (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[tgolen]

I am not able to reproduce this locally or on staging.

2025-03-05_09-01-01.mp4

[tgolen]

OK, I was finally able to reproduce it locally and on staging by going to the search page. Once I visit that page, the FAB stops closing from any page. I'm pinning down what broke it now.

[tgolen]

After running through git bisect, the PR which caused this is #56602. @Amoralchik Can you please look into this? If there is a quick fix, let's get a PR and CP it ASAP. Otherwise, let's revert the PR for now.

cc @roryabraham

[Amoralchik]

@tgolen Oh, I see, I updated logic for FAB, to local state, so after changing page, it now works correctly
#57874

[tgolen]

I've opened #57890 to revert the original PR for now so the deploy can be unblocked.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.9-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Revert "Merge pull request #56602 from Amoralchik/clickable-emoji-for… #57890

If no regressions arise, payment will be issued on 2025-03-13. 🎊

[tgolen]

I think can be closed now. It's not subject to the regression period since the result was reverting the original PR.

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.10-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Revert "Merge pull request #56602 from Amoralchik/clickable-emoji-for… #57890

If no regressions arise, payment will be issued on 2025-03-17. 🎊

[rushatgabhane]

@sonialiap requesting payment summary for review of the linked PR, thank you!
#57890 (comment)

[garrettmknight]

@sonialiap can you help me out with a payment summary, please?

[sonialiap]

Payment summary:

• @rushatgabhane $125 for reviewing the PR without tests. If you agree, please request in ND. If you disagree, let me know :)

EDIT: updating to $250 since Rushat confirmed that he did test the PR

cc @garrettmknight

[rushatgabhane]

i think it should be standard amount because i did test the PR with tests for FAB

[sonialiap]

Thanks Rushat. Updating the summary to $250

[sonialiap]

Updated payment summary:

• @rushatgabhane $250 for reviewing the PR. Please request in ND

cc @garrettmknight

[garrettmknight]

$250 approved for @rushatgabhane