[Due for payment 2025-04-23] [Due for payment 2025-03-31] [$250] Room - Empty background shown when user is invited to private room after navigating to link.

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.1.8-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Motorola MotoG60 - Android 12 - Chrome
App Component: Chat Report View

Action Performed:

Prerequisite: Have two different accounts opened in two different devices or environments.

1. Open the staging.new.expensify.com website.
2. Log in with User A account.
3. Switch to User B account.
4. Open any private room conversation in which User A is not a member, or create one if necessary.
5. Tap on room header and select "Share"
6. Copy the room URL and send it to a conversation with User A.
7. Switch to User A account.
8. Open conversation with User B and navigate to room link.
9. Check that you are navigated to a "It´s not here" page.
10. Without closing that page, switch to User B account again.
11. Invite User A to the room.
12. Switch to User B account again.
13. Check the background of the chat behaviour, when you are navigated to the new room.

Expected Result:

When the user is navigated to the private room after the "It´s not here" page disappears, the conversation background and description, should be visible

Actual Result:

When the user lands on the private room when being invited after navigating to share link, the conversation background is displayed empty and room description is not seen.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6760948_1741102817758.Share_Link.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021897444059265921571
• Upwork Job ID: 1897444059265921571
• Last Price Increase: 2025-03-06
• Automatic offers:
• daledah | Contributor | 106523836

Issue Owner

Current Issue Owner: @adelekennedy

[melvin-bot]

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[daledah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When the user lands on the private room when being invited after navigating to share link, the conversation background is displayed empty and room description is not seen.

What is the root cause of that problem?

In the report screen, fetchReport is only triggered if one of these dependencies changes:

App/src/pages/home/ReportScreen.tsx

Line 503 in ad7462d

}, [route, isLinkedMessagePageReady, reportActionIDFromRoute]);

When a user opens a room they are not a member of, and the admin then invites them, only the INVITETOROOM action is available. This results in "the conversation background being displayed empty and the room description not being visible."

What changes do you think we should make in order to solve the problem?

We should trigger the fetchReport again after user is invited to the room by adding this useEffect:

    const prevReportActions = usePrevious(reportActions);
    useEffect(() => {
        if (prevReportActions.length === 0 && reportActions.length > 0) {
            fetchReport();
        }
    }, [prevReportActions, reportActions, fetchReport]);

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

What alternative solutions did you explore? (Optional)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021897444059265921571

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hungvu193 (External)

[hungvu193]

@daledah 's proposal here looks good to me.
🎀 👀 🎀

[melvin-bot]

Triggered auto assignment to @techievivek, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

@hungvu193 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[hungvu193]

All yours @techievivek

[daledah]

@techievivek Could you help review this issue when you have a moment?

[hungvu193]

Not overdue. Waiting for assignment

[melvin-bot]

📣 @daledah 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[techievivek]

Sorry for the delay, just assigned it to you @daledah

[hungvu193]

Hi @hungvu193, any update on this?

Sorry for the late reply. I think you're correct, because this happens during regression period. @daledah can you please raise a PR to fix it?

[melvin-bot]

@adelekennedy Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[adelekennedy]

@daledah bump on the fix PR! Once that is raised I think we can move forward with the reduce payment

[daledah]

I'll raise PR today

[adelekennedy]

@daledah updates here?

[daledah]

Sorry for the delay. I'm working on this issue. Will raise a PR in a few hours. The suggested change here doesn't work for me so I'm looking for a new solution

[daledah]

@hungvu193 @martasudol After a while I realized that the extra OpenReport call wasn't from my solution at all:

Screen.Recording.2025-04-10.at.11.49.28.mp4

Looking at the logs we can see that logics here are called twice.

So I think we should handle this bug in a different issue.

[martasudol]

@daledah where in the code you log fetch 1? According to the video you log fetch report here.

[daledah]

@martasudol Ah yes I forgot to reload the web before recording. Here's the corrected version:

Screen.Recording.2025-04-10.at.12.54.33.mp4

[martasudol]

Got it, thanks!
Anyway, the problem still occurs with this solution. We're talking about different screens. Take a look on search screen:

Nagranie.z.ekranu.2025-04-10.o.08.29.00.mov

I've added logs in both effects and both of them are triggered once opening a report.

[daledah]

@martasudol Thanks for the help! I've raised a fix PR here.
cc @hungvu193

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.28-15-staging and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: prevent unnecessary OpenReport call #60005

If no regressions arise, payment will be issued on 2025-04-23. 🎊

For reference, here are some details about the assignees on this issue:

• @hungvu193 requires payment through NewDot Manual Requests
• @daledah requires payment automatic offer (Contributor)

[melvin-bot]

@hungvu193 @adelekennedy @hungvu193 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[adelekennedy]

Payment Summary
$125 @hungvu193 (NewDot)
$125 @daledah (Upwork)

[garrettmknight]

$125 approved for @hungvu193