[Due for payment 2025-03-24] [$250] Account - Account data not loads when Signed In with Google

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: v9.1.8-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5682250&group_by=cases:section_id&group_id=229043&group_order=asc
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Desktop (Mac/Intel)
App Component: Other

Action Performed:

Precondition: user should be signed out in Web and Desktop

1. Open app
2. Click on Sign In with google button
3. Select google account
4. Click on Open In desktop button on pop-up
5. Wait for a while
6. Kill the app
7. Reopen the app

Expected Result:

User should be navigated back to Desktop app and account data should be loaded

Actual Result:

User navigated to Desktop app, but account data does not loads

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6760456_1741048926435.Screen_Recording_2025-03-04_at_02.35.59.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021898003296165668899
• Upwork Job ID: 1898003296165668899
• Last Price Increase: 2025-03-24

Issue Owner

Current Issue Owner: @dylanexpensify

[melvin-bot]

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021898003296165668899

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hungvu193 (External)

[hungvu193]

I can reproduce this one. Looking for proposals!

[rezkiy37]

Hi, I am Michael (Mykhailo) from Callstack, an expert agency and I can work on this issue.

[rezkiy37]

There was a similar bug I worked on before - #41246.

[rezkiy37]

I've tested and can confirm that the bug is replicable. Additionally, the root cause is the same as in #41246. Apple login also does not work properly.

1. The user signs in with Google or Apple.
2. The app requests SignInWithShortLivedAuthToken.
3. It responds with lastUpdateID: 4459016660.
4. The app requests OpenApp.
5. It responds with lastUpdateID: 4459016660.
6. Both responses contain the same ID.

There is a condition in how the app checks whether it should apply new coming onyx data. It compares the current lastUpdateID with the last one.

App/src/libs/actions/OnyxUpdates.ts

Line 116 in 3013e7b

if (lastUpdateID && lastUpdateIDAppliedToClient && Number(lastUpdateID) <= lastUpdateIDAppliedToClient) {

As we can see, the app omits onyxData if the IDs are the same. The app does not take Onyx data into account.

Details

Screen.Recording.2025-03-10.at.16.58.07.mp4

Definitely, we need an internal engineer here.

[hungvu193]

@rezkiy37 There's another issue with login google on Desktop, not sure if you're able to reproduce it or just me

Screen.Recording.2025-03-11.at.00.43.04.mov

App/src/libs/Navigation/helpers/linkTo/index.ts

Line 65 in ccc4d65

return currentParams.reportID === newParams.reportID;

[rezkiy37]

I just reproduced the bug with the reportID on dev.

Videos

Test.DEV.mp4

Test.3.mp4

[rezkiy37]

Regarding this last bug, I can confirm it is a valid issue. It happens when the web redirects to the desktop by a URL (e.g., https://dev.new.expensify.com:8082/transition?exitTo=%2Fr&email=mykhailo.kravchenko%40callstack.com&shortLivedAuthToken=1D...). There is a parameter - exitTo. It is a highly important value for this flow. However, the app expects a reportID but not just /r.

App/src/libs/Navigation/helpers/linkTo/index.ts

Line 65 in ccc4d65

return currentParams.reportID === newParams.reportID;

After investigations, I would say it is a front-end issue. I intend to utilize the optional chaining operator in the condition. It is not critical for the user to open the app by a deep-link for SSO authorization without a reportID.

cc @hungvu193

[hungvu193]

Cool. I think we should fix it here as well

[dylanexpensify]

Nice, thank you!

[rezkiy37]

I've opened #58278 for review.
cc @hungvu193

[melvin-bot]

Triggered auto assignment to @youssef-lr, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[hungvu193]

@youssef-lr FYI, there are 2 issues here:

1. Crash on Dev (error console on Staging) when logging in with Google Desktop - We addressed it here
2. lastUpdateID returns the same for 2 API requests and Onyx data was omitted by the condition here:
   

   App/src/libs/actions/OnyxUpdates.ts

   Line 116 in 9234333

   if (lastUpdateID && lastUpdateIDAppliedToClient && Number(lastUpdateID) <= lastUpdateIDAppliedToClient) {

   
   @rezkiy37 already had a well-explained here

For the second issue, I believe we should fix it from our BE.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.13-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix reportID condition when SSO redirect #58278

If no regressions arise, payment will be issued on 2025-03-24. 🎊

For reference, here are some details about the assignees on this issue:

• @hungvu193 requires payment through NewDot Manual Requests

[melvin-bot]

@hungvu193 @dylanexpensify @hungvu193 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[rezkiy37]

We need an internal engineer here - #57744 (comment).

[melvin-bot]

Payment Summary

Upwork Job

• Reviewer: @hungvu193 owed $250 via NewDot

BugZero Checklist (@dylanexpensify)

• I have verified the correct assignees and roles are listed above and updated the necessary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1898003296165668899/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[hungvu193]

I think the BE issue is now resolved, we can login with google without any issues.

Screen.Recording.2025-03-25.at.15.40.57.mov

[dylanexpensify]

Payment summary:

Contributor+: @hungvu193 $250 via NewDot

Please apply/request!

[garrettmknight]

$250 approved for @hungvu193