[Due for payment 2025-05-22] [$250] Reports - Held expense disappears after approving pending expense from Reports

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.1.7-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Mac 15.3 / Chrome
App Component: Search

Action Performed:

1. Go to staging.new.expensify.com
2. Create a new workspace.
3. Go to workspace chat.
4. Submit two manual expenses to the workspace chat.
5. Click Submit button.
6. Click on the expense preview.
7. Hold one of the expenses.
8. Go to Reports > Expense reports.
9. Click Review.
10. Click Approve.
11. Approve the pending amount (green button).
12. Close the RHP.
13. Refresh the page.

Expected Result:

In Step 12, the held expense should appear as a separate report after approving the pending amount.

Actual Result:

In Step 12, the held expense disappears after approving the pending amount.
In Step 13, the held expense only appears after refreshing the page.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6757350_1740733666225.20250228_170200.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021895498808351616709
• Upwork Job ID: 1895498808351616709
• Last Price Increase: 2025-02-28

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @Christinadobrzyn

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[Christinadobrzyn]

Oh this is a good one, not sure if this should be internal - so we'll start with external.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021895498808351616709

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

[LorenzoBloedow]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Held expense disappears after we approve the pending expense from the same workspace.

What is the root cause of that problem?

This hook which updates the list by searching after it detects a new report is assuming that report action IDs can only change in the chat category.

App/src/hooks/useSearchHighlightAndScroll.ts

Line 56 in 0be2a40

if ((!isChat && hasTransactionsIDsChange) || (isChat && hasReportActionsIDsChange)) {

What changes do you think we should make in order to solve the problem?

Remove isChat from the second condition in the if statement:

if ((!isChat && hasTransactionsIDsChange) || hasReportActionsIDsChange) {

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

Unit test that calls IOU.approveMoneyRequest (the function that gets called when you approve the expense not on hold) with the same conditions of this bug and then checks to see if SearchActions.search has been called.

Alternatively, in order not to touch implementation details, we could create an E2E test that approves the expense and then checks to see if the held expense is present in the page.

What alternative solutions did you explore? (Optional)

N/A

[Christinadobrzyn]

@thesahindia can you check out the ^ proposal when you have a moment? TY!

[M00rish]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Reports - Held expense disappears after approving pending expense from Reports

What is the root cause of that problem?

when report is approved with a held transactions, the held transaction is moved to a different report, so it disappears as the new report is not included in the current search data:

App/src/components/Search/index.tsx

Lines 264 to 269 in aea476b

	const data = useMemo(() => {
	if (searchResults === undefined) {
	return [];
	}
	return getSections(type, status, searchResults.data, searchResults.search, shouldGroupByReports);
	}, [searchResults, status, type, shouldGroupByReports]);

What changes do you think we should make in order to solve the problem?

add usEffect to check if a transaction has reportID changed, if so trigger new search to include the new report :

 useEffect(() => {
        if (!transactions || !previousTransactions) {
            return;
        }
    
        const hasReportChanged = Object.entries(transactions).some(([transactionID, transaction]) => {
            const previousTransaction = previousTransactions[transactionID];
            return previousTransaction && previousTransaction.reportID !== transaction?.reportID;
        });
    
        if (hasReportChanged) {
            search({queryJSON, offset: 0});
        }
    }, [transactions, previousTransactions, queryJSON]);

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

UI issue

What alternative solutions did you explore? (Optional)

N/A

[melvin-bot]

@thesahindia Whoops! This issue is 2 days overdue. Let's get this updated quick!

[Christinadobrzyn]

reassigning based on this Slack convo https://expensify.slack.com/archives/C02NK2DQWUX/p1741113791513709

[Christinadobrzyn]

@parasharrajat can you check out the above proposals when you have a moment? TY!

[parasharrajat]

Yes, reviewing it...

[parasharrajat]

@LorenzoBloedow's proposal makes sense. We have a case where reportaction changes when dealing with transactions. We should add a comment to explain that as well.

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @blimpich, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[parasharrajat]

Sorry, tagged the wrong contributor earlier. Updated the comment.

[LorenzoBloedow]

@parasharrajat Not sure if I'm supposed to, but I can't access the discussion, getting an error.

[parasharrajat]

Unfortunately, it is internal.

[melvin-bot]

Current assignee @parasharrajat is eligible for the External assigner, not assigning anyone new.

[Christinadobrzyn]

monitoring #57887

[Christinadobrzyn]

I think this should be weekly as we're reviewing #57887

Moving it back to weekly but let me know if that's not good.

[Christinadobrzyn]

monitoring #57887

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[parasharrajat]

No regression. That issue might be a follow-up here to the original PR.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.45-21 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fixed held expense disappearing after approving pending expense from Reports #57887

If no regressions arise, payment will be issued on 2025-05-22. 🎊

For reference, here are some details about the assignees on this issue:

• @parasharrajat requires payment through NewDot Manual Requests
• @LorenzoBloedow requires payment (Needs manual offer from BZ)

[melvin-bot]

@parasharrajat @Christinadobrzyn @parasharrajat The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]