[Due for payment 2025-03-24] [Due for payment 2025-03-11] [$250] Split Expense-Merchant field is shown instead of Distance and Rate fields for split distance

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: v9.1.6-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5489528
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Windows 10/ Chrome, Samsung S23FE/ Android 14
App Component: Money Requests

Action Performed:

Precondition:
Run with accounts on the @applause.expensifail.com domain in a group chat.

Steps:

1. Navigate to https://staging.new.expensify.com/
2. Go to any chat group
3. Create a split distance expense
4. Click on the expense preview

Expected Result:

The Distance and Rate fields are displayed for split distance expense.

Actual Result:

The Merchant field is displayed instead of the Distance and Rate fields for split distance expense.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6719996_1737473504473.Split_distance_expense.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021895166068007101327
• Upwork Job ID: 1895166068007101327
• Last Price Increase: 2025-02-27
• Automatic offers:
• gijoe0295 | Contributor | 106318614

Issue Owner

Current Issue Owner: @CortneyOfstad

[melvin-bot]

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[gijoe0295]

🚨 Edited by proposal-police: This proposal was edited at 2025-02-26 12:08:46 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Merchant field is shown instead of Distance and Rate fields for split distance

What is the root cause of that problem?

We did not evaluate the isDistanceRequest param.

App/src/pages/iou/SplitBillDetailsPage.tsx

Line 111 in ff4468d

<MoneyRequestConfirmationList

causing the merchant to show and distance to hide:

App/src/components/MoneyRequestConfirmationList.tsx

Line 264 in 438639b

const shouldShowMerchant = shouldShowSmartScanFields && !isDistanceRequest && !isTypeSend && !isPerDiemRequest;

What changes do you think we should make in order to solve the problem?

Evaluate the isDistanceRequest param and pass to MoneyRequestConfirmationList in SplitBillDetailsPage.

isDistanceRequest={isDistanceRequest(transaction)}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

None

[CortneyOfstad]

Was able to recreate this within my mobile app on iPhone as well, so getting eyes on this.

Single, non-split transactions had Distance listed instead of Merchant, while the split mileage transaction had Merchant listed.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021895166068007101327

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @c3024 (External)

[CortneyOfstad]

@c3024 Looks we have a proposal above ^^^ Thanks!

[c3024]

@gijoe0295 's RCA and fix suggested in their proposal looks to good to me.

🎀 👀 🎀 C+ reviewed!

[melvin-bot]

Triggered auto assignment to @cristipaval, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

📣 @gijoe0295 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[CortneyOfstad]

@cristipaval any update on the deploy blocker?^^^

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.8-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: distance-related fields are missing in split details page #57621

If no regressions arise, payment will be issued on 2025-03-11. 🎊

For reference, here are some details about the assignees on this issue:

• @c3024 requires payment through NewDot Manual Requests
• @gijoe0295 requires payment automatic offer (Contributor)

[melvin-bot]

@c3024 @CortneyOfstad @c3024 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[cristipaval]

@cristipaval any update on the deploy blocker?^^^

The fix for this issue uncovered the other issue revealed at the QA phase. The root cause existed before, so we shouldn't apply any penalties here.

[CortneyOfstad]

Thanks @cristipaval!

@c3024 — please complete the checklist as soon as you can to avoid any delay in payment tomorrow. Thanks!

[c3024]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other:

Where bug was reported:

• 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
• 2b. Reported on staging (eg. found during regression or PR testing)
• 2d. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment: Add Scan to Split Bill and implement IOU action startSplitBill #28710 https://github.com/Expensify/App/pull/28710/files#r1987746363

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion: Not critical enough to start a discussion

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

Regression Test Proposal Template

• [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

  Link to issue:

Regression Test Proposal

Precondition:

• User has a group chat.

Test:

1. Go to any group chat.
2. Create a split distance expense.
3. Press the expense preview to open the expense details.
4. Verify that the Distance & Rate fields are displayed in the expense details.

Do we agree 👍 or 👎

[CortneyOfstad]

Payment Summary

@c3024 – to be paid $250 via NewDot
@gijoe0295 — paid $250 via Upwork

Regression Test

https://github.com/Expensify/Expensify/issues/479506

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.13-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: distance-related fields are missing in split details page #57621

If no regressions arise, payment will be issued on 2025-03-24. 🎊

For reference, here are some details about the assignees on this issue:

• @c3024 requires payment through NewDot Manual Requests
• @gijoe0295 requires payment automatic offer (Contributor)

[melvin-bot]

@c3024 @CortneyOfstad @c3024 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[JmillsExpensify]

$250 approved for @c3024