-
Notifications
You must be signed in to change notification settings - Fork 3.2k
[Due for payment 2025-03-31] [$250] mWeb - Chat - Chat is not autoscrolled when receiving a payment with chat opened #57287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Triggered auto assignment to @Christinadobrzyn ( |
ProposalPlease re-state the problem that we are trying to solve in this issue.Chat is not autoscrolled when a payment is received and the preview can´t be seen without scrolling down manually. What is the root cause of that problem?As usual, we don't scroll to bottom if there's new message from someone What changes do you think we should make in order to solve the problem?We can adjust the condition here to check if it's the payment action, so we should scroll to bottom What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?None What alternative solutions did you explore? (Optional)Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job. |
Job added to Upwork: https://www.upwork.com/jobs/~021894557893116251208 |
I think this can be external. |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @rayane-d ( |
@rayane-d 👀 on the above proposal plz |
@daledah The RCA isn’t clear to me. It seems that we’re scrolling correctly when receiving the action, but the report preview initially lacks a receipt placeholder image. Once the report is fully loaded and the receipt placeholder image is displayed in the report preview, the scroll position remains unchanged. ![]() ![]() |
I'm able to reproduce 👍 Screen.Recording.2025-02-26.at.10.38.16.PM.mov |
I’ve seen a similar bug before that was fixed in PR #55712, which may be related. |
Waiting on proposals |
@TMisiukiewicz would you have the bandwidth to work on this since you also worked on this PR? |
@Christinadobrzyn sure, I'll take a look on this today |
I think the reason it happens is the same as the root cause from #55712. The code responsible for getting |
Opened a PR #57609 |
Triggered auto assignment to @CortneyOfstad ( |
I'm going to be ooo when this needs to be paid so adding a teammate to complete the payment section. @CortneyOfstad thanks for your help! here's the payment summary. @rayane-d do we need a regression test for this? |
Yes Regression Test Proposal
Do we agree 👍 or 👎 |
Current assignee @CortneyOfstad is eligible for the Bug assigner, not assigning anyone new. |
Triggered auto assignment to @lydiabarclay ( |
Hey @lydiabarclay! I got assigned this while @Christinadobrzyn was going OoO, but I am also going OoO 😂 I've created the regression test here — https://github.com/Expensify/Expensify/issues/485597 so the only action needed on Monday is confirming no regressions and posting the payment summary with the regression test link. Thanks! |
Payment Summary
BugZero Checklist (@CortneyOfstad)
|
Payment Summary@TMisiukiewicz does not require payment (Contractor) ... Regression test filed - https://github.com/Expensify/Expensify/issues/485597 |
$250 approved for @rayane-d |
Uh oh!
There was an error while loading. Please reload this page.
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: 9.1.4-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Motorola MotoG60 - Android 12 - Chrome
App Component: Chat Report View
Action Performed:
Expected Result:
Chat should be automatically autoscrolled when the payment is received.
Actual Result:
Chat is not autoscrolled when a payment is received and the preview can´t be seen without scrolling down manually.
Workaround:
Unknown
Platforms:
Screenshots/Videos
Bug6750690_1740208770825.Autoscrolled.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: