Skip to content

[Due for payment 2025-03-31] [$250] mWeb - Chat - Chat is not autoscrolled when receiving a payment with chat opened #57287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 of 8 tasks
IuliiaHerets opened this issue Feb 22, 2025 · 30 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor

Comments

@IuliiaHerets
Copy link

IuliiaHerets commented Feb 22, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.1.4-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Motorola MotoG60 - Android 12 - Chrome
App Component: Chat Report View

Action Performed:

  1. Open the staging.new.expensify.com website.
  2. Open conversation with user B.
  3. If there are no messages or content, send some messages to make the chat scrollable.
  4. Without navigating out of the conversation, switch to user B account.
  5. User B, open chat with User A.
  6. Tap on "+" button and select "Pay Someone"
  7. Complete the payment flow and submit it to chat.
  8. Switch to user A account again.
  9. Check the chat behaviour when the payment is received.

Expected Result:

Chat should be automatically autoscrolled when the payment is received.

Actual Result:

Chat is not autoscrolled when a payment is received and the preview can´t be seen without scrolling down manually.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6750690_1740208770825.Autoscrolled.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021894557893116251208
  • Upwork Job ID: 1894557893116251208
  • Last Price Increase: 2025-02-26
@IuliiaHerets IuliiaHerets added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 labels Feb 22, 2025
Copy link

melvin-bot bot commented Feb 22, 2025

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@daledah
Copy link
Contributor

daledah commented Feb 24, 2025

Proposal

Please re-state the problem that we are trying to solve in this issue.

Chat is not autoscrolled when a payment is received and the preview can´t be seen without scrolling down manually.

What is the root cause of that problem?

As usual, we don't scroll to bottom if there's new message from someone

What changes do you think we should make in order to solve the problem?

We can adjust the condition here to check if it's the payment action, so we should scroll to bottom

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

@melvin-bot melvin-bot bot added the Overdue label Feb 25, 2025
@Christinadobrzyn Christinadobrzyn added the External Added to denote the issue can be worked on by a contributor label Feb 26, 2025
@melvin-bot melvin-bot bot changed the title mWeb - Chat - Chat is not autoscrolled when receiving a payment with chat opened [$250] mWeb - Chat - Chat is not autoscrolled when receiving a payment with chat opened Feb 26, 2025
Copy link

melvin-bot bot commented Feb 26, 2025

Job added to Upwork: https://www.upwork.com/jobs/~021894557893116251208

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 26, 2025
@Christinadobrzyn
Copy link
Contributor

I think this can be external.

Copy link

melvin-bot bot commented Feb 26, 2025

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rayane-d (External)

@mallenexpensify
Copy link
Contributor

@rayane-d 👀 on the above proposal plz

@rayane-d
Copy link
Contributor

As usual, we don't scroll to bottom if there's new message from someone

@daledah The RCA isn’t clear to me. It seems that we’re scrolling correctly when receiving the action, but the report preview initially lacks a receipt placeholder image. Once the report is fully loaded and the receipt placeholder image is displayed in the report preview, the scroll position remains unchanged.

Image Image

@rayane-d
Copy link
Contributor

rayane-d commented Feb 26, 2025

I'm able to reproduce 👍

Screen.Recording.2025-02-26.at.10.38.16.PM.mov

@rayane-d
Copy link
Contributor

I’ve seen a similar bug before that was fixed in PR #55712, which may be related.

@rayane-d
Copy link
Contributor

Waiting on proposals

@Christinadobrzyn
Copy link
Contributor

@TMisiukiewicz would you have the bandwidth to work on this since you also worked on this PR?

@TMisiukiewicz
Copy link
Contributor

@Christinadobrzyn sure, I'll take a look on this today

@TMisiukiewicz
Copy link
Contributor

I think the reason it happens is the same as the root cause from #55712. The code responsible for getting transactions from Onyx was moved from ReportPreview component to a separate hook, where empty array is set as initial value again. I'll do some more tests and open a PR.

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Feb 28, 2025
@TMisiukiewicz
Copy link
Contributor

Opened a PR #57609

Copy link

melvin-bot bot commented Mar 25, 2025

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Mar 25, 2025
@Christinadobrzyn Christinadobrzyn self-assigned this Mar 25, 2025
@Christinadobrzyn
Copy link
Contributor

I'm going to be ooo when this needs to be paid so adding a teammate to complete the payment section.

@CortneyOfstad thanks for your help! here's the payment summary.

@rayane-d do we need a regression test for this?

@melvin-bot melvin-bot bot added the Overdue label Mar 28, 2025
@rayane-d
Copy link
Contributor

@rayane-d do we need a regression test for this?

Yes

Regression Test Proposal


1. Open two separate windows with the app with two different accounts (e.g. web and mobile).
2. Open conversation with user B.
3. Send some messages so the chat is scrollable.
4. Minimize user A window and Switch to user B window.
5. User B, open chat with User A.
6. Tap on "+" button and select "Pay Someone".
7. Complete the payment flow and submit it to chat.
8. Switch to user A window again.
9. Verify the expense appeared in chat and the chat is scrolled to the bottom.

Do we agree 👍 or 👎

@melvin-bot melvin-bot bot removed the Overdue label Mar 28, 2025
@CortneyOfstad CortneyOfstad added Bug Something is broken. Auto assigns a BugZero manager. and removed Bug Something is broken. Auto assigns a BugZero manager. labels Mar 28, 2025
Copy link

melvin-bot bot commented Mar 28, 2025

Current assignee @CortneyOfstad is eligible for the Bug assigner, not assigning anyone new.

@CortneyOfstad CortneyOfstad added Bug Something is broken. Auto assigns a BugZero manager. and removed Bug Something is broken. Auto assigns a BugZero manager. labels Mar 28, 2025
Copy link

melvin-bot bot commented Mar 28, 2025

Triggered auto assignment to @lydiabarclay (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@CortneyOfstad
Copy link
Contributor

Hey @lydiabarclay! I got assigned this while @Christinadobrzyn was going OoO, but I am also going OoO 😂

I've created the regression test here — https://github.com/Expensify/Expensify/issues/485597 so the only action needed on Monday is confirming no regressions and posting the payment summary with the regression test link. Thanks!

@melvin-bot melvin-bot bot added Overdue Daily KSv2 and removed Daily KSv2 Overdue labels Mar 31, 2025
Copy link

melvin-bot bot commented Mar 31, 2025

Payment Summary

Upwork Job

  • Contributor: @TMisiukiewicz is from an agency-contributor and not due payment
  • Reviewer: @rayane-d owed $250 via NewDot

BugZero Checklist (@CortneyOfstad)

  • I have verified the correct assignees and roles are listed above and updated the necessary manual offers
  • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1894557893116251208/hired)
  • I have paid out the Upwork contracts or cancelled the ones that are incorrect
  • I have verified the payment summary above is correct

@lydiabarclay
Copy link

Payment Summary

@TMisiukiewicz does not require payment (Contractor)
@rayane-d requires $250 payment through NewDot Manual Requests

...

Regression test filed - https://github.com/Expensify/Expensify/issues/485597

@garrettmknight
Copy link
Contributor

$250 approved for @rayane-d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor
Projects
Status: Done
Development

No branches or pull requests

10 participants