[Due for payment 2025-03-24] [Due for payment 2025-03-11] [$125] Refactor createSplitsAndOnyxData to use a parameter object

[neil-marcellini]

As part of the tracking issue, and as advised in its description, refactor createSplitsAndOnyxData to use a parameter object.

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021893019419120614697
• Upwork Job ID: 1893019419120614697
• Last Price Increase: 2025-02-21
• Automatic offers:
• paultsimura | Reviewer | 106227028
• Krishna2323 | Contributor | 106227029

Issue Owner

Current Issue Owner: @kadiealexander

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021893019419120614697

[melvin-bot]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @paultsimura (External)

[Krishna2323]

Proposal

Please re-state the problem that we are trying to solve in this issue.

• Refactor createSplitsAndOnyxData to use a parameter object

What is the root cause of that problem?

• Refactor

What changes do you think we should make in order to solve the problem?

• Add parameter object for createSplitsAndOnyxData in IOU.ts

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

What alternative solutions did you explore? (Optional)

[paultsimura]

It's a trivial task, let's go with the first proposal by @Krishna2323.

@Krishna2323 please make sure you explore completed issues within the tracking GH and split the type into domain-specific sub-types if needed.

🎀👀🎀 C+ reviewed

[melvin-bot]

Current assignee @neil-marcellini is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

[melvin-bot]

📣 @paultsimura 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @Krishna2323 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

Upwork job price has been updated to $125

[Krishna2323]

@paultsimura PR is ready for review.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.8-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• refactor: createSplitsAndOnyxData to use a parameter object. #57295

If no regressions arise, payment will be issued on 2025-03-11. 🎊

For reference, here are some details about the assignees on this issue:

• @paultsimura requires payment automatic offer (Reviewer)
• @Krishna2323 requires payment automatic offer (Contributor)

[melvin-bot]

@paultsimura @kadiealexander @paultsimura The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[paultsimura]

BugZero Checklist:

This is a refactoring feature request, I don't think the standard BZ checklist is suitable here.
Also, no regression tests needed.

[kadiealexander]

Payments needed:

• - Contributor: @Krishna2323 paid $125 via Upwork (offer)
• - Reviewer: @paultsimura owed $125 via Upwork (offer)

Please accept the new offers!

[paultsimura]

Thanks @kadiealexander, accepted.

[Krishna2323]

@neil-marcellini, we raised two PRs—one for refactoring createSplitsAndOnyxData to use a parameter object and another for refactoring BaseTransactionParams. I believe we are eligible for an additional $125 for the second PR since it was not part of the original issue and required additional effort. Let me know your thoughts. Thanks!

[neil-marcellini]

No the total is only $125 because the second PR was a requested follow up to the first.

[Krishna2323]

Thanks for confirming, @kadiealexander, I have accepted the offer.

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.13-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• refactor: add BaseTransactionParams. #57635

If no regressions arise, payment will be issued on 2025-03-24. 🎊

For reference, here are some details about the assignees on this issue:

• @paultsimura requires payment automatic offer (Reviewer)
• @Krishna2323 requires payment automatic offer (Contributor)

[melvin-bot]

@neil-marcellini @kadiealexander @paultsimura / @Krishna2323 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[Krishna2323]

Hi @kadiealexander, I haven’t received payment for this issue. Could you please check on that? Thanks!

Edit: Sorry for the confusion — I was seeing the old offer because it hadn't expired yet.