[Due for payment 2025-04-25] [$250] LHN - Workspace chats and rooms disappear from the LHN after being deleted

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: v9.0.99-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
Issue reported by: Applause Internal Team
Device used: Mac 15.2/Safari, iPhone 13 18.2.1
App Component: Left Hand Navigation (LHN)

Action Performed:

1. Navigate to https://staging.new.expensify.com
2. Create a workspace
3. Delete the created workspace

Expected Result:

Workspace chats and rooms are marked as archived in the LHN after being deleted

Actual Result:

Workspace chats and rooms disappear from the LHN after being deleted

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

https://github.com/user-attachments/assets/3d6bd10a-8139-42ab-b824-365862e3da5d
https://github.com/user-attachments/assets/bdf38fc6-34b1-4dd2-b028-17e311606fe0

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021891945325969748426
• Upwork Job ID: 1891945325969748426
• Last Price Increase: 2025-02-25

Issue Owner

Current Issue Owner: @Christinadobrzyn

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021891945325969748426

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rayane-d (External)

[Christinadobrzyn]

I think this can be external - although I'm not sure if this is expected or not.

@rayane-d or maybe @parasharrajat do you know if it's expected that deleted workspaces that don't have any reports associated with them will show as archived? I can ask the team if that's better.

[parasharrajat]

I vaguely remember, it should show in LHN unless we changed it.

[Christinadobrzyn]

Thanks @parasharrajat. Okay, I'll just double-check we still want to show archived workspaces with the team. https://expensify.slack.com/archives/C06ML6X0W9L/p1739910709686619

[dylanexpensify]

Yes, we want to show it as archived!

[rayane-d]

Agree! Thank you for confirming! Waiting on proposals!

[Christinadobrzyn]

awesome! we'll keep an eye out for proposals

[Christinadobrzyn]

Asking callstack if they have the bandwidth! - https://expensify.slack.com/archives/C03UK30EA1Z/p1740158823001379

[rayane-d]

Waiting on proposals

[narefyev91]

Hi, I'm Nicolay from Callstack - expert contributor group - and I would like to work on this issue.

[narefyev91]

My updates here:
During investigation the code i get to the point where archive reports were not shown:

In my account it was focus mode:

When i switched to Most recents i was able to see all my archived reports:

@IuliiaHerets could you please clarify your priority mode in preferences.
cc @Christinadobrzyn , @rayane-d

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[Christinadobrzyn]

Awesome! Thank you for the investigation @narefyev91!

@dylanexpensify maybe you can help with this question? Or should we bring it to the wider team?

Question is:

Do we want archived workspaces to show in Focus Mode? I would assume not.
I think this might be behaving as expected with archived workspaces showing in Most Recent mode only. Do you agree?

[rayane-d]

@IuliiaHerets could you please clarify your priority mode in preferences.

Based on the videos in the OP, it appears that the priority mode is set to "Most Recent"

Bug6745990_1739815281763.Recording__640.mp4

Bug6745990_1739815281779.ScreenRecording_02-17-2025_12-56-17_1.mp4

@IuliiaHerets could you please provide the test steps starting from a new account? Are there any specific configurations or preconditions that need to be set up beforehand?

[rayane-d]

@narefyev91 - Based on this, There’s a recent project that changed the behavior to treat empty notification preferences (none set) as "hidden" on backend, so we’ll need to handle this on the frontend. Your second suggestion sounds good to me.

cc @mountiny – Could you confirm?

[mountiny]

Yeah the hidden rooms should not be visible in focus mode. They should be searchable though. In focus mode, they wont even be returned in OpenApp.

[Christinadobrzyn]

working on the PR - #59360

[melvin-bot]

Triggered auto assignment to @Valforte, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[Christinadobrzyn]

working on the PR - #59360

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.29-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Workspace chats and rooms disappear from the LHN after being deleted #59360

If no regressions arise, payment will be issued on 2025-04-25. 🎊

For reference, here are some details about the assignees on this issue:

• @narefyev91 does not require payment (Contractor)
• @rayane-d requires $250 payment through NewDot Manual Requests

[melvin-bot]

@rayane-d @Christinadobrzyn @rayane-d The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[rayane-d]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other:

Where bug was reported:

• 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
• 2b. Reported on staging (eg. found during regression or PR testing)
• 2d. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment: N/A

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion: N/A

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

• [@Christinadobrzyn] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

  Link to issue: [Due for payment 2025-04-25] [$250] LHN - Workspace chats and rooms disappear from the LHN after being deleted #56967 (comment)

Regression Test Proposal

Precondition:

• N/A

Test:

1. Navigate to NewDot
2. Create a workspace
3. Delete the created workspace
4. Verify that in LHN, when in "Recent Mode" all chats related to the deleted workspace are shown as archived

Do we agree 👍 or 👎

[melvin-bot]

@Christinadobrzyn Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[rayane-d]

@Christinadobrzyn Friendly bump

[Christinadobrzyn]

Sorry for the delay @rayane-d!

Regression test here - #56967 (comment)
Payment summary here - #56967 (comment)

Please feel free to submit your payment through ND @rayane-d

Closing

[Christinadobrzyn]

@rayane-d just checking on the regression test steps -

#56967 (comment)

• Navigate to NewDot
• Create a workspace
• Delete the created workspace
• Verify that in LHN, when in "Recent Mode" all chats related to the deleted workspace are shown as archived

As per this #58881 (comment) the workspace chats should be hidden, are these steps correct?

[garrettmknight]

$250 approved for @rayane-d