[Due for payment 2025-02-19] [Due for payment 2025-02-18] Android - Group - Device back button on members list, redirects to chat instead of details.

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.95-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: No, reproducible on hybrid only
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Motorola MotoG60 - Android 12
App Component: Other

Action Performed:

1. Open the Expensify app.
2. Open any group chat or create one.
3. Tap on chat header.
4. Tap on "Members"
5. Tap on the arrow on the top left corner.
6. Check if you are redirected to details tab.
7. Open "Members" again.
8. Use device´s back button.
9. Check if behaviour is the same that when using the app´s back button.

Expected Result:

Using device´s back button on "Members" tab on a group chat, should redirect to "Details" again.

Actual Result:

Using device´s back button on "Memers" tab on a group chat, redirects to chat instead of "Details"

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6735867_1738901318098.Members.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @muttmuure

[melvin-bot]

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @techievivek (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[techievivek]

I feel like this is similar to issue here #56504 and here #56500

[techievivek]

Could it be related to the changes we made here #46937?

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Using device´s back button on "Memers" tab on a group chat, redirects to chat instead of "Details"

What is the root cause of that problem?

We do the onNavigationCallBack here but we still return false in onBackPress function which causes two navigate actions to be done. One from onNavigationCallBack that goes back to the report detail page, one from the device back button then we back to the report screen

App/src/hooks/useSearchBackPress/index.android.ts

Lines 19 to 20 in c912900

	onNavigationCallBack();
	return false;

What changes do you think we should make in order to solve the problem?

We can remove onNavigationCallBack and still return false so we will do the device back button behavior in this case.

App/src/hooks/useSearchBackPress/index.android.ts

Lines 19 to 20 in c912900

	onNavigationCallBack();
	return false;

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

We can return true here

App/src/hooks/useSearchBackPress/index.android.ts

Lines 19 to 20 in c912900

	onNavigationCallBack();
	return false;

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[layacat]

I think I worked on the offending PR. Lemme check

[hungvu193]

Checking 👀

[hungvu193]

Yes we should return true here instead:

App/src/hooks/useSearchBackPress/index.android.ts

Lines 19 to 20 in 631006e

	onNavigationCallBack();
	return false;

[hungvu193]

Can you raise an PR to fix this please? @layacat

[layacat]

I will raise the PR in a few hours

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[Julesssss]

I forgot to remove the label, but this is fixed

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.96-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix double back press on Android #56608

If no regressions arise, payment will be issued on 2025-02-19. 🎊

For reference, here are some details about the assignees on this issue:

• @hungvu193 requires payment through NewDot Manual Requests
• @layacat requires payment (Needs manual offer from BZ)

[melvin-bot]

@hungvu193 @muttmuure @hungvu193 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[melvin-bot]

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Payment Summary

Upwork Job

• Reviewer: @hungvu193 owed $250 via NewDot
• ROLE: @layacat paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@zanyrenney)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[Julesssss]

Ready for payment , not overdue

[hungvu193]

We can close it. No payment required here

[melvin-bot]

@Julesssss, @hungvu193, @zanyrenney, @layacat Eep! 4 days overdue now. Issues have feelings too...

[zanyrenney]

Cool, thanks @hungvu193 !

[zanyrenney]

Closing this out as per the comment here