Skip to content

[$250] When creating Task through composer, thumbnail displays as grey w/ no icon #55857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 of 8 tasks
IuliiaHerets opened this issue Jan 28, 2025 · 34 comments
Closed
2 of 8 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Improvement Item broken or needs improvement. Monthly KSv2 Reviewing Has a PR in review

Comments

@IuliiaHerets
Copy link

IuliiaHerets commented Jan 28, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: v9.0.90-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail: #55702
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Macbook Pro 2023 / Sequioa 15.2
App Component: Chat Report View

Action Performed:

  1. Access staging.new.expensify.com
  2. Sign into a valid account
  3. Go to any chat and paste the following text "[] @[email protected] title"

Expected Result:

A task is created and the thumbnail shows an Expensify icon

Actual Result:

The task is created, however the thumbnail is greyed out. User must access the task and then exit for it to show the correct icon

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6726114_1738066865571.Thumbnail_is_showing_as_greyed_out_.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021884357798729909841
  • Upwork Job ID: 1884357798729909841
  • Last Price Increase: 2025-02-18
Issue OwnerCurrent Issue Owner: @yuwenmemon
@IuliiaHerets IuliiaHerets added Bug Something is broken. Auto assigns a BugZero manager. DeployBlockerCash This issue or pull request should block deployment labels Jan 28, 2025
Copy link

melvin-bot bot commented Jan 28, 2025

Triggered auto assignment to @VictoriaExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Jan 28, 2025

Triggered auto assignment to @stitesExpensify (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@melvin-bot melvin-bot bot added the Daily KSv2 label Jan 28, 2025
Copy link

melvin-bot bot commented Jan 28, 2025

💬 A slack conversation has been started in #expensify-open-source

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Jan 28, 2025
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@IuliiaHerets
Copy link
Author

Production behavior

bandicam.2025-01-28.14-25-23-977.mp4

@VictoriaExpensify VictoriaExpensify added the External Added to denote the issue can be worked on by a contributor label Jan 28, 2025
@melvin-bot melvin-bot bot changed the title When creating Task through composer, thumbnail displays as grey w/ no icon [$250] When creating Task through composer, thumbnail displays as grey w/ no icon Jan 28, 2025
Copy link

melvin-bot bot commented Jan 28, 2025

Job added to Upwork: https://www.upwork.com/jobs/~021884357798729909841

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jan 28, 2025
Copy link

melvin-bot bot commented Jan 28, 2025

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ahmedGaber93 (External)

@yuwenmemon
Copy link
Contributor

Hmmm I can't seem to reproduce...

@yuwenmemon
Copy link
Contributor

Removing the blocker for this one, since even if it was reproducible would be an improvement over production. But @bernhardoj can you please have a look when you get the chance?

@yuwenmemon yuwenmemon removed the DeployBlockerCash This issue or pull request should block deployment label Jan 29, 2025
@yuwenmemon yuwenmemon self-assigned this Jan 29, 2025
@yuwenmemon yuwenmemon added Daily KSv2 and removed Hourly KSv2 labels Jan 29, 2025
@kaushiktd
Copy link
Contributor

Proposal

Please re-state the problem that we are trying to solve in this issue.

When creating Task through composer, thumbnail displays as grey w/ no icon

What is the root cause of that problem?

The issue you're encountering stems from the regular expression here. CONST.REGEX.TASK_TITLE_WITH_OPTIONAL_SHORT_MENTION
This expression correctly checks the task title from the user mention but does not capture the task title and assignee email separately. It verifies the input but does not extract the title and assignee email address from the user's composer input to create a task, causing the thumbnail to not display on the task.

What changes do you think we should make in order to solve the problem?

To resolve this issue, you need to adjust the expression here as mentioned below and update the email expression to ensure proper extraction.

const EMAIL_REGEX = "[a-zA-Z0-9._%+-]+@[a-zA-Z0-9.-]+\\.[a-zA-Z]{2,}";
TASK_TITLE_WITH_OPTONAL_SHORT_MENTION: `^\\[\\]\\s+(?:@(${EMAIL_REGEX}))?\\s*(.*)`,

Also you need to adjust handleCreateTask function when user create task from composer as mention below here.

const TASK_TITLE_WITH_OPTONAL_SHORT_MENTION = new RegExp(
    CONST.REGEX.TASK_TITLE_WITH_OPTONAL_SHORT_MENTION, "i"
);
const match = text.match(TASK_TITLE_WITH_OPTONAL_SHORT_MENTION);
if (!match) {
    return false;
}
let title = match[2] ? match[2].trim().replace(/\n/g, ' ') : undefined;
if (!title) {
    return false;
}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

Recording
Screen.Recording.2025-01-29.at.1.35.25.PM.mov

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

@ahmedGaber93
Copy link
Contributor

@bernhardoj bump #55857 (comment).

Copy link

melvin-bot bot commented Feb 11, 2025

@yuwenmemon @ahmedGaber93 @VictoriaExpensify this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

Copy link

melvin-bot bot commented Feb 11, 2025

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

Copy link

melvin-bot bot commented Feb 14, 2025

@yuwenmemon, @ahmedGaber93, @VictoriaExpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot melvin-bot bot added the Overdue label Feb 14, 2025
@ahmedGaber93
Copy link
Contributor

Bump @VictoriaExpensify on slack to but internal label.

@melvin-bot melvin-bot bot removed the Overdue label Feb 14, 2025
@VictoriaExpensify
Copy link
Contributor

@yuwenmemon sounds like this is a BE issue, are you able to confirm?

@melvin-bot melvin-bot bot added the Overdue label Feb 17, 2025
@yuwenmemon
Copy link
Contributor

Hmm yeah appears to be. Will take a look!

@ahmedGaber93
Copy link
Contributor

Not overdue #55857 (comment)

@melvin-bot melvin-bot bot removed the Overdue label Feb 17, 2025
Copy link

melvin-bot bot commented Feb 18, 2025

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@yuwenmemon yuwenmemon added Internal Requires API changes or must be handled by Expensify staff Weekly KSv2 Improvement Item broken or needs improvement. and removed External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Engineering Daily KSv2 Internal Requires API changes or must be handled by Expensify staff labels Feb 18, 2025
@yuwenmemon
Copy link
Contributor

@ahmedGaber93 @bernhardoj I can update the BE to send the personal details, however it looks like some work is needed by the FE to populate those details into the report action for the task. At least, in my testing, this was necessary. I can let you know once the update for the BE is deployed and let you have another look?

@bernhardoj
Copy link
Contributor

@yuwenmemon sounds good

@yuwenmemon
Copy link
Contributor

Backend PR is up.

@bernhardoj it might actually have been a setting on my own environment that was causing me to not see the update right away. We can confirm once it's deployed.

@yuwenmemon yuwenmemon added the Reviewing Has a PR in review label Feb 20, 2025
@melvin-bot melvin-bot bot added Monthly KSv2 and removed Weekly KSv2 labels Mar 17, 2025
Copy link

melvin-bot bot commented Mar 17, 2025

This issue has not been updated in over 15 days. @yuwenmemon, @ahmedGaber93, @VictoriaExpensify eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@ahmedGaber93
Copy link
Contributor

ahmedGaber93 commented Mar 17, 2025

The issue has fixed, I can't reproduce it.

20250317170612100.mp4

@VictoriaExpensify Let's close it then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Improvement Item broken or needs improvement. Monthly KSv2 Reviewing Has a PR in review
Projects
Status: Done
Development

No branches or pull requests

7 participants