-
Notifications
You must be signed in to change notification settings - Fork 3.2k
[$250] When creating Task through composer, thumbnail displays as grey w/ no icon #55857
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Triggered auto assignment to @VictoriaExpensify ( |
Triggered auto assignment to @stitesExpensify ( |
💬 A slack conversation has been started in #expensify-open-source |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
Production behavior bandicam.2025-01-28.14-25-23-977.mp4 |
Job added to Upwork: https://www.upwork.com/jobs/~021884357798729909841 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @ahmedGaber93 ( |
Hmmm I can't seem to reproduce... |
Removing the blocker for this one, since even if it was reproducible would be an improvement over production. But @bernhardoj can you please have a look when you get the chance? |
ProposalPlease re-state the problem that we are trying to solve in this issue.When creating Task through composer, thumbnail displays as grey w/ no icon What is the root cause of that problem?The issue you're encountering stems from the regular expression here. What changes do you think we should make in order to solve the problem?To resolve this issue, you need to adjust the expression here as mentioned below and update the email expression to ensure proper extraction.
Also you need to adjust
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?What alternative solutions did you explore? (Optional)RecordingScreen.Recording.2025-01-29.at.1.35.25.PM.movReminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job. |
@bernhardoj bump #55857 (comment). |
@yuwenmemon @ahmedGaber93 @VictoriaExpensify this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks! |
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸 |
@yuwenmemon, @ahmedGaber93, @VictoriaExpensify Whoops! This issue is 2 days overdue. Let's get this updated quick! |
Bump @VictoriaExpensify on slack to but internal label. |
@yuwenmemon sounds like this is a BE issue, are you able to confirm? |
Hmm yeah appears to be. Will take a look! |
Not overdue #55857 (comment) |
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸 |
@ahmedGaber93 @bernhardoj I can update the BE to send the personal details, however it looks like some work is needed by the FE to populate those details into the report action for the task. At least, in my testing, this was necessary. I can let you know once the update for the BE is deployed and let you have another look? |
@yuwenmemon sounds good |
Backend PR is up. @bernhardoj it might actually have been a setting on my own environment that was causing me to not see the update right away. We can confirm once it's deployed. |
This issue has not been updated in over 15 days. @yuwenmemon, @ahmedGaber93, @VictoriaExpensify eroding to Monthly issue. P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do! |
The issue has fixed, I can't reproduce it. 20250317170612100.mp4@VictoriaExpensify Let's close it then. |
Uh oh!
There was an error while loading. Please reload this page.
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: v9.0.90-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail: #55702
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Macbook Pro 2023 / Sequioa 15.2
App Component: Chat Report View
Action Performed:
Expected Result:
A task is created and the thumbnail shows an Expensify icon
Actual Result:
The task is created, however the thumbnail is greyed out. User must access the task and then exit for it to show the correct icon
Workaround:
Unknown
Platforms:
Screenshots/Videos
Bug6726114_1738066865571.Thumbnail_is_showing_as_greyed_out_.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @yuwenmemonThe text was updated successfully, but these errors were encountered: