Skip to content

[HOLD for payment 2025-02-06] [HOLD for payment 2025-02-05] WS - There is an error when the admin clicks on the owner's profile on the members page #55831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 of 8 tasks
mitarachim opened this issue Jan 28, 2025 · 26 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering

Comments

@mitarachim
Copy link

mitarachim commented Jan 28, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: v9.0.90-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5514592&group_by=cases:section_id&group_order=asc&group_id=229065
Email or phone of affected tester (no customers): n/a
Issue reported by: Applause Internal Team
Device used: Mac 15.2/Safari
App Component: Workspace Settings

Action Performed:

  1. Navigate to https://staging.new.expensify.com/
    Owner (expensifail account)
  2. Create a Workspace
    2.Navigate to members and add a member you have access to
  3. Select the new member and set them as admin

Admin (expensifail account)

  1. Log in as the new set Admin
  2. Navigate to workspace editor
  3. Navigate to members
  4. Click on the Owner of the workspace

Expected Result:

Admin can see the Owner's profile

Actual Result:

"Uh-oh, something went wrong!" when an Admin clicks on the owner's profile

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6725771_1738039712720.Recording__505.mp4

Logs.log

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @muttmuure
@mitarachim mitarachim added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 DeployBlockerCash This issue or pull request should block deployment labels Jan 28, 2025
Copy link

melvin-bot bot commented Jan 28, 2025

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Jan 28, 2025

Triggered auto assignment to @lakchote (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Jan 28, 2025

💬 A slack conversation has been started in #expensify-open-source

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Jan 28, 2025
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@hungvu193
Copy link
Contributor

hungvu193 commented Jan 28, 2025

Offending PR: #55591
We forgot to import React inside ButtonDisabledWhenOffline component.

// ButtonDisabledWhenOffline component
+ import React from 'react';

@jjcoffee
Copy link
Contributor

cc @truph01 are you able to raise a fix?

@truph01
Copy link
Contributor

truph01 commented Jan 28, 2025

I've opened a draft PR here. Could someone please assign this issue to @jjcoffee so the bot can mark him as the C+ to review the PR?

@lakchote
Copy link
Contributor

I've opened a draft PR here. Could someone please assign this issue to @jjcoffee so the bot can mark him as the C+ to review the PR?

Done.

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Hourly KSv2 labels Jan 28, 2025
@truph01
Copy link
Contributor

truph01 commented Jan 28, 2025

Thanks @hungvu193 for your comment. PR is ready @jjcoffee.

@hungvu193
Copy link
Contributor

I think this kind of bug can be avoided if we write unit test for it. So if it's not urgent, I think you can write a test to make sure ButtonDisabledWhenOffline renders correctly 😄

@lakchote
Copy link
Contributor

I think this kind of bug can be avoided if we write unit test for it. So if it's not urgent, I think you can write a test to make sure ButtonDisabledWhenOffline renders correctly 😄

@truph01 could you do that in a follow up PR please?

Let's not block deployment, but make sure this doesn't happen again too.

@lakchote
Copy link
Contributor

@yuwenmemon yuwenmemon removed the DeployBlockerCash This issue or pull request should block deployment label Jan 29, 2025
@yuwenmemon
Copy link
Contributor

Removing the label as the fix has been deployed.

@melvin-bot melvin-bot bot removed the Weekly KSv2 label Jan 29, 2025
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production labels Jan 29, 2025
@melvin-bot melvin-bot bot changed the title WS - There is an error when the admin clicks on the owner's profile on the members page [HOLD for payment 2025-02-05] WS - There is an error when the admin clicks on the owner's profile on the members page Jan 29, 2025
Copy link

melvin-bot bot commented Jan 29, 2025

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jan 29, 2025
Copy link

melvin-bot bot commented Jan 29, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.90-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-02-05. 🎊

For reference, here are some details about the assignees on this issue:

  • @jjcoffee requires payment through NewDot Manual Requests

Copy link

melvin-bot bot commented Jan 29, 2025

@jjcoffee @muttmuure @jjcoffee The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@jjcoffee
Copy link
Contributor

No payment required - this is a regression fix.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Jan 30, 2025
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2025-02-05] WS - There is an error when the admin clicks on the owner's profile on the members page [HOLD for payment 2025-02-06] [HOLD for payment 2025-02-05] WS - There is an error when the admin clicks on the owner's profile on the members page Jan 30, 2025
Copy link

melvin-bot bot commented Jan 30, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.91-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-02-06. 🎊

For reference, here are some details about the assignees on this issue:

  • @jjcoffee requires payment through NewDot Manual Requests

Copy link

melvin-bot bot commented Jan 30, 2025

@jjcoffee @muttmuure @jjcoffee The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Feb 4, 2025
Copy link

melvin-bot bot commented Feb 6, 2025

Payment Summary

Upwork Job

BugZero Checklist (@muttmuure)

  • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
  • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
  • I have paid out the Upwork contracts or cancelled the ones that are incorrect
  • I have verified the payment summary above is correct

@melvin-bot melvin-bot bot added the Overdue label Feb 6, 2025
@jjcoffee
Copy link
Contributor

jjcoffee commented Feb 6, 2025

No payment required - this is a regression fix.

Copy link

melvin-bot bot commented Feb 7, 2025

@lakchote, @jjcoffee, @muttmuure Whoops! This issue is 2 days overdue. Let's get this updated quick!

Copy link

melvin-bot bot commented Feb 11, 2025

@lakchote, @jjcoffee, @muttmuure 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

@jjcoffee
Copy link
Contributor

@muttmuure This can be closed.

Copy link

melvin-bot bot commented Feb 13, 2025

@lakchote, @jjcoffee, @muttmuure 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

@lakchote
Copy link
Contributor

Closing the issue as no payment is due (regression fix), as @jjcoffee commented here.

@melvin-bot melvin-bot bot removed the Overdue label Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering
Projects
None yet
Development

No branches or pull requests

7 participants