Skip to content

[Hold #49844] [$250] HybridApp - Can't validate the account of a new sign-up on a controlled private domain #55771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
2 of 8 tasks
IuliiaHerets opened this issue Jan 27, 2025 · 51 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Monthly KSv2

Comments

@IuliiaHerets
Copy link

IuliiaHerets commented Jan 27, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: v9.0.89-5
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: No, reproducible on hybrid only
If this was caught during regression testing, add the test name, ID and link from TestRail: C2593731
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Samsung A15 Android 14 & iPhone SE 3rd generation (2022) iOS 18.2.1 | Hybrid app.
App Component: Other

Action Performed:

Prerequisite:

  • Sign-up with an account on a domain controlled domain (e.g expensifail.com
  1. Download the latest HybridApp
  2. Sign-up for an expensifail account
  3. Click the validation link in the email to be deep linked back to the app

Expected results:

The user is signed-in and the account is validated

Actual results:

Deep linked back to the mobile app home page, but the user is not signed-in and the account is not validated.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6723303_1737760238492.Samsung_A15__Android_14__v9.0.89-5.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021890456886781005940
  • Upwork Job ID: 1890456886781005940
  • Last Price Increase: 2025-02-28
Issue OwnerCurrent Issue Owner: @ahmedGaber93
@IuliiaHerets IuliiaHerets added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 labels Jan 27, 2025
Copy link

melvin-bot bot commented Jan 27, 2025

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@alexpensify
Copy link
Contributor

I see #51090 has been closed since October. I'm still digging if this is a dupe.

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Jan 31, 2025
Copy link

melvin-bot bot commented Feb 3, 2025

@alexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@alexpensify
Copy link
Contributor

No update

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Feb 4, 2025
@alexpensify
Copy link
Contributor

Still on the radar

@melvin-bot melvin-bot bot removed the Overdue label Feb 7, 2025
Copy link

melvin-bot bot commented Feb 10, 2025

@alexpensify this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@melvin-bot melvin-bot bot added the Overdue label Feb 10, 2025
Copy link

melvin-bot bot commented Feb 10, 2025

@alexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@alexpensify
Copy link
Contributor

I didn't get to test over the weekend and I worked limited hours today

Copy link

melvin-bot bot commented Feb 14, 2025

@alexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

@alexpensify
Copy link
Contributor

Image

Image

@melvin-bot melvin-bot bot removed the Overdue label Feb 14, 2025
@alexpensify alexpensify added External Added to denote the issue can be worked on by a contributor Overdue labels Feb 14, 2025
@melvin-bot melvin-bot bot changed the title 55657 - Hybrid app - Sign In - Create a new expensifail account [$250] 55657 - Hybrid app - Sign In - Create a new expensifail account Feb 14, 2025
@melvin-bot melvin-bot bot removed the Overdue label Feb 27, 2025
@war-in
Copy link
Contributor

war-in commented Feb 28, 2025

Hi 👋 together with @trjExpensify we had a debug session when we discovered that the sign-up flow on controlled private domain differs between web and mobile. We think that the web flow was updated (to use magic code), but the Mobile-Expensify part has been omitted for some reason.
The easiest way to fix the issue would be to wait for the sign-in page replacement, which is already in progress. We're changing HybridApp to use the NewDot sign-in page, and the flow works correctly there, so no adjustments are required.

However, it'll take some time because we're waiting for the backend changes and must thoroughly test the PRs.

@trjExpensify
Copy link
Contributor

Yeah, @AndrewGable @Julesssss, it seems like all our woes on mobile stem from not using the same flow with the magic code, which makes me think that's going to be quite the lift to unravel and moving to the NewDot sign-in page means we don't have to do work we'll throw away shortly after. Curious for your takes as well, but that's where my head's at as it stands.

@sosek108
Copy link
Contributor

@war-in @trjExpensify isn't that bug connected to bug posted here?

Copy link

melvin-bot bot commented Feb 28, 2025

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@Julesssss
Copy link
Contributor

Thanks for the tag. I agree with this given that we already have the task listed as high priority.

However, it'll take some time because we're waiting for the backend changes and must thoroughly test the PRs.

I know I have said this many times, but I should be able to focus on the backend tasks next week -- the issues I switched too are almost done 🤞

@trjExpensify
Copy link
Contributor

Cool, cool. Glad we're aligned. What's the best issue for me to put this on hold for? We can retest once done.

@trjExpensify
Copy link
Contributor

@war-in @trjExpensify isn't #57367 connected to bug posted here?

If they signed up with an expensifail.com account, probably yes, as it's domain controlled. CC: @joekaufmanexpensify I think you might have a dupe there bud!

@joekaufmanexpensify
Copy link
Contributor

Ah, yeah mine was with an expensifail account. Thanks for flagging, will close in favor of this one!

@Julesssss
Copy link
Contributor

Cool, cool. Glad we're aligned. What's the best issue for me to put this on hold for? We can retest once done.

I think this one. It has the latest overview of remaining tasks.

@trjExpensify trjExpensify changed the title [$250] HybridApp - Can't validate the account of a new sign-up on a controlled private domain [Hold #49844] [$250] HybridApp - Can't validate the account of a new sign-up on a controlled private domain Feb 28, 2025
Copy link

melvin-bot bot commented Mar 5, 2025

@ahmedGaber93 Huh... This is 4 days overdue. Who can take care of this?

@melvin-bot melvin-bot bot added the Overdue label Mar 5, 2025
@ahmedGaber93
Copy link
Contributor

Not overdue, still on hold.

@melvin-bot melvin-bot bot removed the Overdue label Mar 5, 2025
@alexpensify alexpensify added Weekly KSv2 and removed Daily KSv2 labels Mar 5, 2025
@alexpensify

This comment has been minimized.

@alexpensify
Copy link
Contributor

Weekly Update: Waiting on #49844

@melvin-bot melvin-bot bot added the Overdue label Mar 13, 2025
@ahmedGaber93
Copy link
Contributor

The same #55771 (comment)

@melvin-bot melvin-bot bot removed the Overdue label Mar 17, 2025
@melvin-bot melvin-bot bot added the Overdue label Mar 28, 2025
@alexpensify
Copy link
Contributor

alexpensify commented Mar 28, 2025

Weekly Update: Still on hold and waiting for #49844


🚨 Heads up! I'll be offline until Monday, April 7, 2025, and won’t be actively monitoring this GitHub during that time.

If this GitHub requires an urgent update, please reapply the bug label or reach out in the #expensify-open-source Slack room for help. Otherwise, I'll pick things up when I'm back online. Thanks!

@melvin-bot melvin-bot bot removed the Overdue label Mar 28, 2025
@melvin-bot melvin-bot bot added Monthly KSv2 and removed Weekly KSv2 labels Apr 21, 2025
Copy link

melvin-bot bot commented Apr 21, 2025

This issue has not been updated in over 15 days. @alexpensify, @ahmedGaber93 eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@alexpensify
Copy link
Contributor

Still on hold for (#49844)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Monthly KSv2
Projects
Development

No branches or pull requests

9 participants