Skip to content

[$250 reproduction steps][CRITICAL] Login - Unable to sign in with Google #55682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 of 8 tasks
lanitochka17 opened this issue Jan 23, 2025 · 56 comments
Closed
1 of 8 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Weekly KSv2

Comments

@lanitochka17
Copy link

lanitochka17 commented Jan 23, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Deliverable

The deliverable is to provide reliable reproduction steps for the bug. - Follow the Propose a solution for a job process to submit the steps for review”. Inc. preconditions and additional details if they’re helpful. (ie. require x beta to be enabled, must be on a Collect plan)

Version Number: 9.0.89-2
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: #55521
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause - Internal Team

Action Performed:

  1. Open the Hybrid Android app
  2. Tap on Continue with Google
  3. Choose an account

Expected Result:

The app leads to the Inbox screen

Actual Result:

An error message is displayed

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
Bug6720072_1737480252044.Sign-in_with_Google.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021889704177684673850
  • Upwork Job ID: 1889704177684673850
  • Last Price Increase: 2025-02-12
  • Automatic offers:
    • DylanDylann | Reviewer | 106658000
Issue OwnerCurrent Issue Owner: @DylanDylann
@lanitochka17 lanitochka17 added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 labels Jan 23, 2025
Copy link

melvin-bot bot commented Jan 23, 2025

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@isagoico isagoico added the Hourly KSv2 label Jan 24, 2025
@mountiny mountiny added the DeployBlocker Indicates it should block deploying the API label Jan 24, 2025
@mountiny
Copy link
Contributor

Adding backend Deploy blocker as it was also repro in production but its a serious bug

@mountiny mountiny added the DeployBlockerCash This issue or pull request should block deployment label Jan 24, 2025
Copy link

melvin-bot bot commented Jan 24, 2025

Triggered auto assignment to @tgolen (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Jan 24, 2025

💬 A slack conversation has been started in #expensify-open-source

@github-actions github-actions bot added Engineering and removed Daily KSv2 labels Jan 24, 2025
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@mountiny
Copy link
Contributor

Asked QA about the reproducability https://expensify.slack.com/archives/C9YU7BX5M/p1737756072117619

Since its repro in production, it is technically not a blocker, might be some auth change or web change, but if this is happening commonly it should be treated with urgency, hence I applied the labels

@mountiny
Copy link
Contributor

Found logs for the user listed but there is no error

@tgolen
Copy link
Contributor

tgolen commented Jan 24, 2025

That's pretty strange that it would only happen on Android, if it was a backend problem. I would think that would fail on all platforms if it was a backend problem.

@mountiny mountiny added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 DeployBlocker Indicates it should block deploying the API labels Jan 25, 2025
@mountiny
Copy link
Contributor

Qa confirmed in slack they cannot reproduce anymore - i have asked them still for more details if we could figure out what caused this outage.

@tgolen
Copy link
Contributor

tgolen commented Jan 27, 2025

OK, since it cannot be reproduced, I will close this.

@tgolen tgolen closed this as completed Jan 27, 2025
@mitarachim
Copy link

QA team can repro this issue in Hybrid Android - STG build 9.0.97-0

XRecorder_20250212_02.mp4

@mitarachim mitarachim reopened this Feb 12, 2025
@tgolen
Copy link
Contributor

tgolen commented Feb 12, 2025

I'll see if we can get some external help to triage this.

@tgolen tgolen added Help Wanted Apply this label when an issue is open to proposals by contributors External Added to denote the issue can be worked on by a contributor labels Feb 12, 2025
Copy link

melvin-bot bot commented Mar 19, 2025

@DylanDylann Eep! 4 days overdue now. Issues have feelings too...

@tgolen
Copy link
Contributor

tgolen commented Mar 19, 2025

This one sure comes and goes. I think it would be great if we assign this to one of our expert agencies and really have them do a deep dive an investigation into the bug.

@mitarachim
Copy link

QA team could repro this issue again in Hybrid Android - STG build 9.1.15-0

az_recorder_20250318_213700.mp4

Copy link

melvin-bot bot commented Mar 21, 2025

@DylanDylann 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

@tgolen
Copy link
Contributor

tgolen commented Mar 24, 2025

Daily Update

Next Steps

  • See if an expert agency is able to pick this up and discover the problem

ETA

  • Friday, Mar. 28 to have some kind of plan for this

@tgolen tgolen added Weekly KSv2 and removed Daily KSv2 labels Mar 24, 2025
@melvin-bot melvin-bot bot removed the Overdue label Mar 24, 2025
@sosek108
Copy link
Contributor

Hi, I'm Hubert from Callstack - expert contributor group. I'd like to look into this issue.

Unfortunately I was not able to reproduce this, so could you provide some logs as mentioned here?

@melvin-bot melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Mar 25, 2025
Copy link

melvin-bot bot commented Mar 25, 2025

📣 @DylanDylann 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

@mallenexpensify
Copy link
Contributor

Posted in #qa for a retest.

Can I get a retest on this issue? We're having reproducing so, can the tester include profiling and client side logs with their retest? Thx

@mallenexpensify mallenexpensify moved this from Done to CRITICAL in [#whatsnext] #quality Mar 26, 2025
@m-natarajan
Copy link

Able to reproduce , Unable to collect profiling and client side logs as user was not able to signin

Retest.55682.mp4

@mallenexpensify
Copy link
Contributor

Unsure of next steps cuz QA is able to reproduce yet @sosek108 and I aren't
@DylanDylann are you able to repro?

Posted in the Slack thread and shared with room to see if this is widespread.

@sosek108
Copy link
Contributor

@m-natarajan did you test on Staging or Prod?

@sosek108
Copy link
Contributor

With help of @mountiny I've checked logs of adhoc build and it says Expensify: [warn] (anonymous) Google signIn callback returned error: DEVELOPER_ERROR. This error most probably means build misconfiguration. To properly use Google SSO there is a need to add application signing key to Firebase.

I've double checked that with build 9.1.15-9 which is current production build. When I tried login with production application (downloaded from Google Play) it worked fine, but when I installed this build from here https://github.com/Expensify/App/releases it results in error.

I suggest that person who has access to Expensify's Firebase and application builds double check if signing key of staging and adhoc builds are properly set in Firebase.

@m-natarajan to confirm that theory I need information that if you could reproduce this on production version?

@mountiny
Copy link
Contributor

@sosek108 I check the firebase setup but it seems like its all correct :/

@sosek108
Copy link
Contributor

sosek108 commented Apr 1, 2025

I've noticed that PROD has been updated to 9.1.18-4. Google SignIn works on this prod version

@mountiny
Copy link
Contributor

mountiny commented Apr 1, 2025

@tgolen do you know if this was reported by any customers? Maybe its related to the version switching that @sosek108 also noticed so then internal people and testers are prone to this issue but if customer just uses production it seems to work just fine

@tgolen
Copy link
Contributor

tgolen commented Apr 1, 2025 via email

@sosek108
Copy link
Contributor

sosek108 commented Apr 1, 2025

@mountiny @tgolen since I started working on that issue I had 0 reproduction rate on production. Although this is 100% reproducible on Adhoc, Staging and Dev builds.

I did more research on that and due to documentations and how-to's DEVELOPER_ERROR which is returned on Adhoc and Dev mode is connected to Firebase / Google Console configuration only.

@tgolen
Copy link
Contributor

tgolen commented Apr 1, 2025 via email

@sosek108
Copy link
Contributor

sosek108 commented Apr 1, 2025

@tgolen I assume this error also occurs on staging. But I cannot be sure as no debug logs are sent to logcat on staging / prod builds

@tgolen
Copy link
Contributor

tgolen commented Apr 1, 2025 via email

@tgolen
Copy link
Contributor

tgolen commented Apr 8, 2025

I'm going to close this for now. It can be reopened if it is reproducible in production.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Weekly KSv2
Projects
Status: Done
Development

No branches or pull requests