[HOLD for payment 2025-02-04] [$125] Android- Netsuite- Advanced page for "custom form ID" detail is not visible

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.85-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5456904
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause - Internal Team

Action Performed:

Precondition : NetSuite connection is established in the workspace.

1. Navigate to Hybrid android app
2. Navigate to Accounting
3. Click on Advanced
4. Scroll down to the "Custom form ID" and Notice the detail

Expected Result:

Detail Information for "Custom form ID" is visible fully

Actual Result:

The first line of detail Information for "Custom form ID" is only visible

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6714218_1736883969471.Screen_Recording_20250114_223148_Expensify.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021879917003425901165
• Upwork Job ID: 1879917003425901165
• Last Price Increase: 2025-01-16
• Automatic offers:
• daledah | Contributor | 105729506

Issue Owner

Current Issue Owner: @greg-schroeder

[melvin-bot]

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[daledah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Android- Netsuite- Advanced page for "custom form ID" detail is not visible

What is the root cause of that problem?

We are not using safe area padding bottom:

App/src/pages/workspace/accounting/netsuite/advanced/NetSuiteAdvancedPage.tsx

Line 227 in 3fc71c9

<ConnectionLayout

so the custom form ID section is overlapped by the device navigation button.

What changes do you think we should make in order to solve the problem?

We should use <ConnectionLayout shouldIncludeSafeAreaPaddingBottom ... />.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

[melvin-bot]

⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021879917003425901165

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hungvu193 (External)

[hungvu193]

@daledah 's proposal is straightforward. Please check other places that are using ConnectionLayout if we should include the padding-bottom as well.

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @rafecolton, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

📣 @daledah 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

@rafecolton, @hungvu193, @greg-schroeder, @daledah Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.89-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: Advanced page for "custom form ID" detail is not visible #55389

If no regressions arise, payment will be issued on 2025-02-04. 🎊

For reference, here are some details about the assignees on this issue:

• @hungvu193 requires payment through NewDot Manual Requests
• @daledah requires payment automatic offer (Contributor)

[melvin-bot]

@hungvu193 @greg-schroeder @hungvu193 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[hungvu193]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other:

Where bug was reported:

• 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
• 2b. Reported on staging (eg. found during regression or PR testing)
• 2d. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment: https://github.com/Expensify/App/pull/44723/files#r1938708993

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion: N/A

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

Regression Test Proposal

Precondition:

• User have NetSuite config.

Test:

1. Navigate to Hybrid android app
2. Navigate to Accounting
3. Click on Advanced
4. Scroll down to the "Custom form ID" and Notice the detail
5. Verify that the Custom form ID details section is fully visible.

Do we agree 👍 or 👎

[greg-schroeder]

Payment summary:

Contributor: @daledah - $125 - Upwork
C+: @hungvu193 - $125 - ND Manual Request

[greg-schroeder]

Filed regression test

[garrettmknight]

$125 approved for @hungvu193