[HOLD for payment 2025-02-04] Extreme slowdowns on staging desktop Chrome and multi-second delay when switching chats

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number:
Reproducible in staging?: Needs Reproduction
Reproducible in production?: Needs Reproduction
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @quinthar
Slack conversation (hyperlinked to channel name): quality

Action Performed:

1. Login to the app and switch chats

Expected Result:

No slowdowns and delay when switching chats

Actual Result:

Extreme slowdowns and multi-second delay when switching chats

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Screen.Recording.2025-01-08.at.12.26.23.PM.mov

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @abekkala

[melvin-bot]

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @cristipaval (AutoAssignerNewDotQuality)

[MelvinBot]

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

[muttmuure]

Is this a dupe of #54802?

[TMisiukiewicz]

I'm going to open a PR that should fix it tomorrow. I'll link this issue. The problem is described here. @muttmuure I would not treat this one as a dupe, since it is specifically focused on switching chats - however the solution proposed in the linked issue should also lead to fewer slowdowns in the app in general

[adhorodyski]

@muttmuure we can get this one assigned to me (coming from https://expensify.slack.com/archives/C05LX9D6E07/p1736786567631859?thread_ts=1736361986.816249&cid=C05LX9D6E07), I'm working closely with @TMisiukiewicz across these 2 issues as they're interconnected.

[muttmuure]

hero

[TMisiukiewicz]

It should be fixed once #55260 and #55297 are merged

[rayane-d]

@abekkala Please assign me here as C+, I reviewed this PR:

• perf: avoid using getOrderedReportIDs when calculating GBR/RBR state #55260

[adhorodyski]

Awaiting David's feedback now, so far we have good feedbacks about these changes.

[adhorodyski]

Looks like this got resolved for David here on Slack. @muttmuure what should be the next step for this issue, are we due to close?

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.89-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• perf: avoid using getOrderedReportIDs when calculating GBR/RBR state #55260

If no regressions arise, payment will be issued on 2025-02-04. 🎊

For reference, here are some details about the assignees on this issue:

• @adhorodyski does not require payment (Contractor)
• @rayane-djouah requires payment through NewDot Manual Requests

[melvin-bot]

@rayane-djouah @abekkala @rayane-djouah The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[abekkala]

PAYMENT SUMMARY FOR FEB 04

• Fix: @TMisiukiewicz no payment needed (contractor)
• PR Review: @rayane-djouah [$250, if no regressions] payment via NewDot
  Please complete checklist

[rayane-d]

BugZero Checklist:

• Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other: Performance bug

Where bug was reported:

• 2a. Reported on production
• 2b. Reported on staging (deploy blocker)
• 2c. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment: https://github.com/Expensify/App/pull/51675/files#r1940036453

• If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion: N/A

• If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

No regression test is needed as this is a performance improvement and the PR is a refactor.

[melvin-bot]

📣 @rayane-d! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[melvin-bot]

Payment Summary

Upwork Job

• Contributor: @adhorodyski is from an agency-contributor and not due payment
• ROLE: @rayane-d paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@abekkala)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[rayane-d]

Requested in NewDot

[abekkala]

no regression test needed.

Payment summary for Feb 04 posted above

[garrettmknight]

$250 approved for @rayane-d