Skip to content

Previously logged out user is displayed for a moment in second tab #5245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kavimuru opened this issue Sep 14, 2021 · 10 comments
Closed

Previously logged out user is displayed for a moment in second tab #5245

kavimuru opened this issue Sep 14, 2021 · 10 comments
Assignees
Labels
Engineering External Added to denote the issue can be worked on by a contributor Improvement Item broken or needs improvement. Monthly KSv2

Comments

@kavimuru
Copy link

kavimuru commented Sep 14, 2021

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Issue was found when executing #5190

Action Performed:

  1. Sign in to New Expensify in one tab (A), open a second tab (B) with New Expensify (you should be signed in automatically)
  2. In tab A, sign out then sign in with a new account

Expected Result:

In tab B, the user should be automatically signed out

Actual Result:

In tab B, the previously logged in account is displayed for a few seconds before new account is displayed

Workaround:

Unkown

Platform:

Where is this issue occurring?

  • Web
  • Mobile Web (Safari)

Version Number:
1.0.98-0
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Bug5235612_RPReplay_Final1631577544.mp4

Expensify/Expensify Issue URL:
Issue reported by: Applause
Slack conversation:

View all open jobs on GitHub

@MelvinBot
Copy link

Triggered auto assignment to @aldo-expensify (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@isagoico isagoico changed the title mWeb - Chat - Previously logged out user is displayed for a moment in second tab Previously logged out user is displayed for a moment in second tab Sep 14, 2021
@aldo-expensify
Copy link
Contributor

It looks like the logout account synchronization across tabs is not working in Safari. In Chrome it looks fine.

Safari - other tab doesn't log out

Screen.Recording.2021-09-14.at.12.25.54.PM.mov

Chrome

Screen.Recording.2021-09-14.at.12.25.09.PM.mov

@parasharrajat
Copy link
Member

Good find @aldo-expensify. I will take a look.

@aldo-expensify
Copy link
Contributor

Good find @aldo-expensify. I will take a look.

Sorry @parasharrajat , tested again and I'm not being able to reproduce it again, so my comment on this may be misleading from the real cause.

@parasharrajat
Copy link
Member

It can be closed.

@aldo-expensify
Copy link
Contributor

Maybe this happens on a mobile browser because in mobile the browser doesn't work on updating all tabs at the same rate as in the desktop (for performance reasons)? Is it possible that Safari + IPhone shows snapshot of the tab when we see it from this view:

Screen Shot 2021-09-15 at 1 11 05 PM

And that could be the reason why we don't see it change it until we make it the active tab?

@Beamanator @marcaaron , what do you guys think? should we just close this?

@marcaaron
Copy link
Contributor

Doesn't seem like a priority to me.

@aldo-expensify aldo-expensify added Monthly KSv2 External Added to denote the issue can be worked on by a contributor and removed Daily KSv2 labels Sep 16, 2021
@MelvinBot
Copy link

Triggered auto assignment to @jliexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@aldo-expensify aldo-expensify added the Improvement Item broken or needs improvement. label Sep 16, 2021
@MelvinBot MelvinBot added Daily KSv2 and removed Monthly KSv2 labels Sep 16, 2021
@aldo-expensify aldo-expensify added Monthly KSv2 and removed Daily KSv2 labels Sep 16, 2021
@aldo-expensify aldo-expensify removed their assignment Sep 22, 2021
@jliexpensify
Copy link
Contributor

Hi! Just hoping to confirm: are we ok to close this GH, or are we looking to roll out a fix after n6?

@marcaaron
Copy link
Contributor

I would vote to close it. It doesn't seem like a real problem we need to solve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering External Added to denote the issue can be worked on by a contributor Improvement Item broken or needs improvement. Monthly KSv2
Projects
None yet
Development

No branches or pull requests

7 participants