Skip to content

[$250] Expense-Delete and replace options displayed for receipt in archived workspace offline #50558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 of 6 tasks
IuliiaHerets opened this issue Oct 10, 2024 · 54 comments
Closed
1 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors

Comments

@IuliiaHerets
Copy link

IuliiaHerets commented Oct 10, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.47-1
Reproducible in staging?: Y
Reproducible in production?: Y
Issue was found when executing this PR: #50395
Issue reported by: Applause Internal Team

Action Performed:

  1. Open the app and log in
  2. Navigate to a workspace chat
  3. Disable internet connection
  4. Create an expense with a receipt
  5. Navigate to the list of workspaces and delete the workspace
  6. Open the archived workspace chat
  7. Select the expense > tap 3 dots

Expected Result:

The "Delete" and "Replace" options should not be present

Actual Result:

The "Delete" and "Replace" options are displayed when the workspace is deleted offline

Workaround:

Unknown

Platforms:

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6630264_1728528190992.video_2024-10-09_22-42-43.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021884218250507093585
  • Upwork Job ID: 1884218250507093585
  • Last Price Increase: 2025-02-04
Issue OwnerCurrent Issue Owner: @mananjadhav
@IuliiaHerets IuliiaHerets added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Oct 10, 2024
Copy link

melvin-bot bot commented Oct 10, 2024

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@IuliiaHerets
Copy link
Author

We think that this bug might be related to #wave-collect - Release 1

@IuliiaHerets
Copy link
Author

@dylanexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

@Krishna2323
Copy link
Contributor

I will take a look very soon. It's related to my PR so we don't need proposals here.

@Krishna2323
Copy link
Contributor

Sorry, I completely missed this one. Will raise a PR tomorrow.

@melvin-bot melvin-bot bot added the Overdue label Oct 13, 2024
Copy link

melvin-bot bot commented Oct 15, 2024

@dylanexpensify Huh... This is 4 days overdue. Who can take care of this?

@dylanexpensify
Copy link
Contributor

ongoing

@melvin-bot melvin-bot bot removed the Overdue label Oct 16, 2024
@dylanexpensify dylanexpensify removed the Bug Something is broken. Auto assigns a BugZero manager. label Oct 17, 2024
@dylanexpensify dylanexpensify added the Bug Something is broken. Auto assigns a BugZero manager. label Oct 17, 2024
Copy link

melvin-bot bot commented Oct 17, 2024

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@dylanexpensify
Copy link
Contributor

Hey @johncschuster! I'm heading out on parental leave so reassigning this! TY! 🙇‍♂️

@melvin-bot melvin-bot bot added the Overdue label Oct 21, 2024
Copy link

melvin-bot bot commented Oct 21, 2024

@johncschuster, @Krishna2323 Whoops! This issue is 2 days overdue. Let's get this updated quick!

@johncschuster
Copy link
Contributor

@Krishna2323 how's this one going?

@melvin-bot melvin-bot bot removed the Overdue label Oct 22, 2024
@Krishna2323
Copy link
Contributor

Sorry for delay, I have couple of urgent PR's left to finish, I will probably finish this one tomorrow.

Copy link

melvin-bot bot commented Oct 24, 2024

@johncschuster @Krishna2323 this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@melvin-bot melvin-bot bot added the Overdue label Oct 25, 2024
@johncschuster
Copy link
Contributor

@Krishna2323 how's this one going? Were you able to get a PR up for this?

@melvin-bot melvin-bot bot removed the Overdue label Oct 25, 2024
@melvin-bot melvin-bot bot removed the Overdue label Jan 2, 2025
@melvin-bot melvin-bot bot added the Overdue label Jan 10, 2025
@garrettmknight
Copy link
Contributor

@johncschuster should this be Internal or External?

@johncschuster
Copy link
Contributor

@garrettmknight, I'm not certain. @Krishna2323, can you help us determine if this issue should be Internal or External?

@melvin-bot melvin-bot bot removed the Overdue label Jan 14, 2025
@melvin-bot melvin-bot bot added the Overdue label Jan 23, 2025
@johncschuster
Copy link
Contributor

@Krishna2323 bump!

@melvin-bot melvin-bot bot removed the Overdue label Jan 27, 2025
@garrettmknight garrettmknight added the External Added to denote the issue can be worked on by a contributor label Jan 28, 2025
@melvin-bot melvin-bot bot changed the title Expense-Delete and replace options displayed for receipt in archived workspace offline [$250] Expense-Delete and replace options displayed for receipt in archived workspace offline Jan 28, 2025
Copy link

melvin-bot bot commented Jan 28, 2025

Job added to Upwork: https://www.upwork.com/jobs/~021884218250507093585

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jan 28, 2025
@garrettmknight
Copy link
Contributor

Let's start external if we don't know.

Copy link

melvin-bot bot commented Jan 28, 2025

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jan 28, 2025
@mananjadhav
Copy link
Collaborator

Just got assigned and it has 73 conversations. Will review the previous comments soon.

@FitseTLT
Copy link
Contributor

This should be expected. cc @srikarparsi

@srikarparsi
Copy link
Contributor

Yes, I agree I think this is expected now that we are not archiving expense reports. When we take these actions online, the replace button also exists. cc @trjExpensify to confirm

@trjExpensify
Copy link
Contributor

Yeah, when in doubt, check OldDot. You can edit an expense on a deleted workspace. We're in the process of adding Move expense and Change workspace actions soon, which will allow you to move the expense or expense report to another workspace as well. :)

@melvin-bot melvin-bot bot added the Overdue label Jan 31, 2025
Copy link

melvin-bot bot commented Feb 3, 2025

@mananjadhav, @johncschuster, @Krishna2323 Huh... This is 4 days overdue. Who can take care of this?

@johncschuster
Copy link
Contributor

Thanks @trjExpensify and @srikarparsi! In that case, is this issue even necessary? It sounds like the change in behavior makes this issue irrelevant.

@mananjadhav
Copy link
Collaborator

@trjExpensify @srikarparsi Should we close this one out?

@melvin-bot melvin-bot bot removed the Overdue label Feb 4, 2025
Copy link

melvin-bot bot commented Feb 4, 2025

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@trjExpensify
Copy link
Contributor

Yup!

@github-project-automation github-project-automation bot moved this from Bugs and Follow Up Issues to Done in #expensify-bugs Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors
Projects
Status: Done
Development

No branches or pull requests

9 participants