-
Notifications
You must be signed in to change notification settings - Fork 3.2k
[$250] Expense-Delete and replace options displayed for receipt in archived workspace offline #50558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Triggered auto assignment to @dylanexpensify ( |
We think that this bug might be related to #wave-collect - Release 1 |
@dylanexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors |
I will take a look very soon. It's related to my PR so we don't need proposals here. |
Sorry, I completely missed this one. Will raise a PR tomorrow. |
@dylanexpensify Huh... This is 4 days overdue. Who can take care of this? |
ongoing |
Triggered auto assignment to @johncschuster ( |
Hey @johncschuster! I'm heading out on parental leave so reassigning this! TY! 🙇♂️ |
@johncschuster, @Krishna2323 Whoops! This issue is 2 days overdue. Let's get this updated quick! |
@Krishna2323 how's this one going? |
Sorry for delay, I have couple of urgent PR's left to finish, I will probably finish this one tomorrow. |
@johncschuster @Krishna2323 this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks! |
@Krishna2323 how's this one going? Were you able to get a PR up for this? |
@johncschuster should this be |
@garrettmknight, I'm not certain. @Krishna2323, can you help us determine if this issue should be |
@Krishna2323 bump! |
Job added to Upwork: https://www.upwork.com/jobs/~021884218250507093585 |
Let's start external if we don't know. |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav ( |
Just got assigned and it has 73 conversations. Will review the previous comments soon. |
This should be expected. cc @srikarparsi |
Yes, I agree I think this is expected now that we are not archiving expense reports. When we take these actions online, the replace button also exists. cc @trjExpensify to confirm |
Yeah, when in doubt, check OldDot. You can edit an expense on a deleted workspace. We're in the process of adding |
@mananjadhav, @johncschuster, @Krishna2323 Huh... This is 4 days overdue. Who can take care of this? |
Thanks @trjExpensify and @srikarparsi! In that case, is this issue even necessary? It sounds like the change in behavior makes this issue irrelevant. |
@trjExpensify @srikarparsi Should we close this one out? |
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸 |
Yup! |
Uh oh!
There was an error while loading. Please reload this page.
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: 9.0.47-1
Reproducible in staging?: Y
Reproducible in production?: Y
Issue was found when executing this PR: #50395
Issue reported by: Applause Internal Team
Action Performed:
Expected Result:
The "Delete" and "Replace" options should not be present
Actual Result:
The "Delete" and "Replace" options are displayed when the workspace is deleted offline
Workaround:
Unknown
Platforms:
Screenshots/Videos
Bug6630264_1728528190992.video_2024-10-09_22-42-43.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @mananjadhavThe text was updated successfully, but these errors were encountered: