iOS Production Deploy Failure

[roryabraham]

We need to investigate and fix this deploy failure: https://github.com/Expensify/App/runs/3479417738

[roryabraham]

In the meantime, I've manually submitted 1.0.90-2

[roryabraham]

Sorry, originally meant to assign this to you @AndrewGable

[AndrewGable]

I think this failed because the step didn't run, which I believe is a known issue with releases, the tag has to include the code merged. So we need to wait until we deploy production once more to fully test the new production fix.

[roryabraham]

Reopening, we saw the same failure today: https://github.com/Expensify/App/runs/3490379202

[AndrewGable]

Ok so this time the code did actually run, but it just didn't work. Progress!

[AndrewGable]

It looks like the version was actually set correctly from what I was expecting it to be set

But maybe fastlane is expecting something different than that format. Looking into it!

[AndrewGable]

I can reproduce this locally with 1.0.92.0 as well. I am thinking the build_number needs to be something else 🤔

[AndrewGable]

Issue 1: We were not including the app_version key. Now including app_version: ENV["VERSION"] in deliver will create a release.

Issue 2: Now I am seeing a new error: [14:23:59]: Build number: 1.0.92.0 does not exist

[AndrewGable]

Really confusing error.. The build number does exist, but Fastlane cannot find it. I'm trying to debug the fastlane response right now.

[AndrewGable]

Ok so.. This is weird.. When I set the app_version to 1.0.92.0 it fails. But when I set it to 1.0.92 it will work!

[AndrewGable]

Now trying to fix this new error..

[16:06:06]: Making sure the latest version on App Store Connect matches '1.0.92'...
[16:06:07]: '1.0.92' is the latest version on App Store Connect
[16:06:07]: Detected languages: ["default", "en-US"]
[16:06:07]: Finished the upload to App Store Connect
[16:06:07]: Selecting existing build-number: 1.0.92.0
[16:06:08]: Selecting build 1.0.92 (1.0.92.0)...
[16:06:09]: Successfully selected build
[16:06:12]: Successfully updated IDFA declarations on App Store Connect
+---------------+----------------+
|          Lane Context          |
+---------------+----------------+
| PLATFORM_NAME | ios            |
| LANE_NAME     | ios production |
+---------------+----------------+
[16:06:13]: The request cannot be fulfilled because of the state of another resource. - Submit for review errors found.
The provided entity is missing a required attribute - You must provide a value for the attribute 'whatsNew' with this request

[AndrewGable]

Ok cool finally got all the flags set correctly! Going to clean up the code and submit a PR

[botify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[botify]

🚀 Deployed to staging by @roryabraham in version: 1.0.92-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

[botify]

🚀 Deployed to production by @roryabraham in version: 1.0.93-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅