Skip to content

[HOLD for payment 2024-10-24] [$250] iOS - IOU - The details of a single IOU are not displayed until you scroll up #47584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 of 6 tasks
IuliiaHerets opened this issue Aug 16, 2024 · 42 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor

Comments

@IuliiaHerets
Copy link

IuliiaHerets commented Aug 16, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.21-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4864475
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team

Action Performed:

  1. Open New Expensify app
  2. Log in with a new HT account
  3. Send any IOU to a user with whom you have not had a previous expense.
  4. Open the sent IOU
  5. Scroll up the details
  6. Close the application (kill)
  7. Open the app
  8. Repeat steps 3-5 several times

Expected Result:

IOU details should be automatically displayed when the IOU is opened

Actual Result:

The details of a single IOU are not displayed until you scroll up

Workaround:

Unknown

Platforms:

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6573976_1723830500223.RPReplay_Final1723810132.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~010724ba54874de1b6
  • Upwork Job ID: 1826197658645316035
  • Last Price Increase: 2024-09-04
Issue OwnerCurrent Issue Owner: @zanyrenney
@IuliiaHerets IuliiaHerets added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Aug 16, 2024
Copy link

melvin-bot bot commented Aug 16, 2024

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@IuliiaHerets
Copy link
Author

We think that this bug might be related to #vip-bills

@IuliiaHerets
Copy link
Author

@zanyrenney z FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

@melvin-bot melvin-bot bot added the Overdue label Aug 19, 2024
@zanyrenney
Copy link
Contributor

hey @IuliiaHerets can you explain what a HT account is please?

@melvin-bot melvin-bot bot removed the Overdue label Aug 19, 2024
@IuliiaHerets
Copy link
Author

@zanyrenney High traffic account, but the issue also repro with a regular Expensifail account too

@zanyrenney
Copy link
Contributor

Ah cheers @IuliiaHerets helpful!

@zanyrenney
Copy link
Contributor

Adding external for more support here.

@zanyrenney zanyrenney added the External Added to denote the issue can be worked on by a contributor label Aug 21, 2024
@melvin-bot melvin-bot bot changed the title iOS - IOU - The details of a single IOU are not displayed until you scroll up [$250] iOS - IOU - The details of a single IOU are not displayed until you scroll up Aug 21, 2024
Copy link

melvin-bot bot commented Aug 21, 2024

Job added to Upwork: https://www.upwork.com/jobs/~010724ba54874de1b6

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Aug 21, 2024
Copy link

melvin-bot bot commented Aug 21, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

Copy link

melvin-bot bot commented Aug 26, 2024

@s77rt, @zanyrenney Eep! 4 days overdue now. Issues have feelings too...

@melvin-bot melvin-bot bot added the Overdue label Aug 26, 2024
@s77rt
Copy link
Contributor

s77rt commented Aug 26, 2024

Not overdue. Still looking for proposals

@melvin-bot melvin-bot bot removed the Overdue label Aug 26, 2024
Copy link

melvin-bot bot commented Aug 28, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

Copy link

melvin-bot bot commented Aug 30, 2024

@s77rt @zanyrenney this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@melvin-bot melvin-bot bot added the Overdue label Aug 30, 2024
@s77rt
Copy link
Contributor

s77rt commented Aug 30, 2024

Same ^

@melvin-bot melvin-bot bot removed the Overdue label Aug 30, 2024
Copy link

melvin-bot bot commented Aug 30, 2024

@s77rt, @zanyrenney Whoops! This issue is 2 days overdue. Let's get this updated quick!

@zanyrenney
Copy link
Contributor

@wildan-m
Copy link
Contributor

wildan-m commented Oct 1, 2024

Looks like the PR merged, but I still able to reproduce the issue when deleting one of two money request from another device

Kapture.2024-10-01.at.07.19.01.mp4

@s77rt
Copy link
Contributor

s77rt commented Oct 1, 2024

@kubabutkiewicz Would you be able to look into the above ^ bug?

@kubabutkiewicz
Copy link
Contributor

Yes, I will be able to @s77rt

@kubabutkiewicz
Copy link
Contributor

Hey hey, I was able to find what is the issue

if (shouldEnableAutoScrollToTopThreshold) {
config.autoscrollToTopThreshold = AUTOSCROLL_TO_TOP_THRESHOLD;
}

Issue is here, when the issue occur autoscrollToTopThreshold prop is not set to true. I am checking now why this is happening as this is only happening on iOS

@kubabutkiewicz kubabutkiewicz mentioned this issue Oct 8, 2024
50 tasks
@kubabutkiewicz
Copy link
Contributor

kubabutkiewicz commented Oct 8, 2024

@s77rt I created a PR for fixing this issue. It was actually happening on all platforms. Videos for android will be added later since I have some problems with building app after pulling latest main.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Oct 17, 2024
@melvin-bot melvin-bot bot changed the title [$250] iOS - IOU - The details of a single IOU are not displayed until you scroll up [HOLD for payment 2024-10-24] [$250] iOS - IOU - The details of a single IOU are not displayed until you scroll up Oct 17, 2024
Copy link

melvin-bot bot commented Oct 17, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Oct 17, 2024
Copy link

melvin-bot bot commented Oct 17, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.49-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-10-24. 🎊

For reference, here are some details about the assignees on this issue:

  • @s77rt requires payment through NewDot Manual Requests
  • @kubabutkiewicz does not require payment (Contractor)

Copy link

melvin-bot bot commented Oct 17, 2024

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@s77rt] The PR that introduced the bug has been identified. Link to the PR:
  • [@s77rt] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
  • [@s77rt] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
  • [@s77rt] Determine if we should create a regression test for this bug.
  • [@s77rt] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
  • [@zanyrenney] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@s77rt
Copy link
Contributor

s77rt commented Oct 20, 2024

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Oct 23, 2024
@zanyrenney
Copy link
Contributor

payment summary

@s77rt requires payment through NewDot Manual Requests - please request $250 for this issue
@kubabutkiewicz does not require payment (Contractor) - no payment required.

@github-project-automation github-project-automation bot moved this from CRITICAL to Done in [#whatsnext] #quality Oct 24, 2024
@JmillsExpensify
Copy link

$250 approved for @s77rt

@tgolen
Copy link
Contributor

tgolen commented Oct 24, 2024

Reopening so @zanyrenney can complete the regression checklist. Can you please copy @s77rt's answers to the checklist and then finish it up?

@tgolen tgolen reopened this Oct 24, 2024
@zanyrenney
Copy link
Contributor

zanyrenney commented Oct 24, 2024

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

@zanyrenney
Copy link
Contributor

zanyrenney commented Oct 24, 2024

Ah, my understanding was the contributor does the checklist as there is no regression test here @tgolen as per this comment where they answered the questions. I've done it above now but I've always thought that was the case as their name is next to the checkboxes.

Copy link

melvin-bot bot commented Oct 24, 2024

Payment Summary

Upwork Job

  • Reviewer: @s77rt owed $250 via NewDot
  • Contributor: @kubabutkiewicz is from an agency-contributor and not due payment

BugZero Checklist (@zanyrenney)

  • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
  • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1826197658645316035/hired)
  • I have paid out the Upwork contracts or cancelled the ones that are incorrect
  • I have verified the payment summary above is correct

@zanyrenney
Copy link
Contributor

I added the checklist again above, and the payment summary is also above. I think we now are good to close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor
Projects
Status: Done
Development

No branches or pull requests

9 participants