[HOLD FOR PAYMENT 8-27-2024] [$250] Duplicate Review - Description selector is not displayed when reviewing duplicates

[isagoico]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: v9.0.18-6
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/cases/view/3106469

Issue reported by: Applause - Internal team
Slack conversation: N/A

Action Performed:

1. Navigate to a workspace chat
2. Create 2 duplicate expenses each with a different description
3. Navigate to one of the duplicates
4. Click on Review Duplicate
5. Click on "keep this one" on any

Expected Result:

The description selector should display for the user to select which description to keep

Actual Result:

Final confirmation is displayed in the review duplicates flow

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

duplicate.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0179eedf51d4e3a1bd
• Upwork Job ID: 1821950383873413098
• Last Price Increase: 2024-08-09
• Automatic offers:
• c3024 | Reviewer | 103528468
• dominictb | Contributor | 103528469

Issue Owner

Current Issue Owner: @nkuoch

[melvin-bot]

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[dominictb]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Final confirmation is displayed in the review duplicates flow

What is the root cause of that problem?

We don't not add the description field to change if the description is not empty:

App/src/libs/TransactionUtils/index.ts

Line 980 in bd70f28

if (allCommentsAreEqual || allCommentsExist || allCommentsAreEmpty) {

What changes do you think we should make in order to solve the problem?

We can remove allCommentsExist.

[trjExpensify]

CC: @pecanoro @kubabutkiewicz for vis!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0179eedf51d4e3a1bd

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @c3024 (External)

[JmillsExpensify]

@c3024 thoughts on the proposals so far?

[c3024]

@dominictb 's proposal here looks good!

🎀 👀 🎀 C+ Reviewed

[melvin-bot]

Triggered auto assignment to @nkuoch, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[JmillsExpensify]

@nkuoch Thoughts on @dominictb's proposal?

[melvin-bot]

@nkuoch, @slafortune, @c3024 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[slafortune]

Adding BZ again - I'll be out until 8/21

[melvin-bot]

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

📣 @c3024 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @dominictb 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[dominictb]

PR #47513 is ready

[alexpensify]

This was merged two days ago, waiting for automation here.

[slafortune]

@c3024 can you please complete the checklist?
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@c3024 ] The PR that introduced the bug has been identified. Link to the PR:
• [@c3024 ] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@c3024 ] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@c3024 ] Determine if we should create a regression test for this bug.
• [@c3024 ] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@slafortune ] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[slafortune]

@dominictb - Paid

[c3024]

• [@c3024 ] The PR that introduced the bug has been identified. Link to the PR: Feat/Dupe detection review fields #42503
• [@c3024 ] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: 6de32f9#r146001502
• [@c3024 ] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: No discussion was started because this could not have been identified earlier.
• [@c3024 ] Determine if we should create a regression test for this bug. Yes
• [@c3024 ] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

1. Navigate to a workspace chat
2. Create 2 duplicate expenses with all fields except description as same for the expenses
3. Navigate to one of the duplicates
4. Click on Review Duplicate
5. Click on "Keep this one" on one of the expenses
6. The description selector should display for the user to select which description to retain

[slafortune]

@c3024 Paid