[PAY 26th AUG][$250] Task - Mark down format is not copied from description system message with mark down

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.17-0
Reproducible in staging?: Y
Reproducible in production?: Y
https://expensify.testrail.io/index.php?/tests/view/4827111
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to any chat
3. Create a task
4. Go to task report
5. Click Description
6. Add some text with mark down and save it
7. Right click on the description system message > Copy to clipboard
8. Paste the content on the composer

Expected Result:

The copied content will include the mark down format

Actual Result:

The copied content does not include the mark down format

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6563184_1722936468104.bandicam_2024-08-06_17-23-51-787.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0145487b2d412d9680
• Upwork Job ID: 1823315195401604195
• Last Price Increase: 2024-08-13
• Automatic offers:
• etCoderDysto | Contributor | 103506286

Issue Owner

Current Issue Owner: @Ollyws

[melvin-bot]

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

We think that this bug might be related to #vip-vsp

[lanitochka17]

@jliexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[etCoderDysto]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Mark down format is not copied from description system message with mark down

What is the root cause of that problem?

getReportActionText is using Parser.htmlToText. Parser.htmlToText will convert the html to plain text and we will copy the plain text to the clipboard

App/src/libs/ReportActionsUtils.ts

Lines 1135 to 1140 in 290a9d9

	function getReportActionText(reportAction: PartialReportAction): string {
	const message = getReportActionMessage(reportAction);
	// Sometime html can be an empty string
	// eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing
	const text = (message?.html || message?.text) ?? '';
	return text ? Parser.htmlToText(text) : '';

And copy the content to clipboard here

App/src/pages/home/report/ContextMenu/ContextMenuActions.tsx

Lines 379 to 380 in 290a9d9

	const displayMessage = TaskUtils.getTaskReportActionMessage(reportAction).text;
	Clipboard.setString(displayMessage);

What changes do you think we should make in order to solve the problem?

Here, we should

• get text and html value from getTaskReportActionMessage
• then use setClipboardMessage instead of Clipboard.setString to convert the html to markdown and copy it to clipboard

const {text, html} = TaskUtils.getTaskReportActionMessage(reportAction);
const displayMessage = html ?? text;
setClipboardMessage(displayMessage);

What alternative solutions did you explore? (Optional)

We should use Parser.htmlToMarkdown instead of Parser.htmlToText in getReportActionText as Parser.htmlToMarkdown returns the markdown format of the html

App/src/libs/ReportActionsUtils.ts

Lines 1135 to 1140 in 290a9d9

	function getReportActionText(reportAction: PartialReportAction): string {
	const message = getReportActionMessage(reportAction);
	// Sometime html can be an empty string
	// eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing
	const text = (message?.html || message?.text) ?? '';
	return text ? Parser.htmlToText(text) : '';

[jliexpensify]

Asked in the channel here - we're de-prioritizing VSB bugs, but I think this might be good to fix. Will loop back with an update.

[jliexpensify]

No response, will bump DB tomorrow

[jliexpensify]

Bumped DB in thread

[jliexpensify]

Posted in #react-native channel - https://expensify.slack.com/archives/C06BDSWLDPB/p1723528668518179

Someone from SWM will take it

[etCoderDysto]

Hi @jliexpensify, I have a proposal if you would like to take a look at it

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0145487b2d412d9680

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws (External)

[jliexpensify]

@etCoderDysto thanks for your patience, we have decided that a Contributor can handle this. For context, markdown issues are primarily handled by an external agency but they have deemed that your proposal seems fine.

However, they have left some feedback:

cc @Ollyws when you review

[etCoderDysto]

Thanks @jliexpensify, I will make sure to find other system messages that use this case, and verify that this change won't cause a regression.

[Ollyws]

@etCoderDysto's proposal LGTM.
🎀👀🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @cristipaval, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

📣 @etCoderDysto 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[etCoderDysto]

@Ollyws PR is ready for review

[Ollyws]

This is due for payment monday but for some reason the automation isn't working.

[jliexpensify]

@Ollyws will manually adjust, thanks for the heads up. Any checklist needed?

[jliexpensify]

Payment Summary

• C: @etCoderDysto $250
• C+: @Ollyws $250 (ND payment)

Upwork job

[Ollyws]

We can add a regression test with these steps:

1. Go to staging.new.expensify.com
2. Go to any chat
3. Create a task
4. Go to task report
5. Click Description
6. Add some text with mark down and save it
7. Right click on the description system message > Copy to clipboard
8. Paste the content on the composer
9. Verify that the pasted system message contains the markdown

[Ollyws]

Requested in ND.

[jliexpensify]

Paid and job closed!

[JmillsExpensify]

$250 approved for @Ollyws