Workspace Role Admin is not translated it's hardcoded

[Santhosh-Sellavel]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Note: User should have a workspace, if not create one using the following steps

1. Click the FAB button
2. Select New Workspaces to create a one.

Action Performed:

1. Now, Go to Settings,
2. Go to Preferences
3. Select preferred language to Espanol
4. Go back to settings
5. Go to your workspace
6. Select People
7. Under Assignee user role Admin is not Translated

Expected Result:

Role Admin should be translated.

Actual Result:

Actually, it's not translated.

Workaround:

Can the user still use Expensify without this being fixed? Yes

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number:
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:

View all open jobs on Upwork

Proposal

Text Admin is hardcoded for the role here

App/src/pages/workspace/WorkspacePeoplePage.js

Lines 200 to 202 in 8b10c1c

	<Text style={[styles.peopleBadgeText]}>
	Admin
	</Text>

Straight forward, we should just replace the text Admin with {this.props.translate('common.admin')}

[MelvinBot]

Triggered auto assignment to @strepanier03 (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[parasharrajat]

Can't this be merged with #4666? is this justified to be a separate issue 🍁 ?(Not asking the issue creator) Usually, translations are added with code changes and bug fixes?

[strepanier03]

Passing on to Eng to make the call about merging it with the other GH linked in, just because it is two unique issues.

From screenshot in OP comment the issue is clear as are the reproduction steps.

[MelvinBot]

Triggered auto assignment to @alex-mechler (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[Santhosh-Sellavel]

I do find missing translation itself an issue. If someone else raised this issue or I didn't raise any other issues will there be a thought of merging. Just need some clarity.

[alex-mechler]

I think this is fine to be its own issue, however if there was other missing translations, I would group those all together in the same issue.

cc @strepanier03

[MelvinBot]

Triggered auto assignment to @kevinksullivan (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[MelvinBot]

Whoops! This issue is 2 days overdue. Let's get this updated quick!

[kevinksullivan]

@Santhosh-Sellavel posted

https://www.upwork.com/jobs/~01a314068865d84f39

[MelvinBot]

Triggered auto assignment to @thienlnam (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[thienlnam]

@Santhosh-Sellavel 🟢 on your proposal, could you please apply for the upwork job?

[Santhosh-Sellavel]

@thienlnam @kevinksullivan Applied for the job on Upwork.

[Santhosh-Sellavel]

@thienlnam
We missed translations for the module in es.js.

App/src/languages/es.js

Lines 544 to 556 in 95bf36d

	beneficialOwnersStep: {
	beneficialOwners: 'Beneficial Owners',
	additionalInformation: 'Additional Information',
	checkAllThatApply: '(check all that apply, otherwise leave blank)',
	iOwnMoreThan25Percent: 'I own more than 25% of ',
	someoneOwnsMoreThan25Percent: 'Somebody else owns more than 25% of ',
	additionalOwner: 'Additional Beneficial Owner',
	removeOwner: 'Remove this beneficial owner',
	addAnotherIndividual: 'Add another individual who owns more than 25% of ',
	agreement: 'Agreement:',
	termsAndConditions: 'terms and conditions',
	certifyTrueAndAccurate: 'I certify that the information provided is true and accurate',
	error: {

I don't know how to add screenshots for this, but if you share es translated copy I will update the file along with this PR. That should be enough!
Thanks

cc: @iwiznia

[Santhosh-Sellavel]

@thienlnam
We missed translations for the module in es.js.

App/src/languages/es.js

Lines 544 to 556 in 95bf36d

	beneficialOwnersStep: {
	beneficialOwners: 'Beneficial Owners',
	additionalInformation: 'Additional Information',
	checkAllThatApply: '(check all that apply, otherwise leave blank)',
	iOwnMoreThan25Percent: 'I own more than 25% of ',
	someoneOwnsMoreThan25Percent: 'Somebody else owns more than 25% of ',
	additionalOwner: 'Additional Beneficial Owner',
	removeOwner: 'Remove this beneficial owner',
	addAnotherIndividual: 'Add another individual who owns more than 25% of ',
	agreement: 'Agreement:',
	termsAndConditions: 'terms and conditions',
	certifyTrueAndAccurate: 'I certify that the information provided is true and accurate',
	error: {

I don't know how to add screenshots for this, but if you share es translated copy I will update the file along with this PR. That should be enough!
Thanks

cc: @iwiznia

Any update on translations for this.
@thienlnam

[thienlnam]

'Beneficial Owners' => Beneficiario efectivo,
'Additional Information' => Información adicional,
'(check all that apply, otherwise leave blank)' => (marca todos los que apliquen, en caso de que ninguno aplique dejar en blanco),
'I own more than 25% of ' => Soy dueño de mas de 25% de,
'Somebody else owns more than 25% of ' => Otra persona es dueña de mas de 25% de,
'Additional Beneficial Owner',
'Remove this beneficial owner',
'Add another individual who owns more than 25% of ' => Agregar otra persona que es dueña de mas de 25% de,
'Agreement:' => Acuerdo,
'terms and conditions' => Términos y condiciones,
'I certify that the information provided is true and accurate' => Certifico que la información dada es correcta,

(Will update with missing ones soon)

[Santhosh-Sellavel]

Let me know after update thanks! @thienlnam

[equationalapplications]

Proposal:

App/src/pages/workspace/WorkspacePeoplePage.js

Lines 199 to 203 in 1803120

	<View style={[styles.badge, styles.peopleBadge]}>
	<Text style={[styles.peopleBadgeText]}>
	Admin
	</Text>
	</View>

Line 201 is where the word "Admin" is hard coded as text. Instead, we replace this line with
{this.props.translate('common.admin')}
so that the translate method can retrieve the translated phrase from the language files.

[thienlnam]

@equationalapplications Thanks for the proposal but we already have another contributor working on this issue already. Issues tagged with 'Help Wanted' will be needing contributors, and a good place to start!

[thienlnam]

@Santhosh-Sellavel I'm still waiting to hear back on the last couple translations but will update you when I get them

[thienlnam]

Got the rest of them @Santhosh-Sellavel!

'Additional Beneficial Owner' -> Beneficiario efectivo adicional
'Remove this beneficial owner' -> Eliminar este beneficiario efectivo

[Santhosh-Sellavel]

@thienlnam Will send a PR Shortly...

[Santhosh-Sellavel]

@thienlnam here you said

'Agreement:' => Acuerdo,

It should be Acuerdo: right?

[thienlnam]

It should be Acuerdo: right?

Yup, it should be - good catch

[Santhosh-Sellavel]

@thienlnam PR is ready!

[thienlnam]

Payment should be issued today since it doesn't appear to have caused any regressions

[kevinksullivan]

Paid with bonus @Santhosh-Sellavel . Thanks!