Skip to content

Workspace admin user is selectable to remove. #4666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Santhosh-Sellavel opened this issue Aug 14, 2021 · 16 comments
Closed

Workspace admin user is selectable to remove. #4666

Santhosh-Sellavel opened this issue Aug 14, 2021 · 16 comments
Assignees
Labels
Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Improvement Item broken or needs improvement. Weekly KSv2

Comments

@Santhosh-Sellavel
Copy link
Collaborator

Santhosh-Sellavel commented Aug 14, 2021

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Note: User should have a workspace, if not create one using the following steps

  1. Click the FAB button (➕ Icon),
  2. Select New Workspaces to create a one.

Action Performed:

  1. Now, Go to Settings,
  2. Go to your workspace
  3. Select People
  4. Try to select your email
  5. After selecting, the Remove Button is enabled
  6. Click Remove -> A confirm modal
  7. Confirm Remove -> But Nothing happens, or no error shown

Expected Result:

Admin option should not removable.
Since there is only a remove action, after user selection. Admin option should not selectable.

Actual Result:

Able to select admin user and to click remove. Even after confirmation remove. Nothing happens or no error is shown.

Simulator.Screen.Recording.-.iPhone.12.-.2021-08-15.at.00.33.21.mp4

Workaround:

Can the user still use Expensify without this being fixed? Yes

Platform:

Where is this issue occurring? All platforms

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number:
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:

View all open jobs on Upwork

Suggestion

If we are planning more options the context to do after user selection. Then if the admin user is selected on clicking remove we should straight show please unselect admin user from selection, the admin user cannot be removed, it would help if other users also selected along with admin.

Proposal

I will work on it, post a discussion with the team.

view the job on upwork

@Santhosh-Sellavel Santhosh-Sellavel added AutoAssignerTriage Auto assign issues for triage to an available triage team member Daily KSv2 labels Aug 14, 2021
@MelvinBot
Copy link

Triggered auto assignment to @sophiepintoraetz (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

@MelvinBot MelvinBot removed the AutoAssignerTriage Auto assign issues for triage to an available triage team member label Aug 14, 2021
@sophiepintoraetz
Copy link
Contributor

Hey @Santhosh-Sellavel - can you confirm a couple of things for me please:

  1. What does FAB stand for in Click the FAB button?
  2. Which platforms is this occurring on; just mobile or web or all of the above?
  3. Since there is only a remove action, after user selection. Admin option should not selectable. Can you confirm whether the actual expected result is that the Admin should be removed or that the admin should be be able to be selected?

@kakajann
Copy link
Contributor

FAB stands for Floating Action Button and mostly used in Material UI

@Santhosh-Sellavel
Copy link
Collaborator Author

Santhosh-Sellavel commented Aug 16, 2021

Hey @Santhosh-Sellavel - can you confirm a couple of things for me please:

  1. What does FAB stand for in Click the FAB button?

Floating Action Button - ( ➕ icon)

  1. Which platforms is this occurring on; just mobile or web or all of the above?

Updated, its occuring in all the platforms

  1. Since there is only a remove action, after user selection. Admin option should not selectable. Can you confirm whether the actual expected result is that the Admin should be removed or that the admin should be be able to be selected?
  1. Admin should not be removed.
  2. So we should not be able to select admin for removing. Else after selection while clicking remove button, We should alert the user that admin can't be removed.

@sophiepintoraetz

@MelvinBot
Copy link

Triggered auto assignment to @Jag96 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@sophiepintoraetz sophiepintoraetz added Improvement Item broken or needs improvement. and removed Daily KSv2 labels Aug 16, 2021
@sophiepintoraetz sophiepintoraetz removed their assignment Aug 16, 2021
@Jag96 Jag96 added the External Added to denote the issue can be worked on by a contributor label Aug 17, 2021
@MelvinBot MelvinBot added Daily KSv2 and removed Weekly KSv2 labels Aug 17, 2021
@Jag96 Jag96 removed their assignment Aug 17, 2021
@Jag96 Jag96 added External Added to denote the issue can be worked on by a contributor and removed External Added to denote the issue can be worked on by a contributor labels Aug 17, 2021
@MelvinBot
Copy link

Triggered auto assignment to @jboniface (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@jboniface
Copy link

busy with other stuff, will post the job tomorrow hopefully

@jboniface
Copy link

view the job on upwork

@jboniface
Copy link

note to self, if santosh's proposal is accepted, we should pay a bonus for it since santosh filed the issue

@jboniface
Copy link

@Santhosh-Sellavel please post a formal proposal here when you have it and also submit to the job on upwork

@jboniface jboniface added Exported and removed Daily KSv2 labels Aug 20, 2021
@jboniface jboniface added the Weekly KSv2 label Aug 20, 2021
@MelvinBot MelvinBot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Aug 20, 2021
@MelvinBot
Copy link

Triggered auto assignment to @marcaaron (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@Santhosh-Sellavel
Copy link
Collaborator Author

Santhosh-Sellavel commented Aug 20, 2021

@jboniface @marcaaron

What can we do here I need input from you guys. Because I suggested two solutions.
Can we make the admin not selectable or show an error when the user clicks the remove button while the admin user is selected?

Based on the input, I'll propose a technical solution.

@marcaaron
Copy link
Contributor

Hmm this feels like a very low value fix and I don't think this it's a priority right now. I honestly don't have time to review proposals or code for things like this so I'm just going to close it. Sorry!

@Jag96 or @jboniface lmk if you feel differently and maybe we can make it a monthly 🤷‍♂️

@Santhosh-Sellavel
Copy link
Collaborator Author

Don't take it the wrong way, I do understand that team has internal priority items hooked for two/three weeks from last week.
But straight away closing the issues after being exported really hurts

@marcaaron
Copy link
Contributor

Sorry! Thanks for understanding!

@konslyp
Copy link

konslyp commented Aug 20, 2021

I saw project on upwork. this is still available for submit proposal or already hired someone?

@Expensify Expensify locked as resolved and limited conversation to collaborators Aug 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Improvement Item broken or needs improvement. Weekly KSv2
Projects
None yet
Development

No branches or pull requests

8 participants