-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Workspace admin user is selectable to remove. #4666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Triggered auto assignment to @sophiepintoraetz ( |
Hey @Santhosh-Sellavel - can you confirm a couple of things for me please:
|
FAB stands for Floating Action Button and mostly used in Material UI |
Floating Action Button - ( ➕ icon)
Updated, its occuring in all the platforms
|
Triggered auto assignment to @Jag96 ( |
Triggered auto assignment to @jboniface ( |
busy with other stuff, will post the job tomorrow hopefully |
note to self, if santosh's proposal is accepted, we should pay a bonus for it since santosh filed the issue |
@Santhosh-Sellavel please post a formal proposal here when you have it and also submit to the job on upwork |
Triggered auto assignment to @marcaaron ( |
What can we do here I need input from you guys. Because I suggested two solutions. Based on the input, I'll propose a technical solution. |
Hmm this feels like a very low value fix and I don't think this it's a priority right now. I honestly don't have time to review proposals or code for things like this so I'm just going to close it. Sorry! @Jag96 or @jboniface lmk if you feel differently and maybe we can make it a monthly 🤷♂️ |
Don't take it the wrong way, I do understand that team has internal priority items hooked for two/three weeks from last week. |
Sorry! Thanks for understanding! |
I saw project on upwork. this is still available for submit proposal or already hired someone? |
Uh oh!
There was an error while loading. Please reload this page.
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Note: User should have a workspace, if not create one using the following steps
Action Performed:
Remove
Button is enabledExpected Result:
Admin option should not removable.
Since there is only a remove action, after user selection. Admin option should not selectable.
Actual Result:
Able to select admin user and to click remove. Even after confirmation remove. Nothing happens or no error is shown.
Simulator.Screen.Recording.-.iPhone.12.-.2021-08-15.at.00.33.21.mp4
Workaround:
Can the user still use Expensify without this being fixed? Yes
Platform:
Where is this issue occurring? All platforms
Version Number:
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
View all open jobs on Upwork
Suggestion
If we are planning more options the context to do after user selection. Then if the admin user is selected on clicking remove we should straight show
please unselect admin user from selection, the admin user cannot be removed
, it would help if other users also selected along with admin.Proposal
I will work on it, post a discussion with the team.
view the job on upwork
The text was updated successfully, but these errors were encountered: