[YAUHENI - CHECKLIST][$250] Chat - Chat not scrolled to bottom when returned from thread and send a message

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.13-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4766826&group_by=cases:section_id&group_order=asc&group_id=306202
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause - Internal Team

Action Performed:

Precondition: user should be Signed In with [email protected]
account

1. Open app
2. Navigate to chat with [email protected]
3. Scroll up the chat
4. Navigate to any thread for any message in the chat
5. Click on the "From" link in header to navigate back to the main chat
6. Send any message

Expected Result:

Chat should be scrolled to the bottom when user send a message to the chat

Actual Result:

"New message" button displayed and chat remains on the same position

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6553078_1721940541808.Screen_Recording_2024-07-25_at_23.36.21.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~018faeb9106bd08688
• Upwork Job ID: 1817743200562670608
• Last Price Increase: 2024-07-29
• Automatic offers:
• ZhenjaHorbach | Reviewer | 103368524

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @jliexpensify

[melvin-bot]

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Chat doesn't scroll to bottom after coming back from thread using the parent link.

What is the root cause of that problem?

When we add the message, it will only scroll to the bottom if hasNewestReportActionRef is true.

App/src/pages/home/report/ReportActionsList.tsx

Lines 350 to 356 in 5e65276

	const scrollToBottomForCurrentUserAction = useCallback(
	(isFromCurrentUser: boolean) => {
	// If a new comment is added and it's from the current user scroll to the bottom otherwise leave the user positioned where
	// they are now in the list.
	if (!isFromCurrentUser || !hasNewestReportActionRef.current) {
	return;
	}

However, in our case, hasNewestReportActionRef is false. When we link to a message, the component will take the report actions only up to the current linked action + 50 actions (pagination size).

App/src/pages/home/report/ReportActionsView.tsx

Lines 255 to 256 in 5e65276

	const paginationSize = getInitialPaginationSize;
	return combinedReportActions.slice(Math.max(indexOfLinkedAction - paginationSize, 0));

So, if the message that we linked is very far above, then the scroll to bottom does nothing.

What changes do you think we should make in order to solve the problem?

We can use the same solution with scroll to bottom by clicking the "New message" here which removes the linked action param so all the report actions are loaded.

App/src/pages/home/report/ReportActionsList.tsx

Lines 415 to 423 in 5e65276

	const scrollToBottomAndMarkReportAsRead = () => {
	if (!hasNewestReportAction) {
	Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(report.reportID));
	Report.openReport(report.reportID);
	return;
	}
	reportScrollManager.scrollToBottom();
	readActionSkipped.current = false;
	Report.readNewestAction(report.reportID);

if (!hasNewestReportActionRef.current) {
    Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(report.reportID));
}
InteractionManager.runAfterInteractions(() => reportScrollManager.scrollToBottom());

[jliexpensify]

Hi @bernhardoj - are you repro-ing this issue with your own account? If it's affecting 1 specific account, we probably don't need to fix it, but if it's affecting other accounts, we should.

I haven't been able to repro on my own test account.

[bernhardoj]

@jliexpensify yes, I can repro it. The issue doesn't depend on the account. To repro the issue, you need to link to the >= 52nd message (you can count it on the video too). For example, if you send 1,2,3,4,...100 to the chat, then you can copy the link of 40 and open it. This is due to pagination logic that only includes the current linked message + 50 messages below (40 + 50 = 90, 91-100 isn't included).

[jliexpensify]

Oh interesting, thanks for that info!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~018faeb9106bd08688

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ZhenjaHorbach (External)

[ZhenjaHorbach]

@bernhardoj
Thanks for your proposal
Your proposal makes sense to me and also fixes the issue !

🎀👀🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @hayata-suenaga, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

@jliexpensify, @ZhenjaHorbach, @hayata-suenaga Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

Current assignee @ZhenjaHorbach is eligible for the External assigner, not assigning anyone new.

[jliexpensify]

Hayata is no longer with us, removing him.

[ZhenjaHorbach]

In that case, let's try again

@bernhardoj Thanks for your proposal Your proposal makes sense to me and also fixes the issue !

🎀👀🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @MonilBhavsar, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[MonilBhavsar]

looks good to me 👍

[melvin-bot]

📣 @ZhenjaHorbach 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[bernhardoj]

PR is ready

cc: @ZhenjaHorbach

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

This issue has not been updated in over 15 days. @jliexpensify, @MonilBhavsar, @bernhardoj, @ZhenjaHorbach eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[MonilBhavsar]

The PR was deployed to production. We can issue the payment here

[jliexpensify]

Thanks @MonilBhavsar!

Payment Summary

• C: @bernhardoj $250 (ND payment)
• C+: @ZhenjaHorbach $250 - Do we need a checklist?

Upwork job

[jliexpensify]

Paid and job closed, waiting on checklist

[bernhardoj]

Requested in ND.

[MonilBhavsar]

@jliexpensify Yes, we need a checklist here cc @ZhenjaHorbach

[ZhenjaHorbach]

I will add checklist today or tomorrow !

[ZhenjaHorbach]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@ZhenjaHorbach] The PR that introduced the bug has been identified. Link to the PR:

I couldn't find a specific PR related to this issuee.
Plus the goal of this PR was to implement logic similar to the one used when clicking the "New messages" button.

• [@ZhenjaHorbach] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

NA

• [@ZhenjaHorbach] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

NA

• [@ZhenjaHorbach] Determine if we should create a regression test for this bug.
• [@ZhenjaHorbach] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

• Send or open a chat with a lot messages (For example more than 60 messages)
• Right-click/long-press on the first message and Reply in thread
• Press the "From..." link to go back to the main chat
• Send a message
• Verify the chat is scrolled to the bottom

Do we agree 👍 or 👎

[JmillsExpensify]

$250 approved for @bernhardoj