[PAID][$250] QBO - Main and sub tags disappear after renaming main tag with same name as other main tag

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.13-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

Precondition:

• Workspace is connected to QBO
• Multi tags are imported from QBO

1. Go to staging.new.expensify.com
2. Go to workspace settings > Tags
3. Click on any main tag
4. Click on the name field
5. Enter the same main tag name as the other main tag and save it

Expected Result:

App will throw an error that the existing name has already been used

Actual Result:

App does not throw an error. The other main tag together with the sub tags disappears and the sub tags become standard tags (no longer multi tags)

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6552852_1721924678094.20240726_001940.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~010ff59768d2accba6
• Upwork Job ID: 1818882074670225826
• Last Price Increase: 2024-08-08

Issue Owner

Current Issue Owner: @strepanier03

[melvin-bot]

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

We think that this bug might be related to #wave-collect - Release 1

[lanitochka17]

@strepanier03 FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[melvin-bot]

@strepanier03 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@strepanier03 Huh... This is 4 days overdue. Who can take care of this?

[strepanier03]

Tested this today and the tag list functions as described in the OP comment. Able to repro easily.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~010ff59768d2accba6

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws (External)

[strepanier03]

I'm not sure if this external but we can update the label if needed.

[daledah]

Edited by proposal-police: This proposal was edited at 2023-10-10 21:05:46.

Proposal

Please re-state the problem that we are trying to solve in this issue.

App does not throw an error. The other main tag together with the sub tags disappears and the sub tags become standard tags (no longer multi tags)

What is the root cause of that problem?

In

App/src/pages/workspace/tags/WorkspaceEditTagsPage.tsx

Line 44 in d69b203

}

, there's no validation for duplicate tag list name.

So the user is able to save the Tag list name with duplicate name, this is the root cause of the issue.

What changes do you think we should make in order to solve the problem?

In

App/src/pages/workspace/tags/WorkspaceEditTagsPage.tsx

Line 44 in d69b203

}

, add validation for duplicate tag list name.

So first we have the list of tag from Object.values(policyTagList), then we need to filter out all tag that have different orderWeight from the tag we're editing, we can filter out the tags based on having different orderWeight from route.params.orderWeight

Now we get their name attribute of them, and if values[INPUT_IDS.POLICY_TAGS_NAME] here does not match any of that name, return an error like This name is already in use, please select another name

Sample code to add in

App/src/pages/workspace/tags/WorkspaceEditTagsPage.tsx

Line 44 in d69b203

}

if (Object.values(policyTags).find((tag) => tag.orderWeight !== route.params.orderWeight && tag.name === values[INPUT_IDS.POLICY_TAGS_NAME])) {
    errors[INPUT_IDS.POLICY_TAGS_NAME] = translate('workspace.tags.existingTagError');
}

policyTags needs to be added in dependency list here. We can trim (& maybe lowercase) both name value before comparing if needed. The error text copy can be adjusted if needed.

We could optionally update the RenamePolicyTaglist back-end API to validate this too, but front-end validation should already be enough to prevent users from encountering this issue.

What alternative solutions did you explore? (Optional)

[daledah]

Proposal edited to add sample code

[Ollyws]

Should this not be validated on the backend by the RenamePolicyTaglist request?

[melvin-bot]

@strepanier03, @Ollyws Whoops! This issue is 2 days overdue. Let's get this updated quick!

[daledah]

Should this not be validated on the backend by the RenamePolicyTaglist request?

@Ollyws It should ideally be validated in back-end too. But we'll need to validate it in the front-end regardless. I've updated the proposal to mention the optional back-end fix

[melvin-bot]

@strepanier03, @Ollyws Huh... This is 4 days overdue. Who can take care of this?

[Ollyws]

Yes I agree that we should do both, will get to this asap.

[Ollyws]

@strepanier03 Could we assign an internal engineer here? It will need some backend work but we should possibly do some validation on the front-end too. Thanks!

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[daledah]

@Ollyws This PR is ready for review.

[Ollyws]

This is due for payment monday but for some reason the automation isn't working.

[melvin-bot]

@rlinoz @strepanier03 @Ollyws @daledah this issue is now 4 weeks old, please consider:

• Finding a contributor to fix the bug
• Closing the issue if BZ has been unable to add the issue to a VIP or Wave project
• If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

[Ollyws]

We should create a regression test with the following steps:

Precondition:
Workspace is connected to QBO
Multi tags are imported from QBO

1. Go to Workspace Settings > Tags
2. Click on any main tag
3. Click on the name field
4. Enter the same main tag name as the other main tag and save it
5. Verify that: Error appears instead of renaming successfully

[Ollyws]

Requested in ND. @strepanier03 Could we get a payment summary? Thanks!

[garrettmknight]

@strepanier03 mind popping the payment summary in here when you get a chance?

[strepanier03]

Aaah, missed this one with the failed automation. Sorry about that everyone.

Doing the payment summary now.

[strepanier03]

Payment Summary

• $250 - @Ollyws via New Expensify manual request
• $250 - @daledah via Upwork - Please apply for the job here or share your Upwork profile with me so I can hire you.

@garrettmknight - All your's!

[strepanier03]

I'll check later this afternoon for the Upwork job.

[garrettmknight]

$250 approved for @Ollyws

[strepanier03]

@daledah - Bump on sharing your Upwork profile with me or applying for the job. Thanks!

[daledah]

@strepanier03 Here's my profile https://www.upwork.com/freelancers/~0138d999529f34d33f, could you help send the offer? Thx

[strepanier03]

@daledah - I've just sent over the offer.

[daledah]

@strepanier03 I accepted it 🙏

[strepanier03]

Finishing up now.

[strepanier03]

Paid and closed the contract, thanks everyone!