-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Add Tooltips to all non-text actions/buttons in New Expensify #4499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Triggered auto assignment to @zanyrenney ( |
Proposal Enclose all the action items with For example, download button would require changes In HeaderWithCloseButton, downloadButton block would look like:
and translations would be as followed:
|
Triggered auto assignment to @ctkochan22 ( |
sorry @ctkochan22 accidentally unassigned you so reassigned |
Triggered auto assignment to @michaelhaxhiu ( |
Triggered auto assignment to @michelle-thompson ( |
Sorry on the delay! Let's get quick input from Design, since this will be a UI theme that's widespread in New Expensify. |
Makes sense to me. |
Do we want to use the same UI theme as WhatsApp? Or do we want a specific spacing, font, and tooltip box? |
@parasharrajat I've fixed the broken pointer. I also checked the |
Thanks for attempting to fix the placement of the floating tooltips that @parasharrajat brought up! I am having a hard time seeing the how the tooltip placement changed in the Profile picture example. Did it move it up a few pixels? |
No, it isn't changed from my previous commit. But what is happening is that tooltip is showing on the |
I meant to point out that Edit Profile tooltip should be over or below the pencil icon instead of profile avatar. Another issue which I faced was that after tooltip is visible and you click edit ✏️, tooltip never goes away. |
@parasharrajat That is what I had tried earlier. The pencil icon is absolute positioned and with the existing tooltip behavior, I haven't been able to position the tooltip properly on the icon. |
Now I follow you 👌. The tooltip for the profile picture should probably show under the pencil. Right @shawnborton? |
Can it launch directly above the gray circle that has the pencil icon? |
At the moment, our Tooltip doesn't work well with Hence, we skipped the FAB too. |
Then I would just skip this one yeah? |
Can do. @michaelhaxhiu @iwiznia What do you think? |
I am fine skipping for now |
Agree, let's skip showing this tooltip for now. We can revisit this later. Thanks for bringing it up @parasharrajat |
PR Raised |
🚀 Deployed to production by @roryabraham in version: 1.0.90-2 🚀
|
@roryabraham quick bud check -- this botify chart makes me believe that iOS isn't ready for deploy, which means we shouldn't start the 7 day payment countdown? Is that accurate? I'd like to make sure I understand for future cases. |
@michaelhaxhiu @roryabraham fyi, this PR primarily has an impact on Desktop and Web. |
Yep understood as this relates to tooltips that appear upon mouse hover over - that's why I'm a little bit unsure how to handle the botify error concerning iOS (i.e. does it matter)? |
Sorry for the delayed reply and red-herring comment. That failed iOS prod deploy happened completely independently of this issue, and was completed manually after-the-fact. So I think that this has been solved on prod for more than a week at this point and can be paid/closed out. Thanks! |
Paid! |
Uh oh!
There was an error while loading. Please reload this page.
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Action Performed:
This has to be handled at multiple places such as Workspace Image Picker, Profile Picture Image Picker, etc.
Expected Result:
This is how Whatsapp shows

Actual Result:
Shows no tooltip/text right now. Only icons.
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platform:
Where is this issue occurring?
Version Number:
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Upwork job link: https://www.upwork.com/ab/applicants/1426188061929398272/job-details
View all open jobs on Upwork
The text was updated successfully, but these errors were encountered: