[HOLD for payment] "No results found" message is missing when there're no search results for New Chat/New Group/Main Search

[aman-atg]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Login to e.cash
2. Open Main Search / New Chat / New Group
3. Type random word so that there're no search results

Expected Result:

Actual Result:

Workaround:

Visual Issue

Platform:

• [:heavy_check_mark: ] Web
• [ ✔️ ] iOS
• [:heavy_check_mark: ] Android
• [:heavy_check_mark: ] Desktop App
• [:heavy_check_mark: ] Mobile Web

Version Number:
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:

View all open jobs on Upwork

[MelvinBot]

Triggered auto assignment to @NicMendonca (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[aman-atg]

Proposal :

App/src/libs/OptionsListUtils.js

Lines 667 to 685 in 9b1ea35

	function getHeaderMessage(hasSelectableOptions, hasUserToInvite, searchValue, maxParticipantsReached = false) {
	if (maxParticipantsReached) {
	return translate(preferredLocale, 'messages.maxParticipantsReached');
	}
	if (searchValue && CONST.REGEX.DIGITS_AND_PLUS.test(searchValue) && !Str.isValidPhone(searchValue)) {
	return translate(preferredLocale, 'messages.noPhoneNumber');
	}
	if (!hasSelectableOptions && !hasUserToInvite) {
	if (/^\d+$/.test(searchValue)) {
	return translate(preferredLocale, 'messages.noPhoneNumber');
	}
	return searchValue;
	}
	return '';
	}

• We're returning searchValue on line 681 instead of that we can use a different message like:
  • No results found
  • No users found
  • Please enter a valid email address
  • or any other message

[MelvinBot]

Triggered auto assignment to @Beamanator (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[Beamanator]

Thanks @aman-atg but this is technically working as expected. The search is waiting until you type a valid email address, then it will allow you to start a new chat with the email address you typed. We're working on some improvements in #2936 which should cover this case. When that solution gets merged, please feel free to test and let us know if it looks good or if you think it should change 👍 I'll close this for now.

[aman-atg]

@Beamanator
Maybe we can open this issue now. And close the dupe: #4677

I'll update the proposal.

[Beamanator]

Good idea @aman-atg 👍 It looks like this was discussed in #expensify-open-source and people decided it would be nice to have a message like "No results found" instead of just coping whatever is in the text field - I didn't close #4677 yet, asking there if they agree it should be closed.

[MelvinBot]

Triggered auto assignment to @puneetlath (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[Santhosh-Sellavel]

@aman-atg do you really want to edit your (#4163 (comment)) older proposal with what I proposed here #4677 (comment) yesterday.

cc: @Beamanator

[Beamanator]

Wow I didn't notice that, thanks for bringing that to my attention @Santhosh-Sellavel

[Beamanator]

@Santhosh-Sellavel will you please add your original proposal to this issue so we can move forward with your idea? 👍

[Santhosh-Sellavel]

@Beamanator Can we just close this move it forward there #4677

[Santhosh-Sellavel]

Here it is @Beamanator

Proposal

Simple returning searchValue is the problem here, if we remove it problem solved.

Instead, we could return the appropriate message if needed.

[aman-atg]

@Santhosh-Sellavel Sorry, If you felt that way but I didn't really saw your proposal before updating mine.
The problem was already known to me and it was a simple fix.
@Beamanator you can check the proposal history and the issue description that solution was already there. Only the location changed as new PRs were merged.

#4163

"No results found" message is missing when there're no search results for New Chat/New Group/Main Search

It's in the title as well.

[Beamanator]

Thanks for the discussion @aman-atg and @Santhosh-Sellavel , let's remember to keep our conversations respectful at all times :)

@aman-atg Thanks for explaining your situation. I am going to move forward with another proposal. Your previous proposed solution may have been best at the time it was proposed, but we didn't move forward fixing the issue at the time. Your new proposal is good, but since it was very similar to a proposal that someone posted ~ 3 to 4 hours before you, I believe it's only fair to move forward with the other proposal. Please feel free to reach out to me in NewDot if you have questions.

@Santhosh-Sellavel Let's move forward with your proposal. I think we should work from this issue since this is the original reporting of the issue, can you please let me know why you prefer to move forward in the other issue?

[aman-atg]

@Beamanator

I am going to move forward with another proposal

That's fine. But I just wanted to clarify that the proposed solution, a different message, was already posted here days ago.

[Beamanator]

Thanks @dylanexpensify ! Just to quickly catch you up - this job has already been finished 😅 I merged @Santhosh-Sellavel 's code this morning, so @Santhosh-Sellavel can you let @dylanexpensify know when you apply so he can hire you?

[Santhosh-Sellavel]

Applied! @dylanexpensify

[dylanexpensify]

Hired @Santhosh-Sellavel ! 😄

[Beamanator]

Putting on hold for payment so it's clear what the current status is & so it's clear on my todo list :D

[MelvinBot]

@Beamanator, @Santhosh-Sellavel Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[Beamanator]

@dylanexpensify assigning you since Puneet unassigned himself - seems your takeover is official! 😅

[dylanexpensify]

Sounds good!

[aman-atg]

Hi @Beamanator, Can you please clarify if a bonus will be paid for this issue as it was reported by me?

[Beamanator]

Good question @aman-atg - as @mallenexpensify posted in #expensify-open-source here:

This change is in effect as of yesterday and the bonus for independently reporting an issue is only valid from yesterday forward. If there are existing, open, GH issues that you believe you should be compensated for reporting a bug, please comment in the issue.

[aman-atg]

Thanks for clarifying.

[mallenexpensify]

Actually... since this issue is still open and because @aman-atg has contributed to the issue, I think they should be paid. @aman-atg can you apply for the job here https://www.upwork.com/jobs/~0186891d4078a90470
@dylanexpensify when you pay @Santhosh-Sellavel for the job can you also pay @aman-atg $250 for reporting the issue, and confirm with a post in this issue that both have been paid? Thx

[arielgreen]

@Santhosh-Sellavel this is paid, thanks :)

@aman-atg once you accept the offer in Upwork, I'll issue the bonus payment.

[arielgreen]

Paid Aman, closing this out.