[Due for payment 2025-03-03] [$500] Connect Bank - Page loads infinitely when clicking back button on "Continue on your phone" page

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.69-0
Reproducible in staging?: Y
Reproducible in production?: Y
Found when executing PR : #40402
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace settings.
3. Go to Workflows.
4. Go to Connect bank account.
5. Click Connect manually.
6. On Personal information, enter "First" and "Last" as first name and last name respectively.
7. Proceed to Onfido flow.
8. Accept the terms.
9. On "Continue on your phone" page, click on the blue back button.

Expected Result:

App returns to previous page.

Actual Result:

The page loads infinitely.
On mweb, the back button is not responsive.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6467589_1714550806295.20240501_160104.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~013867ab061a360e2f
• Upwork Job ID: 1792533118121684992
• Last Price Increase: 2025-01-07

Issue Owner

Current Issue Owner: @RachCHopkins

[melvin-bot]

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[izarutskaya]

We think this issue might be related to the #collect project.

[melvin-bot]

@muttmuure Eep! 4 days overdue now. Issues have feelings too...

[muttmuure]

I think this might be a site slow problem

[muttmuure]

Can we retest this? I'm not sure it is still happening

[melvin-bot]

@muttmuure this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~013867ab061a360e2f

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

[muttmuure]

I can reproduce this

[muttmuure]

[tienifr]

Seems like the same issue outlined here but useMemoryHistory was deprecated in version 14.15.0. Their source code is packaged and minified so I couldn't take a look. I think we need to file a bug to them.

[eVoloshchak]

Can reproduce the bug on staging

I agree with @tienifr, this is a bug in onfido lib, let's file a bug to them.
@muttmuure, do we have a process for that?

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@eVoloshchak, @muttmuure Huh... This is 4 days overdue. Who can take care of this?

[eVoloshchak]

@muttmuure, what is your opinion on #41398 (comment)?

[melvin-bot]

Current assignee @muttmuure is eligible for the Bug assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to @RachCHopkins (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.4-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Upgraded onfido-sdk-ui to v14.42.0 #56940

If no regressions arise, payment will be issued on 2025-03-03. 🎊

For reference, here are some details about the assignees on this issue:

• @eVoloshchak requires payment through NewDot Manual Requests
• @shubham1206agra requires payment through NewDot Manual Requests

[melvin-bot]

@eVoloshchak / @shubham1206agra @RachCHopkins @eVoloshchak / @shubham1206agra The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[RachCHopkins]

@eVoloshchak, do you mind completing the checklist, please?

[eVoloshchak]

This comment summarizes the issue best: #41398 (comment)

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other: Bug in a third-party package (onfido-sdk-ui)

Where bug was reported:

• 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
• 2b. Reported on staging (eg. found during regression or PR testing)
• 2d. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment: N/A

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion: regression was not critical

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

Regression Test Proposal Template

• [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

  Link to issue:

Regression Test Proposal

• Is it easy to test for this bug? Yes
• Is the bug related to an important user flow? Yes
• Is it an impactful bug? Yes

Test:

1. Go to Settings -> Workspaces
2. Select any workspace
3. Go to Workflows.
4. Go to Connect bank account.
5. Click Connect manually.
6. On the Personal information page, enter first name and last name.
7. Proceed to Onfido flow.
8. Accept the terms.
9. On "Continue on your phone" page, verify that there is no blue back button present.

Do we agree 👍 or 👎

[RachCHopkins]

Payment Summary:

• Contributor: @shubham1206agra to be paid $500 via Newdot Manual Request
• Contributor+: @eVoloshchak to be paid $500 via Newdot Manual Request

Upwork job here

[RachCHopkins]

No Contributors to pay via Upwork, no contracts to complete, and the Upwork post has been closed.

[garrettmknight]

$500 approved for @shubham1206agra