Skip to content

[HOLD for payment 2024-05-09] [$250] [Guided Setup Stage 2] Rename the Track and budget personal spend to Track and budget expenses #41350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
danielrvidal opened this issue Apr 30, 2024 · 28 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 External Added to denote the issue can be worked on by a contributor

Comments

@danielrvidal
Copy link
Contributor

danielrvidal commented Apr 30, 2024

Problem: We’re embracing Track as being a critical flow for new users to Try New Expensify, both for the earnings call and in general. Pushing someone down the Submit flow too early forces them to share the product before they have tried it themselves. Currently, Track is either promoting a sole proprietor case OR personal use, which means employees likely will not choose it. Additionally, if people select Track for business, we automatically create a workspace for them to use with their account. This is problematic if an employee selects that and then doesn’t undergo the bottom-up like submitting to an employer.

Solution: Update the onboarding options to make Track the most logical thing for both sole props and Employees to select. @zsgreenwald is already planning on making similar updates, but we need to fast-track these updates to support our release. Thus we need to do the following asap:

  1. Rename the Track and budget personal spend in the onboarding flow to Track and budget expenses
  • Expensify DM/tasks already work for this case. Bottom-up already works.
  1. Remove Track business spend for taxes as an option.
  • This removes us from creating a workspace in any Track flows.
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01d70e701d2c9b48d8
  • Upwork Job ID: 1785366415813079040
  • Last Price Increase: 2024-04-30
  • Automatic offers:
    • s77rt | Reviewer | 0
    • ShridharGoel | Contributor | 0
Issue OwnerCurrent Issue Owner: @johncschuster
@ShridharGoel
Copy link
Contributor

ShridharGoel commented Apr 30, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

Track and budget personal spend updates need to be done.

What is the root cause of that problem?

New change.

What changes do you think we should make in order to solve the problem?

Rename below in en.ts and es.ts.

 [CONST.ONBOARDING_CHOICES.PERSONAL_SPEND]: 'Track and budget personal spend',

Below needs to be removed, along with its usages.

[CONST.ONBOARDING_CHOICES.TRACK]: 'Track business spend for taxes',

@melvin-bot melvin-bot bot added the Daily KSv2 label Apr 30, 2024
@neonbhai
Copy link
Contributor

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

Feature Request

What changes do you think we should make in order to solve the problem?

We will

  • rename the Track and budget personal spend here:

    [CONST.ONBOARDING_CHOICES.PERSONAL_SPEND]: 'Track and budget personal spend',

    to Track and budget expenses

  • remove CONST.ONBOARDING_CHOICES.TRACK as an option from CONST.ts (and other related logic)

    TRACK: 'newDotTrack',

@danielrvidal danielrvidal added the External Added to denote the issue can be worked on by a contributor label Apr 30, 2024
@melvin-bot melvin-bot bot changed the title Rename the Track and budget personal spend to Track and budget expenses [$250] Rename the Track and budget personal spend to Track and budget expenses Apr 30, 2024
Copy link

melvin-bot bot commented Apr 30, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01d70e701d2c9b48d8

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Apr 30, 2024
Copy link

melvin-bot bot commented Apr 30, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

@allgandalf
Copy link
Contributor

Proposal

Please re-state the problem that we are trying to solve in this issue.

Change the message intent and remove the tax option from the onboarding flow

What is the root cause of that problem?

Feature request

What changes do you think we should make in order to solve the problem?

[CONST.ONBOARDING_CHOICES.PERSONAL_SPEND]: 'Track and budget personal spend',

we need to modify the above text in both English and Spanish to: Track and budget personal spend
We need to remove this const from the onboarding flow and also remove the related references :

[CONST.ONBOARDING_CHOICES.TRACK]: Illustrations.CompanyCard,

Remove the following const too:
[CONST.ONBOARDING_CHOICES.TRACK]: 'Track business spend for taxes',

Remove the above from Spanish translation too

What alternative solutions did you explore? (Optional)

@s77rt
Copy link
Contributor

s77rt commented Apr 30, 2024

Thanks for the proposals. This should be straightforward work so going with the first proposal @ShridharGoel

🎀 👀 🎀 C+ reviewed
Link to proposal

Copy link

melvin-bot bot commented Apr 30, 2024

Triggered auto assignment to @tgolen, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@mountiny mountiny self-assigned this Apr 30, 2024
@mountiny
Copy link
Contributor

Happy to take this over as i have worked on this feature

@melvin-bot melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Apr 30, 2024
Copy link

melvin-bot bot commented Apr 30, 2024

📣 @s77rt 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

Copy link

melvin-bot bot commented Apr 30, 2024

📣 @ShridharGoel 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

@mountiny
Copy link
Contributor

Thanks @ShridharGoel can you please raise the pr? I will create a clean up for backend tomorrow

@ShridharGoel
Copy link
Contributor

PR will be up soon.

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Apr 30, 2024
@ShridharGoel
Copy link
Contributor

Link to the PR: #41354

@danielrvidal
Copy link
Contributor Author

@ShridharGoel, I apologize for the late request. Could we make one more small update that I forgot after seeing your screenshot:

Could you have the order be:

  • Track and budget expenses
  • Manage my team's expenses
  • Get paid back by my employer
  • Chat and split expenses with friends
  • Something else

@tgolen tgolen removed their assignment Apr 30, 2024
@tgolen
Copy link
Contributor

tgolen commented Apr 30, 2024

Thanks for taking this one, Vit!

@trjExpensify trjExpensify changed the title [$250] Rename the Track and budget personal spend to Track and budget expenses [$250] [Guided Setup Stage 2] Rename the Track and budget personal spend to Track and budget expenses May 1, 2024
@trjExpensify trjExpensify added the Daily KSv2 label May 1, 2024
@mountiny
Copy link
Contributor

mountiny commented May 1, 2024

@ShridharGoel can you please raise a follow up pr with the updated order? What is your eta?

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels May 1, 2024
@ShridharGoel
Copy link
Contributor

@mountiny #41400

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels May 2, 2024
@melvin-bot melvin-bot bot changed the title [$250] [Guided Setup Stage 2] Rename the Track and budget personal spend to Track and budget expenses [HOLD for payment 2024-05-09] [$250] [Guided Setup Stage 2] Rename the Track and budget personal spend to Track and budget expenses May 2, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label May 2, 2024
Copy link

melvin-bot bot commented May 2, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented May 2, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.69-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-05-09. 🎊

For reference, here are some details about the assignees on this issue:

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels May 8, 2024
Copy link

melvin-bot bot commented May 9, 2024

Issue is ready for payment but no BZ is assigned. @johncschuster you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

@mountiny
Copy link
Contributor

mountiny commented May 9, 2024

$250 to @ShridharGoel and to @s77rt

@melvin-bot melvin-bot bot added the Overdue label May 13, 2024
@mountiny
Copy link
Contributor

This is due payment @johncschuster

@melvin-bot melvin-bot bot removed the Overdue label May 13, 2024
@johncschuster
Copy link
Contributor

johncschuster commented May 13, 2024

On it!

@johncschuster
Copy link
Contributor

I've issued payment to @s77rt. Thanks for your hard work! 🎉

@ShridharGoel I see your offer is here, can you accept that? Once accepted I can issue payment to you as well. Thank you!

@trjExpensify trjExpensify moved this from Release 1: Spring 2024 (May) to Release 1.5: XeroCon 2024 (June 12th) in [#whatsnext] #wave-collect May 14, 2024
@johncschuster
Copy link
Contributor

Bumped @ShridharGoel in Slack to accept the offer 👍

@johncschuster
Copy link
Contributor

Bumped again in Slack

@johncschuster
Copy link
Contributor

@johncschuster
Copy link
Contributor

Payment has been issued! 🎉

@github-project-automation github-project-automation bot moved this from Release 1.5: XeroCon 2024 (June 12th) to Done in [#whatsnext] #wave-collect May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 External Added to denote the issue can be worked on by a contributor
Projects
No open projects
Archived in project
Development

No branches or pull requests

9 participants