-
Notifications
You must be signed in to change notification settings - Fork 3.2k
[HOLD for payment 2024-05-09] [$250] [Guided Setup Stage 2] Rename the Track and budget personal spend to Track and budget expenses #41350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
ProposalPlease re-state the problem that we are trying to solve in this issue.Track and budget personal spend updates need to be done. What is the root cause of that problem?New change. What changes do you think we should make in order to solve the problem?Rename below in en.ts and es.ts.
Below needs to be removed, along with its usages.
|
ProposalPlease re-state the problem that we are trying to solve in this issue.What is the root cause of that problem?Feature Request What changes do you think we should make in order to solve the problem?We will
|
Job added to Upwork: https://www.upwork.com/jobs/~01d70e701d2c9b48d8 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt ( |
ProposalPlease re-state the problem that we are trying to solve in this issue.Change the message intent and remove the tax option from the onboarding flow What is the root cause of that problem?Feature request What changes do you think we should make in order to solve the problem?Line 1354 in 942c851
we need to modify the above text in both English and Spanish to: Track and budget personal spend We need to remove this const from the onboarding flow and also remove the related references :
Remove the following const too: Line 1351 in 942c851
Remove the above from Spanish translation too What alternative solutions did you explore? (Optional) |
Thanks for the proposals. This should be straightforward work so going with the first proposal @ShridharGoel 🎀 👀 🎀 C+ reviewed |
Triggered auto assignment to @tgolen, see https://stackoverflow.com/c/expensify/questions/7972 for more details. |
Happy to take this over as i have worked on this feature |
📣 @s77rt 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app! |
📣 @ShridharGoel 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app! Offer link |
Thanks @ShridharGoel can you please raise the pr? I will create a clean up for backend tomorrow |
PR will be up soon. |
Link to the PR: #41354 |
@ShridharGoel, I apologize for the late request. Could we make one more small update that I forgot after seeing your screenshot: Could you have the order be:
|
Thanks for taking this one, Vit! |
@ShridharGoel can you please raise a follow up pr with the updated order? What is your eta? |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.69-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-05-09. 🎊 For reference, here are some details about the assignees on this issue:
|
Issue is ready for payment but no BZ is assigned. @johncschuster you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks! |
$250 to @ShridharGoel and to @s77rt |
This is due payment @johncschuster |
On it! |
I've issued payment to @s77rt. Thanks for your hard work! 🎉 @ShridharGoel I see your offer is here, can you accept that? Once accepted I can issue payment to you as well. Thank you! |
Bumped @ShridharGoel in Slack to accept the offer 👍 |
Bumped again in Slack |
Payment has been issued! 🎉 |
Uh oh!
There was an error while loading. Please reload this page.
Problem: We’re embracing Track as being a critical flow for new users to Try New Expensify, both for the earnings call and in general. Pushing someone down the Submit flow too early forces them to share the product before they have tried it themselves. Currently, Track is either promoting a sole proprietor case OR personal use, which means employees likely will not choose it. Additionally, if people select Track for business, we automatically create a workspace for them to use with their account. This is problematic if an employee selects that and then doesn’t undergo the bottom-up like submitting to an employer.
Solution: Update the onboarding options to make Track the most logical thing for both sole props and Employees to select. @zsgreenwald is already planning on making similar updates, but we need to fast-track these updates to support our release. Thus we need to do the following asap:
Track and budget personal spend
in the onboarding flow toTrack and budget expenses
Track business spend for taxes
as an option.Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @johncschusterThe text was updated successfully, but these errors were encountered: