[HOLD for payment 2024-03-22] [$500] Category - Selected category is not ticked when it appears in the search result

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: v1.4.44-0
Reproducible in staging?: y
Reproducible in production?: n
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com.
2. Go to workspace chat.
3. Click + > Request money > Manual.
4. Proceed to confirmation page.
5. Click Category.
6. Select a category.
7. Click Category.
8. Search for the category selected in Step 5.

Expected Result:

The selected category will be ticked in the search result as it is selected.

Actual Result:

The selected category is not ticked in the search result.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6393823_1709030989709.20240227_073006__1_.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~010c5eb5319c889dad
• Upwork Job ID: 1762472753849147392
• Last Price Increase: 2024-02-27
• Automatic offers:
• dukenv0307 | Contributor | 0

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~010c5eb5319c889dad

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @puneetlath (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[kbecciv]

We think that this bug might be related to #wave5-free-submitters
CC @dylanexpensify

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The selected category is not ticked in the search result.

What is the root cause of that problem?

In here, we don't insert isSelected: true based on whether the searched categories are selected.

What changes do you think we should make in order to solve the problem?

In here, we don't insert isSelected: true field to the result based on whether the searched categories are selected. We can check whether the searched categories are selected based on the selectedOptions params passed in.

Something like:

const searchCategories = enabledCategories.filter((category) => category.name.toLowerCase().includes(searchInputValue.toLowerCase())).map((category) => ({
    ...category,
    isSelected: selectedOptions.some((selectedOption) => selectedOption.name === category.name),
}));

What alternative solutions did you explore? (Optional)

When the selected category matches the search result, currently it will not be in the 1st position by default, if we want it to be in the 1st position similar to non-search case, we can push it to top.

const searchCategories = enabledAndSelectedCategories.filter((category) => category.name.toLowerCase().includes(searchInputValue.toLowerCase()));

[nexarvo]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Selected category is not ticked when it appears in the search result.

What is the root cause of that problem?

When we are searching for category, the getCategoryListSelection function does not preserve the isSelected flag which is responsible for showing the tick.

What changes do you think we should make in order to solve the problem?
We can find the loop through the selected options and find update the isSelected flag of the filtered object.

searchCategories.forEach(cat => {
            const selectedCatgory = selectedOptions.find(selectedCat => selectedCat.name === cat.name);
            if(selectedCatgory) {
                cat.isSelected = true;
            }
        });

The filter function is code block is located here:

App/src/libs/OptionsListUtils.ts

Lines 966 to 978 in cfa0ae3

	if (searchInputValue) {
	const searchCategories = enabledCategories.filter((category) => category.name.toLowerCase().includes(searchInputValue.toLowerCase()));
	categorySections.push({
	// "Search" section
	title: '',
	shouldShow: true,
	indexOffset,
	data: getCategoryOptionTree(searchCategories, true),
	});
	return categorySections;
	}

What alternative solutions did you explore? (Optional)

[rushatgabhane]

🎀👀🎀 i like @dukenv0307 's proposal #37287 (comment)

[melvin-bot]

Current assignee @puneetlath is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

[puneetlath]

Removing the label as I don't think this needs to be a deploy blocker.

[melvin-bot]

📣 @dukenv0307 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[dukenv0307]

@rushatgabhane this PR is ready for preview.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.52-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: Selected category is not ticked when it appears in the search result #37479

If no regressions arise, payment will be issued on 2024-03-22. 🎊

For reference, here are some details about the assignees on this issue:

• @rushatgabhane requires payment through NewDot Manual Requests
• @dukenv0307 requires payment automatic offer (Contributor)

[puneetlath]

Payment summary:

• C - @dukenv0307 - $500 - paid via Upwork
• C+ - @rushatgabhane - $500 - to be paid via NewDot

@rushatgabhane please request on NewDot.

Thanks everyone!