-
Notifications
You must be signed in to change notification settings - Fork 3.2k
[HOLD for payment 2024-02-14] [$500] Login - Blank screen and infinite spinner when logging in using magic link #35745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
Triggered auto assignment to @Gonals ( |
We think that this bug might be related to #vip-vsp |
I have not been able to reproduce this. Is it only happening on staging? |
Job added to Upwork: https://www.upwork.com/jobs/~01b3cfffaf993f802b |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @ntdiary ( |
@Gonals You need to use the link from the email, have you tried that. I was able to reproduce, this is a real blocker. |
And given we use the last visited path on native now, when user gets to the loading page, kills the app and opens it again, they are stuck on the infinite spinner and they have to uninstall the app to fix it |
ProposalPlease re-state the problem that we are trying to solve in this issue.Infinite spinner when logging in using magic link What is the root cause of that problem?In ValidateLoginPage a useEffect is used to authenticateUser and signIn. App/src/pages/ValidateLoginPage/index.tsx Lines 15 to 24 in d765c37
When sign-in using deep link App/src/libs/Navigation/Navigation.ts Lines 172 to 175 in d765c37
App/src/libs/Navigation/Navigation.ts Lines 39 to 45 in d765c37
What changes do you think we should make in order to solve the problem?We should wait till const [isNavReady, setIsNavReady] = useState(false)
useEffect(() => {
if (!isNavReady) { return }
if (session?.authToken) {
// If already signed in, do not show the validate code if not on web,
// because we don't want to block the user with the interstitial page.
Navigation.goBack();
} else {
Session.signInWithValidateCodeAndNavigate(Number(accountID), validateCode);
}
// eslint-disable-next-line react-hooks/exhaustive-deps
}, [isNavReady]);
useEffect(() => {
// Wait till navigation becomes available
Navigation.isNavigationReady().then(() => {
setIsNavReady(true)
})
}, []) Result fix-login_out.mp4What alternative solutions did you explore? (Optional)None |
Yep. I was able to reproduce this time |
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results. If a regression has occurred and you are the assigned CM follow the instructions here. If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future. |
❌ There was an error making the offer to @ntdiary for the Reviewer role. The BZ member will need to manually hire the contributor. |
❌ There was an error making the offer to @aswin-s for the Contributor role. The BZ member will need to manually hire the contributor. |
Feel free to make drafts first in these scenarios so C+ can jump in sooner than later. |
Draft PR here |
Testing well on iOS staging. Gonna remove the blocker here. Thanks for the quick solutions 🙇 |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.37-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-02-14. 🎊 For reference, here are some details about the assignees on this issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
Payment has been issued! 🎉 @situchan, can you complete the BZ Checklist above? Thank you! |
I think this regression came from ideal nav. |
Sounds great! Thanks for confirming that! |
Uh oh!
There was an error while loading. Please reload this page.
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: 1.4.36
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:
Expected Result:
User is logged in and lands on LHN
Actual Result:
The blank screen and the infinite spinner displayed
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6365447_1706916982856.video_2024-02-02_18-34-20.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: