-
Notifications
You must be signed in to change notification settings - Fork 3.2k
[HOLD for payment 2024-02-26] [$500] Workspace - Clicking on avatar of invited workspace does not open avatar in full screen view #35731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
Triggered auto assignment to @bondydaa ( |
We think that this bug might be related to #wave5-free-submitters |
Asked about this here https://expensify.slack.com/archives/C05DWUDHVK7/p1706912992107429
removing the blocker and going to put this out for external proposals. |
Triggered auto assignment to @kadiealexander ( |
Job added to Upwork: https://www.upwork.com/jobs/~0188ba50d52f570fef |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh ( |
@kadiealexander no action required from ya for now. |
what we're looking for is a way to view workspace avatars in the bigger "attachment modal" when following these steps:
|
ProposalPlease re-state the problem that we are trying to solve in this issue.Workspace - Clicking on avatar of invited workspace does not open avatar in full screen view What is the root cause of that problem?The main problem with the issue is that we have disabled param which disables any interaction with the image App/src/pages/workspace/WorkspaceOverviewPage.js Lines 77 to 108 in 80dc8cb
What changes do you think we should make in order to solve the problem?To fix this issue we can add a new property ( To add the ability to press on image we can make changes here
App/src/components/AvatarWithImagePicker.js Line 336 in 039b575
Add a condition here so that instead of opening the menu For this, we can use Additional ways
> We can make `AttachmentModal` like wrapper for all image component to use show function from `AttachmentModal`
App/src/components/AvatarWithImagePicker.js Line 333 in 039b575
Plus I notice that the close button on AttachmentModal doesn't have a selected cursor What alternative solutions did you explore? (Optional)NA |
ProposalPlease re-state the problem that we are trying to solve in this issue.Workspace - Clicking on avatar of invited workspace does not open avatar in full screen view What is the root cause of that problem?In the
This is only true if the
Hence, if App/src/components/AvatarWithImagePicker.js Lines 328 to 337 in 3ab4e6e
What changes do you think we should make in order to solve the problem?Since we don't need to edit the avatar when the user is not an admin but can view it, I think it is reasonable to consider using the We will get the single icon to pass into the Therefore, we can use a simple condition to either render the |
I've popped this one in the wave8 project, as it's a byproduct of the change with ideal nav to let non-admin members view the workspace overview page. 👍 CC: @mountiny @hayata-suenaga |
There are 3 options to choose from |
@ZhenjaHorbach Reviewing the proposal, I believe we can implement a simpler solution:
onPress={() => {
if (previewRoute && disabled) {
Navigation.navigate(previewRoute);
return;
}
setIsMenuVisible((prev) => !prev);
}} With this approach, we can ensure that the AvatarWithImagePicker is used for similar use cases. All that's needed is to provide a preview route and disable the picker option. What do you think @bondydaa? |
I think there is no easier way then App/src/pages/settings/InitialSettingsPage.js Line 343 in 310941b
|
This was not so clear to me when I first saw it. Let's reuse that instead of the |
I think this proposal from @ZhenjaHorbach is good. We should only verify the 🎀 👀 🎀 C+ reviewed |
Current assignee @bondydaa is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new. |
@Tony-MK Thanks for the proposal. Your proposal looks good as well, but I think fixing |
📣 @fedirjh 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app! |
📣 @ZhenjaHorbach 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app! Offer link |
PR will be ready today or tomorrow |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.42-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-02-26. 🎊 For reference, here are some details about the assignees on this issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
BugZero Checklist:
|
Payouts due:
Upwork job is here. |
Uh oh!
There was an error while loading. Please reload this page.
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: 1.4.36.0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:
Precondition:
Expected Result:
Workspace avatar will open in full screen view.
Actual Result:
Nothing happens when clicking on the avatar of invited workspace. Clicking on avatar of invited workspace does not open avatar in full screen view.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6365315_1706907042565.20240203_005005.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @fedirjhThe text was updated successfully, but these errors were encountered: