[HOLD for payment 2023-10-09] [$500] Dev: Web - Unnecessary two back icons in #Room

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Click on FAB icon and select Send message option
2. Go to #Room tab

Expected Result:

It should show only one back icon

Actual Result:

Two back icons in #Room

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: Dev 1.3.70.5
Reproducible in staging?: n
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-09-16.at.10.27.24.AM.mov

Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1694840257162789

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01ce9ae2774c7e1dd5
• Upwork Job ID: 1703143519242104832
• Last Price Increase: 2023-09-16
• Automatic offers:
• c3024 | Contributor | 26809665
• gadhiyamanan | Reporter | 26809666

[c3024]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Not found page when selecting room in RHP in send message option of FAB shows another back button.

What is the root cause of that problem?

There is a back button for the RHP as a whole for send message and here

App/src/pages/workspace/WorkspaceNewRoomPage.js

Line 147 in 76c1559

<FullPageNotFoundView shouldShow={!Permissions.canUsePolicyRooms(props.betas) || !workspaceOptions.length}>

we are showing another back button again.

What changes do you think we should make in order to solve the problem?

We should add shouldShowBackButton={false} here

App/src/pages/workspace/WorkspaceNewRoomPage.js

Line 147 in 76c1559

<FullPageNotFoundView shouldShow={!Permissions.canUsePolicyRooms(props.betas) || !workspaceOptions.length}>

I think instead of a generic error we can show

1. title as emptyWorkspace.title from en.ts and show no subtitleKey.
2. Keep title as it is and show subtitleKey as emptyWorkspace.title
3. Use linkKey as emptyWorkspace.title and give corresponding onLinkPress for creating workspace.

What alternative solutions did you explore? (Optional)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01ce9ae2774c7e1dd5

[melvin-bot]

Triggered auto assignment to @sonialiap (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

[melvin-bot]

📣 @MuzanEDM! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[sonialiap]

@eVoloshchak what do you think of the above proposals?

[eVoloshchak]

The fix is pretty straightforward, @c3024's proposal looks good to me!

1. title as emptyWorkspace.title from en.ts and show no subtitleKey.
2. Keep title as it is and show subtitleKey as emptyWorkspace.title
3. Use linkKey as emptyWorkspace.title and give corresponding onLinkPress for creating workspace.

Totally agree with this also, the generic error we currently displaying is fine, but more specific error explaining to users what's exactly wrong is always better

🎀👀🎀 C+ reviewed!