[SMARTSCAN] MEDIUM: Receipt Scan Failures Polish

[trjExpensify]

👋 @Gonals there's a bit of a diff from the design doc on this one. Can you help clean this up post-SaaStr? Thanks!

• 1. The error messages should be in-line beneath the field in error

• 2. The title of the failed request should update from Receipt scan in progress... to Receipt missing details

• 3. A system message from Expensify should be added to the transaction thread when the receipt scan fails to notify the member

• 4. The RBR red dot should be on the request row for member only (not the expense report row or for the admin as well)

CC: @JmillsExpensify @shawnborton

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~017bd7a39e34a6a3cb
• Upwork Job ID: 1699189929552527360
• Last Price Increase: 2023-09-05

[melvin-bot]

Current assignee @Gonals is eligible for the Engineering assigner, not assigning anyone new.

[melvin-bot]

Current assignee @trjExpensify is eligible for the Bug assigner, not assigning anyone new.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~017bd7a39e34a6a3cb

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @sobitneupane (Internal)

[shawnborton]

Another quick one - if there is no Amount, we should make the Amount label use our standard font size (15px) and float to the vertical center of the push row. This really should be a global component we share everywhere, I feel like we keep having inconsistencies here.

[trjExpensify]

Like so:

Edit: Description was off.

[Gonals]

Sounds good! The automated message and RBR having to be visible just for the user were on my radar for after Saastr 😁.

About the error message relocation... Do we really want to? It kinda looks better to me the way it is now (but I've been known to be terrible at UI)

[Gonals]

Moving to weekly for now

[trjExpensify]

About the error message relocation... Do we really want to?

Yeah, we standardise on showing "in-line" errors beneath the row, so we should do the same here IMO.

[Gonals]

About the error message relocation... Do we really want to?

Yeah, we standardise on showing "in-line" errors beneath the row, so we should do the same here IMO.

I'm happy to change it, but I really like it better how it is now 😅

[Gonals]

The title of the failed request should update from Receipt scan in progress... to Receipt missing details

Only in the request preview, right? No changes to the message behavior in the report preview?

The RBR red dot should be on the request row for member only (not the expense report row or for the admin as well)

Oh, so no RBR on the report preview when there is a receipt with errors? Only on the money request preview? What about the LHN?

Checking the design, I see the red dot in the report preview:

In the LHN, the behavior does differ. In the design, it shows in the "Money Request", while we are displaying it in the "Main chat". What behavior do we want?

[Gonals]

More questions 😆 :

From the design:

Note: A system message from Expensify is automatically added as a permanent comment to the transaction thread (and therefore notifies the submitter), clarifying that the receipt scan has failed: “Receipt scanning failed. Please enter the details manually.”

Who is this "expensify"? What happens when the user clicks the mane/avatar? Should we create a profile? Have it just be Concierge? Make it unclickable?

Edit:
Did some testing and it is pretty easy to get Concierge to post on the conversation automatically:

[trjExpensify]

The title of the failed request should update from Receipt scan in progress... to Receipt missing details

Only in the request preview, right? No changes to the message behavior in the report preview?

Yeah, only request transaction thread have the title Receipt missing details, reflected in the page header and the LHN row.

The RBR red dot should be on the request row for member only (not the expense report row or for the admin as well)

Oh, so no RBR on the report preview when there is a receipt with errors? Only on the money request preview? What about the LHN?

The RBR dot is on the pinned request row in the LHN for the submitter of the request. Or at least, that's how we intended it to work initially! Not married to it (or having it on the expense report row as well), but the idea was that the action is on the request that failed and that's what would show up in the LHN until resolved for the submitter to focus on fixing.

For both the member and admin, the request preview component in the expenseReport does have a red dot as well to signal that there are errors within that request to check out. @JmillsExpensify, foreshadowing violations we should probably add the dot separator here i.e Cash - Missing details. Similarly, the report preview component in the workspace chat has a red dot for both admin/member, you can Pay from here for example, so an indication that there are errors is warranted.

[trjExpensify]

Who is this "expensify"? What happens when the user clicks the mane/avatar? Should we create a profile? Have it just be Concierge? Make it unclickable?

Good question on the profile. My vote is to just have a name and avatar in the right pane when clicked for now. We could add some kind of improvement there with an option row to link to help pages and support or something if we really want.

[puneetlath]

Yeah I think putting the RBR directly on the request would be in-line with the plan for violations as well.

[Gonals]

I still think there should be a red dot on the request row though, which would appear in the LHN if you navigate to it until you fix the errors.

We can totally do that too.

I have to check if we load expense Report chats automatically, but I'm pretty sure we do.

So, all in agreement to:

• Show red dot in the LHN in the expense report row if there is a request with errors in there
  AND
• Show red dot in the LHN in the transaction row if it has errors
  ?
  @trjExpensify @JmillsExpensify

[trjExpensify]

Yup!

[Gonals]

PRs in place for all of these! Pending the account for automated messages

[JmillsExpensify]

Nice, thank you!

[trjExpensify]

@Gonals what's going on here with the merchant name error message not being in red and below the row in-line?

[Gonals]

Not sure what happened! My bet is a merge conflict, but I made a PR for it yesterday and it has already merged! It will be fixed with the next deploy

[trjExpensify]

Once this PR has merged can we give @isagoico a heads up, so we can add the regression test for adding the sys message?

[dylanexpensify]

Did we get this one fixed? Looks like it was supposed to be fixed on the next deploy 3 weeks ago based on @Gonals' comment

[trjExpensify]

Let's get clear on what "this one" means? I think we had a couple of outstanding items on this issue:

1. The merchant field error not being beneath the field and in red
2. The system message to be added to transaction thread when smartScan fails

[dylanexpensify]

Ah, by this one, I meant the comment above where you called out the error message that @Gonals replied to after your flag.

[dylanexpensify]

It sounds like the system message hit prod a few weeks ago, did we get that added to a regression test?

[Gonals]

There's actually a problem with that one. It looks posted by _FAKE_ instead of [email protected]. I believe it is caused by how [email protected] was created (closed from the get-go) and have a PR in review to (hopefully) fix it.

[dylanexpensify]

Ahhh useful to know, thanks @Gonals! Mind linking PR here for good measure? 🙇‍♂️

[Gonals]

Yep! This is the one: https://github.com/Expensify/Auth/pull/9070

[dylanexpensify]

Checking in, did that Auth PR linked above fix the issue @Gonals?

[melvin-bot]

This issue has not been updated in over 15 days. @trjExpensify, @Gonals, @sobitneupane eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[trjExpensify]

Yes, that's fixed. There's a separate issue to add the Expensify logo and give it a name. Closing.