[HOLD for payment 2023-11-27] [HOLD for payment 2023-11-21] [TS migration] Migrate 'App.js' lib to TypeScript

[melvin-bot]

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path	Dependencies
src/libs/actions/App.js	20

Issue Owner

Current Issue Owner: @parasharrajat

[melvin-bot]

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[VickyStash]

Hi, I'm Viktoryia from Callstack - expert contributor group - and I would like to work on this issue.

[melvin-bot]

Triggered auto assignment to @neil-marcellini, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.98-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [No QA] [TS migration] Migrate 'App.js' lib to TypeScript #29661

If no regressions arise, payment will be issued on 2023-11-21. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.0-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [TS Migration] Update currentUserAccountID type #31270

If no regressions arise, payment will be issued on 2023-11-27. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

[melvin-bot]

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[neil-marcellini]

@garrettmknight would you please pay the C+ for review of the PR?

[garrettmknight]

Summary of payments for the two PRs in this issue.:

• Reviewer: @parasharrajat $250
• Reviewer: @jjcoffee $250 paid in Upwork

Upwork Job: https://www.upwork.com/en-gb/ab/applicants/1730270261796622336/job-details

[parasharrajat]

@jjcoffee will be C+ here too.

[garrettmknight]

Missed the other PR - updated

[jjcoffee]

@garrettmknight Friendly bump for payment 🙇

[garrettmknight]

@jjcoffee sorry - I'd just treated you like you were getting paid via NewDot. Offer sent in Upwork.

[jjcoffee]

@garrettmknight Haha, no worries at all - I thought that's what might have happened. Offer accepted!

[garrettmknight]

Cool all paid!

[garrettmknight]

Now it's just waiting on @parasharrajat to request payment. Moving to weekly for that.

[melvin-bot]

This issue has not been updated in over 15 days. @garrettmknight, @parasharrajat, @neil-marcellini eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[parasharrajat]

We can close this issue. I will request later. Thanks.

[parasharrajat]

Payment requested as per #24923 (comment)

[JmillsExpensify]

$250 approved for @parasharrajat