Skip to content

[hold for payment 2023-08-17] PDF blinks while open the PDF #24311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 of 6 tasks
kavimuru opened this issue Aug 9, 2023 · 19 comments
Closed
1 of 6 tasks

[hold for payment 2023-08-17] PDF blinks while open the PDF #24311

kavimuru opened this issue Aug 9, 2023 · 19 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review Weekly KSv2

Comments

@kavimuru
Copy link

kavimuru commented Aug 9, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Action Performed:

  1. go to any chat
  2. send a pdf file
  3. open a pdf and scroll

Expected Result:

PDF blinks

Actual Result:

PDF should not blink

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.51-2
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-08-09.at.1.08.04.PM.mov
Recording.1458.mp4

An_Improved_Bytewise_Approximate_Matching_Algorith.pdf

Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1691566749845919

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~017d3067cf349b37a0
  • Upwork Job ID: 1689730232530489344
  • Last Price Increase: 2023-08-10
@kavimuru kavimuru added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Aug 9, 2023
@melvin-bot
Copy link

melvin-bot bot commented Aug 9, 2023

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Aug 9, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@OSBotify
Copy link
Contributor

OSBotify commented Aug 9, 2023

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot
Copy link

melvin-bot bot commented Aug 9, 2023

Triggered auto assignment to @danieldoglas (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@situchan
Copy link
Contributor

situchan commented Aug 9, 2023

WIP: #24308
@rezkiy37 when will it be ready for review?

@rezkiy37
Copy link
Contributor

rezkiy37 commented Aug 9, 2023

WIP: #24308 @rezkiy37 when will it be ready for review?

Today.

@rezkiy37
Copy link
Contributor

rezkiy37 commented Aug 9, 2023

The PR (#24308) is ready for review.

@rezkiy37 rezkiy37 mentioned this issue Aug 9, 2023
59 tasks
@joekaufmanexpensify joekaufmanexpensify added the Reviewing Has a PR in review label Aug 9, 2023
@joekaufmanexpensify
Copy link
Contributor

The fix is out on staging, so this no longer needs to be an hourly.

@joekaufmanexpensify joekaufmanexpensify added Daily KSv2 and removed Hourly KSv2 labels Aug 9, 2023
@joekaufmanexpensify joekaufmanexpensify added Weekly KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Daily KSv2 labels Aug 10, 2023
@joekaufmanexpensify
Copy link
Contributor

Removed deploy blocker label, as this is out on staging now, so is all set. All we need to do here is pay the reporting bonus once this is out on prod!

@joekaufmanexpensify joekaufmanexpensify added the Internal Requires API changes or must be handled by Expensify staff label Aug 10, 2023
@melvin-bot
Copy link

melvin-bot bot commented Aug 10, 2023

Job added to Upwork: https://www.upwork.com/jobs/~017d3067cf349b37a0

@melvin-bot

This comment was marked as outdated.

@joekaufmanexpensify
Copy link
Contributor

@gadhiyamanan offer sent for $250!

@gadhiyamanan
Copy link
Contributor

@joekaufmanexpensify offer accepted, thanks!

@joekaufmanexpensify
Copy link
Contributor

Great, ty! PR was deployed to prod on 2023-08-10, so we'll issue payment on 2023-08-17.

@joekaufmanexpensify joekaufmanexpensify changed the title PDF blinks while open the PDF [hold for payment 2023-08-17] PDF blinks while open the PDF Aug 14, 2023
@joekaufmanexpensify
Copy link
Contributor

All set to issue payment here!

@joekaufmanexpensify
Copy link
Contributor

@gadhiyamanan $250 sent and contract ended!

@joekaufmanexpensify
Copy link
Contributor

Upwork job removed.

@joekaufmanexpensify
Copy link
Contributor

This was a regression fix, so no other payment required.

@joekaufmanexpensify
Copy link
Contributor

Regression is fixed, and regression reporting bonus paid. Closing as this is all set!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Development

No branches or pull requests

8 participants