[HOLD for payment 2023-08-17] [$1000] [HOLD for payment 2023-08-16] The total requested amount does not update until the IOU is clicked on or the page is refreshed #24267

mvtglobally · 2023-08-08T13:50:31Z

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

Action Performed:

Click on the plus sign and select "request money."
Enter the desired amount and recipient's email address, and click "request money."
Repeat step 2 to make a second request with the same recipient.
Delete the first request from the reply thread.
Observe that the total requested amount does not update in real-time.

Expected Result:

The total requested amount should update in real-time after deleting the first request and making a second one.

Actual Result:

The total requested amount does not update until the IOU is clicked on or the page is refreshed.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: 1.3.51-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

screen-capture.-.2023-08-08T044732.549.webm

screen-capture.-.2023-08-08T043901.984.mp4

Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1691494603760399
reported earlier in
Issue reported by: @namhihi237
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1691444951222519

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0136af4481ecaa59a7
Upwork Job ID: 1689346748730482688
Last Price Increase: 2023-08-09
Automatic offers:

StevenKKC | Contributor | 26035056

melvin-bot · 2023-08-08T13:50:36Z

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot · 2023-08-08T13:50:38Z

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

OSBotify · 2023-08-08T13:52:21Z

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

melvin-bot · 2023-08-08T13:52:24Z

Triggered auto assignment to @srikarparsi (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

dukenv0307 · 2023-08-08T14:28:51Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

The total requested amount does not update until the IOU is clicked on or the page is refreshed

What is the root cause of that problem?

When we delete a request money, report.total is changed

But in ReportActionItem we don't check the report.total to re-render MoneyReportView here

App/src/pages/home/report/ReportActionItem.js

Lines 601 to 620 in dd21a0b

    
           memo( 
        
               ReportActionItem, 
        
               (prevProps, nextProps) => 
        
                   prevProps.displayAsGroup === nextProps.displayAsGroup && 
        
                   prevProps.draftMessage === nextProps.draftMessage && 
        
                   prevProps.isMostRecentIOUReportAction === nextProps.isMostRecentIOUReportAction && 
        
                   prevProps.hasOutstandingIOU === nextProps.hasOutstandingIOU && 
        
                   prevProps.shouldDisplayNewMarker === nextProps.shouldDisplayNewMarker && 
        
                   _.isEqual(prevProps.emojiReactions, nextProps.emojiReactions) && 
        
                   _.isEqual(prevProps.action, nextProps.action) && 
        
                   _.isEqual(prevProps.report.pendingFields, nextProps.report.pendingFields) && 
        
                   _.isEqual(prevProps.report.errorFields, nextProps.report.errorFields) && 
        
                   lodashGet(prevProps.report, 'statusNum') === lodashGet(nextProps.report, 'statusNum') && 
        
                   lodashGet(prevProps.report, 'stateNum') === lodashGet(nextProps.report, 'stateNum') && 
        
                   prevProps.translate === nextProps.translate && 
        
                   // TaskReport's created actions render the TaskView, which updates depending on certain fields in the TaskReport 
        
                   ReportUtils.isTaskReport(prevProps.report) === ReportUtils.isTaskReport(nextProps.report) && 
        
                   prevProps.action.actionName === nextProps.action.actionName && 
        
                   prevProps.report.reportName === nextProps.report.reportName && 
        
                   prevProps.report.description === nextProps.report.description &&

What changes do you think we should make in order to solve the problem?

We should add the check here to re-render MoneyReportView when the report.total is changed

memo(
        ReportActionItem,
        (prevProps, nextProps) =>
        ...
        // Check to re-render MoneyReportView
        lodashGet(prevProps.report, 'total', 0) === lodashGet(nextProps.report, 'total', 0)

App/src/pages/home/report/ReportActionItem.js

Lines 601 to 620 in dd21a0b

    
           memo( 
        
               ReportActionItem, 
        
               (prevProps, nextProps) => 
        
                   prevProps.displayAsGroup === nextProps.displayAsGroup && 
        
                   prevProps.draftMessage === nextProps.draftMessage && 
        
                   prevProps.isMostRecentIOUReportAction === nextProps.isMostRecentIOUReportAction && 
        
                   prevProps.hasOutstandingIOU === nextProps.hasOutstandingIOU && 
        
                   prevProps.shouldDisplayNewMarker === nextProps.shouldDisplayNewMarker && 
        
                   _.isEqual(prevProps.emojiReactions, nextProps.emojiReactions) && 
        
                   _.isEqual(prevProps.action, nextProps.action) && 
        
                   _.isEqual(prevProps.report.pendingFields, nextProps.report.pendingFields) && 
        
                   _.isEqual(prevProps.report.errorFields, nextProps.report.errorFields) && 
        
                   lodashGet(prevProps.report, 'statusNum') === lodashGet(nextProps.report, 'statusNum') && 
        
                   lodashGet(prevProps.report, 'stateNum') === lodashGet(nextProps.report, 'stateNum') && 
        
                   prevProps.translate === nextProps.translate && 
        
                   // TaskReport's created actions render the TaskView, which updates depending on certain fields in the TaskReport 
        
                   ReportUtils.isTaskReport(prevProps.report) === ReportUtils.isTaskReport(nextProps.report) && 
        
                   prevProps.action.actionName === nextProps.action.actionName && 
        
                   prevProps.report.reportName === nextProps.report.reportName && 
        
                   prevProps.report.description === nextProps.report.description &&

What alternative solutions did you explore? (Optional)

Pujan92 · 2023-08-08T14:49:32Z

Dupe of #24241

mvtglobally · 2023-08-08T15:27:32Z

its not repro in PROD, not sure how it was on the previous builds. we will update first reported accordingly.
@isabelastisser @srikarparsi pls double check if anything would've re-intro this issue or we can just close it

srikarparsi · 2023-08-08T16:41:13Z

Hey @dukenv0307, your proposal looks good to me and tests well. Will you be able to get a PR out in the next 30-45 minutes or so?

dukenv0307 · 2023-08-08T16:42:24Z

@srikarparsi Yes I'm availabel now.

StevenKKC · 2023-08-08T16:43:56Z

@srikarparsi This issue is dupe of #24241 and I have already posted my proposal in #24241 (comment)

srikarparsi · 2023-08-08T16:45:20Z

Sorry about that, didn't see your proposal there. @StevenKKC, can you please create a PR in that case as soon as possible?

srikarparsi · 2023-08-08T16:45:59Z

@dukenv0307, sorry for jumping the gun and asking you to work on this. Since @StevenKKC posted his proposal before yours, I think it makes sense to let @StevenKKC take over this PR.

StevenKKC · 2023-08-08T16:45:59Z

@srikarparsi Yes, no problem.

isabelastisser · 2023-08-08T16:50:46Z

Based on the following comments, I will close this issue:

#24267 (comment)

srikarparsi · 2023-08-08T17:07:48Z

Isa and I discussed internally and we are re-opening this issue. We should tackle this issue here since it's blocking deploy as the code is working on prod but not on staging. If we deploy without addressing this, then it'll cause a regression on prod.

srikarparsi · 2023-08-08T17:08:58Z

@StevenKKC please assign me to review once you have the PR ready. Will you be able to have it out in the 30 minutes to 1 hour? Since this is a deploy blocker, we tend to move a little faster on these.

melvin-bot · 2023-08-09T18:44:29Z

📣 @StevenKKC 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

srikarparsi · 2023-08-09T18:45:11Z

@StevenKKC, can you please fill out this checklist when you have a chance: #24267 (comment)

tewodrosGirmaA · 2023-08-09T18:49:07Z

@StevenKKC, can you please fill out this checklist when you have a chance: #24267 (comment)

I was the original reporter of this bug and I have also reported three other bug reports that have the same root cause as this one. However, I noticed that my name was changed to another reporter in this report. I would appreciate it if my name is restored as the original reporter.

For reference, I reported this bug 5 days ago (1, https://expensify.slack.com/archives/C049HHMV9SM/p1691168685718989, 2, https://expensify.slack.com/archives/C049HHMV9SM/p1691166781356339) while someone else reported it 4 days ago (https://expensify.slack.com/archives/C049HHMV9SM/p1691235556837429). I believe it is important to credit the correct person for reporting a bug

srikarparsi · 2023-08-09T18:57:56Z

Hey @tewodrosGirmaA, definitely, I didn't respond to your first comment as I haven't taken a look into it yet but I'll reply here once I do.

tewodrosGirmaA · 2023-08-09T18:59:29Z

Hey @tewodrosGirmaA, definitely, I didn't respond to your first comment as I haven't taken a look into it yet but I'll reply here once I do.

Thank you

namhihi237 · 2023-08-10T08:01:04Z

@tewodrosGirmaA What is the reason that you think the 2 issues are on the same RCA as this issue? I'm pretty sure your issues are a different RCA. And I can reproduce both issues on stg now.

tewodrosGirmaA · 2023-08-10T08:13:15Z

I am confident that the following aspects share a common origin: the total amount, request count, currency order with the amount when we Change the language to Spanish, and the fact that the reply thread is not updated in real-time. Please verify this information.

namhihi237 · 2023-08-10T08:16:15Z

You can see for now issue total amount has been fixed on stg, but 2 issue you mention still on stg @tewodrosGirmaA

tewodrosGirmaA · 2023-08-10T08:35:24Z

My point is that, for example, when we encountered the 'Reply Thread' bug that I reported in this thread: Link to the thread (https://expensify.slack.com/archives/C049HHMV9SM/p1691168685718989), the reply thread was not updating in real-time. As a result, the requested money was not being deleted, and the total amount was not being calculated correctly. This issue had a common underlying cause. However, I'm pleased to report that it now works perfectly fine during my recent testing

namhihi237 · 2023-08-10T08:45:45Z

But it's not what you think, I see what you mean but if you look closely for the reasons, they are different from RCA, that's why when this issue is fixed the issues you reported are not fixed yet.

srikarparsi · 2023-08-10T17:23:00Z

Hi @tewodrosGirmaA. Just to clarify, you are saying that you reported these two issues.

After deleting a request and going back, two replies temporarily appear on the parent request
The currency doesn't update for the IOU when you change the language from english to spanish

And that is similar to the issue reported by @namhihi237?
Total amount doesn't update when an IOU request is deleted

I read through the reproducible steps for both of your issues and they do seem like valid issues but they are different from this issue @namhihi237 reported. I believe you could still get compensated if GH issues are created from your posts and they are fixed.

melvin-bot · 2023-08-10T20:02:34Z

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.52-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

fix total requested money amount does not update when delete money request #24279

If no regressions arise, payment will be issued on 2023-08-17. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@StevenKKC requires payment offer (Contributor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

melvin-bot · 2023-08-10T20:02:35Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@srikarparsi] The PR that introduced the bug has been identified. Link to the PR:
[@srikarparsi] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@srikarparsi] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@StevenKKC] Determine if we should create a regression test for this bug.
[@StevenKKC] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@isabelastisser] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

StevenKKC · 2023-08-15T06:15:35Z

Determine if we should create a regression test for this bug.
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

Open a chat with a user have chatted together before
Click + in compose and create 2 requests money
Click request money view
Delete one of requests
Verify that total amount is updated after being deleted
Do we agree 👍 or 👎

tewodrosGirmaA · 2023-08-15T16:42:38Z

Hey @srikarparsi, could you please update my name? I discovered that my issue has been identified as a duplicate in Slack. You can find more details about this issue in the following Slack conversation: Slack Conversation Link (https://expensify.slack.com/archives/C049HHMV9SM/p1691168685718989)

namhihi237 · 2023-08-15T16:45:07Z

@tewodrosGirmaA As @srikarparsi check above, this issue is not relative to your issue, I read a comment on Slack I think your issue is the same with here.

jasperhuangg · 2023-08-15T19:44:38Z

The PR that introduced the bug has been identified. Link to the PR: #20841

This didn't introduce the bug, that PR implements tasks–this was a bug that was introduced when we implemented IOUs. Please read for context before blaming certain PRs.

cc @StevenKKC

StevenKKC · 2023-08-16T06:12:29Z

@jasperhuangg I apologize for my mistake and thank you for pointing it out.

tewodrosGirmaA · 2023-08-16T14:49:09Z

@tewodrosGirmaA As @srikarparsi check above, this issue is not relative to your issue, I read a comment on Slack I think your issue is the same with here.

Thank you @namhihi237 , now my name is updated ,in the github link, you suggested me.

isabelastisser · 2023-08-18T20:23:48Z

@srikarparsi @StevenKKC, can you please confirm my summary below is correct? Do you know if the urgency bonus applies to this issue? Thanks!

Issue reported by: @namhihi237 $250
Approved proposal: @StevenKKC $1000, $500 urgency bonus

StevenKKC · 2023-08-22T06:53:19Z

@srikarparsi Can you please confirm the urgency bonus applies to this issue?

srikarparsi · 2023-08-23T16:27:58Z

Hi @isabelastisser! Yes, the summary looks correct! @StevenKKC should receive the urgency bonus.

isabelastisser · 2023-08-23T19:42:55Z

Thanks @srikarparsi!

@namhihi237 and @StevenKKC ! The payments should be set in Upwork, please review your accounts. Thanks!

[@isabelastisser] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
]
(https://github.com/Expensify/Expensify/issues/310599)

namhihi237 · 2023-08-23T23:20:15Z

@isabelastisser accepted thanks.

mvtglobally added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Aug 8, 2023

melvin-bot bot assigned isabelastisser Aug 8, 2023

github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Aug 8, 2023

OSBotify mentioned this issue Aug 8, 2023

Deploy Checklist: New Expensify 2023-08-07 #24230

Closed

98 tasks

melvin-bot bot assigned srikarparsi Aug 8, 2023

melvin-bot bot added Daily KSv2 and removed Hourly KSv2 labels Aug 8, 2023

melvin-bot bot mentioned this issue Aug 8, 2023

Total request money wrong after delete a request #24241

Closed

6 tasks

isabelastisser closed this as completed Aug 8, 2023

srikarparsi reopened this Aug 8, 2023

melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Aug 9, 2023

melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Aug 10, 2023

StevenKKC mentioned this issue Aug 15, 2023

Implement Task Detailed View Redesign #20841

Merged

54 tasks

isabelastisser closed this as completed Aug 23, 2023

[HOLD for payment 2023-08-17] [$1000] [HOLD for payment 2023-08-16] The total requested amount does not update until the IOU is clicked on or the page is refreshed #24267

[HOLD for payment 2023-08-17] [$1000] [HOLD for payment 2023-08-16] The total requested amount does not update until the IOU is clicked on or the page is refreshed #24267

Comments

mvtglobally commented Aug 8, 2023 • edited by melvin-bot bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

melvin-bot bot commented Aug 8, 2023

Uh oh!

melvin-bot bot commented Aug 8, 2023

Bug0 Triage Checklist (Main S/O)

Uh oh!

OSBotify commented Aug 8, 2023

Uh oh!

melvin-bot bot commented Aug 8, 2023

Uh oh!

dukenv0307 commented Aug 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Uh oh!

Pujan92 commented Aug 8, 2023

Uh oh!

mvtglobally commented Aug 8, 2023

Uh oh!

srikarparsi commented Aug 8, 2023

Uh oh!

dukenv0307 commented Aug 8, 2023

Uh oh!

StevenKKC commented Aug 8, 2023

Uh oh!

srikarparsi commented Aug 8, 2023

Uh oh!

srikarparsi commented Aug 8, 2023

Uh oh!

StevenKKC commented Aug 8, 2023

Uh oh!

isabelastisser commented Aug 8, 2023

Uh oh!

srikarparsi commented Aug 8, 2023

Uh oh!

srikarparsi commented Aug 8, 2023

Uh oh!

melvin-bot bot commented Aug 9, 2023

Uh oh!

srikarparsi commented Aug 9, 2023

Uh oh!

tewodrosGirmaA commented Aug 9, 2023

Uh oh!

srikarparsi commented Aug 9, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tewodrosGirmaA commented Aug 9, 2023

Uh oh!

namhihi237 commented Aug 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tewodrosGirmaA commented Aug 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

namhihi237 commented Aug 10, 2023

Uh oh!

tewodrosGirmaA commented Aug 10, 2023

Uh oh!

namhihi237 commented Aug 10, 2023

Uh oh!

srikarparsi commented Aug 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

melvin-bot bot commented Aug 10, 2023

Uh oh!

melvin-bot bot commented Aug 10, 2023

Uh oh!

StevenKKC commented Aug 15, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

mvtglobally commented Aug 8, 2023 •

edited by melvin-bot bot

Loading

dukenv0307 commented Aug 8, 2023 •

edited

Loading

srikarparsi commented Aug 9, 2023 •

edited

Loading

namhihi237 commented Aug 10, 2023 •

edited

Loading

tewodrosGirmaA commented Aug 10, 2023 •

edited

Loading

srikarparsi commented Aug 10, 2023 •

edited

Loading

StevenKKC commented Aug 15, 2023 •

edited

Loading

jasperhuangg commented Aug 15, 2023 •

edited

Loading