Skip to content

Payment issue for E/App PR#19675 #24209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
melvin-bot bot opened this issue Aug 7, 2023 · 37 comments
Closed

Payment issue for E/App PR#19675 #24209

melvin-bot bot opened this issue Aug 7, 2023 · 37 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Engineering Internal Requires API changes or must be handled by Expensify staff Monthly KSv2 Not a priority Reviewing Has a PR in review Task

Comments

@melvin-bot
Copy link

melvin-bot bot commented Aug 7, 2023

Issue created to compensate the Contributor+ member for their work on #19675
E/E issue linked to the PR - https://www.github.com/Expensify/Expensify/issues/215650.
Contributor+ member who reviewed the PR - @parasharrajat.

Wait 7 days after the PR is deployed to production before issuing payment in case there are regressions.

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~012911ed58beaa305b
  • Upwork Job ID: 1688535055767932928
  • Last Price Increase: 2023-08-07
@melvin-bot melvin-bot bot added Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Task Weekly KSv2 labels Aug 7, 2023
@melvin-bot melvin-bot bot added the Internal Requires API changes or must be handled by Expensify staff label Aug 7, 2023
@melvin-bot
Copy link
Author

melvin-bot bot commented Aug 7, 2023

Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link
Author

melvin-bot bot commented Aug 7, 2023

Job added to Upwork: https://www.upwork.com/jobs/~012911ed58beaa305b

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Aug 7, 2023
@melvin-bot
Copy link
Author

melvin-bot bot commented Aug 7, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@melvin-bot
Copy link
Author

melvin-bot bot commented Aug 7, 2023

Current assignee @parasharrajat is eligible for the Internal assigner, not assigning anyone new.

@laurenreidexpensify
Copy link
Contributor

@madmax330 looking at https://github.com/Expensify/Expensify/issues/215650 it's unclear whether the PR has hit prod yet - can you confirm the PR link pls?

@madmax330
Copy link
Contributor

The PR is here: #19675
It was merged, but not deployed yet

@laurenreidexpensify laurenreidexpensify added Weekly KSv2 and removed Daily KSv2 labels Aug 8, 2023
@laurenreidexpensify
Copy link
Contributor

Great thanks

@laurenreidexpensify
Copy link
Contributor

This has been on prod for a week now #19675 (comment) so payment can be issued

@laurenreidexpensify
Copy link
Contributor

Sorry @parasharrajat total force of habit - I sent you a job on Upwork :face_palm:

@laurenreidexpensify
Copy link
Contributor

Payment Summary:

  • $1000 due to C+ @parasharrajat for PR review, please request in newdot

@laurenreidexpensify laurenreidexpensify added Daily KSv2 and removed Weekly KSv2 labels Aug 18, 2023
@melvin-bot melvin-bot bot added the Overdue label Aug 21, 2023
@melvin-bot
Copy link
Author

melvin-bot bot commented Aug 21, 2023

@parasharrajat @laurenreidexpensify this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

1 similar comment
@melvin-bot
Copy link
Author

melvin-bot bot commented Aug 21, 2023

@parasharrajat @laurenreidexpensify this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@laurenreidexpensify
Copy link
Contributor

@parasharrajat cna you confirm if you've requested payment for this one?

@melvin-bot melvin-bot bot removed the Overdue label Aug 21, 2023
@parasharrajat
Copy link
Member

@laurenreidexpensify Not yet, the original PR was reverted which we still need to redeploy. I don't think this is quite ready for payment yet.

@melvin-bot melvin-bot bot removed the Overdue label Sep 26, 2023
@melvin-bot melvin-bot bot added the Overdue label Oct 5, 2023
@madmax330
Copy link
Contributor

Commented on the other issue, will try to get this back up by EOW

@melvin-bot melvin-bot bot removed the Overdue label Oct 11, 2023
@melvin-bot melvin-bot bot added the Overdue label Oct 19, 2023
@laurenreidexpensify
Copy link
Contributor

Im' gonna remove myself from this issue, cos @parasharrajat can request payment directly in newdot when this is ready, so no need for extra oversight from me 👍

@melvin-bot melvin-bot bot removed the Overdue label Oct 20, 2023
@laurenreidexpensify laurenreidexpensify removed their assignment Oct 20, 2023
@parasharrajat
Copy link
Member

@madmax330 Bump.

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Weekly KSv2 labels Nov 2, 2023
@madmax330
Copy link
Contributor

PR is back up. Still need to do some testing

@melvin-bot melvin-bot bot added Monthly KSv2 and removed Weekly KSv2 labels Nov 27, 2023
Copy link
Author

melvin-bot bot commented Nov 27, 2023

This issue has not been updated in over 15 days. @madmax330, @parasharrajat eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@melvin-bot melvin-bot bot closed this as completed Jan 29, 2024
Copy link
Author

melvin-bot bot commented Jan 29, 2024

@madmax330, @parasharrajat, this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

@madmax330 madmax330 reopened this Jan 29, 2024
@melvin-bot melvin-bot bot closed this as completed Jan 30, 2024
Copy link
Author

melvin-bot bot commented Jan 30, 2024

@madmax330, @parasharrajat, this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

@madmax330 madmax330 reopened this Jan 31, 2024
@melvin-bot melvin-bot bot closed this as completed Jan 31, 2024
Copy link
Author

melvin-bot bot commented Jan 31, 2024

@madmax330, @parasharrajat, this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

@parasharrajat
Copy link
Member

parasharrajat commented Mar 8, 2024

Looks like this change was deprioritized and thus PR #30782 (comment) was closed. @laurenreidexpensify Can you please finalize the payment summary now? This #24209 (comment) was the last summary.

@mallenexpensify
Copy link
Contributor

Contributor+: @parasharrajat due $500 via NewDot

After much, much back-n-forth with Rajat here, he's being compensated 50% of $1000 for the work he did reviewing PRs that were closed.

@parasharrajat
Copy link
Member

Payment requested as per #24209 (comment)

@JmillsExpensify
Copy link

$500 approved for @parasharrajat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Engineering Internal Requires API changes or must be handled by Expensify staff Monthly KSv2 Not a priority Reviewing Has a PR in review Task
Projects
None yet
Development

No branches or pull requests

5 participants