[HOLD for payment 2023-08-16] [$1000] Payments - On add debit card page state field seems to have extra horizontal spacing

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Login to ND
2. Press Avatar button to open settings page
3. Navigate to Payments -> Add Payment method ->Select Debit card
4. Notice State field has extra margin horizontal than the other inputs

Expected Result:

State field should not have extra horizontal spacing like text input

Actual Result:

Extra horizontal spacing on state field

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.47-5
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:
Issue reported by: @dhairyasenjaliya
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1690577968526579

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0199c0e50fda86a4c5
• Upwork Job ID: 1686055085493682176
• Last Price Increase: 2023-07-31
• Automatic offers:
• dhairyasenjaliya | Contributor | 25928715
• dhairyasenjaliya | Reporter | 25928718

[melvin-bot]

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[kbecciv]

Proposal by: @dhairyasenjaliya
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1690577968526579

Proposal

Please re-state the problem that we are trying to solve in this issue.

• On add debit card page state field seems to have extra horizontal spacing

What is the root cause of that problem?

• The root cause is we on <Form> we have added styles.mh5 that will add horizontal spacing to entire page but for state picker we have not adjusted horizontal padding just like other pages that will have opacity to entire <Menu> just like other pages

What changes do you think we should make in order to solve the problem?

Solution - 1

• On AddDebitCardPage.js page we just need to add styles.mhn5 to the <View> that basically wraps the <StatePicker>
• We are using same styles.mhn5 to other pages we have added <StatePicker>

Solution - 2

• For <StatePicker> component we can define new props to allow styles from parent
• And then we can just pass style of marginTop and marginHorizontal to <StatePicker>
• We can remove <View> that wraps component from all the pages that we have used <StatePicker> E.g : AddressForm.js, CompanyStep.js, AddDebitCardPage.js, AddressPage.js
• It will be cleanup to remove <View> that will be not necessary after providing styles directly to component

Solution - 3

• We can add styles.mhn5 directly to <StatePicker>

What alternative solutions did you explore? (Optional)

• N/A
  ———————

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0199c0e50fda86a4c5

[melvin-bot]

Current assignee @garrettmknight is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

[garrettmknight]

Easy, Melv. We're waiting for proposals.