Android - Lounge Access - Lounge access animation page loads with delay

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue found when executing PR #23061

Action Performed:

1. Open the App
2. Login with any Expensifail account
3. Go to Settings -> Profile -> Lounge access

Expected Result:

Lounge access animation page loads without delay

Actual Result:

Lounge access animation page loads with delay

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: v1.3.46-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Bug6142933_Record_2023-07-27-02-04-05_4f9154176b47c00da84e32064abf1c48__1_.mp4

Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[hungvu193]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Android - Lounge Access - Lounge access animation page loads with delay

What is the root cause of that problem?

We're using IllustratedHeaderPageLayout which has Lottie animation to wrap the LoungeAccessPage which caused the issue with some devices, since with react-navigation it will render the next screen before navigating.

App/src/pages/settings/Profile/LoungeAccessPage.js

Lines 46 to 58 in 0cccb4e

	<IllustratedHeaderPageLayout
	title={translate('loungeAccessPage.loungeAccess')}
	onBackButtonPress={() => Navigation.goBack(ROUTES.SETTINGS)}
	illustration={LottieAnimations.ExpensifyLounge}
	>
	<FeatureList
	headline="loungeAccessPage.headline"
	description="loungeAccessPage.description"
	menuItems={menuItems}
	/>
	</IllustratedHeaderPageLayout>
	);
	}

App/src/components/IllustratedHeaderPageLayout.js

Lines 59 to 68 in 0cccb4e

	<View style={[styles.alignItemsCenter, styles.justifyContentEnd, StyleUtils.getBackgroundColorStyle(backgroundColor)]}>
	<Lottie
	source={illustration}
	style={styles.w100}
	autoPlay
	loop
	/>
	</View>
	<View style={[styles.pt5]}>{children}</View>
	</ScrollView>

What changes do you think we should make in order to solve the problem?

We should wait for transition end before display the view, before that we should display the skeleton view.
In order to do that, we gonna implement onEntryTransitionEnd inside IllustratedHeaderPageLayout and add a check. If transition end, we display the Lottie animation and children, otherwise we display the skeleton view.

{
onEndTransition ? <ChildrenAndLottie /> : <SkeletonView />
}

What alternative solutions did you explore? (Optional)

N/A

Result

Screen.Recording.2023-07-27.at.20.17.48.mov

[sakluger]

Thanks for reporting! This is actually being addressed in the original issue where the Lounge Access page animation was added, so I'm going to close this bug report for now. In the long term, we're likely going to implement implementing DotLottie file support for iOS and Android, which should cut down animation filesizes by a huge amount. In the meantime, we're using an optimized Lottie JSON which will cut down the filesize from 4MB to 2.6MB.